From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::143; helo=mail-it1-x143.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x143.google.com (mail-it1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ADF922118C51C for ; Wed, 21 Nov 2018 14:16:38 -0800 (PST) Received: by mail-it1-x143.google.com with SMTP id g85so11298896ita.3 for ; Wed, 21 Nov 2018 14:16:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0or5zy3xcDOucKoOYyizhO1cMHcsOsAix0hHFASwiTY=; b=DUD+8eOqxcSWsARYQZ3uVRZgtTLA5aLIv2ZT2xMWYwKMrsvR3DJy09043PB4aESyF4 KOfLq8Qr4P8PTDiS7km4NC7TkmCsXP5qgXfAQ55KPlg+zSyyrs0wAAmbaQmQoCz0bsv9 I4fnMg08PuR3zW2FNHg/b3uutAir27lEyKxm8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0or5zy3xcDOucKoOYyizhO1cMHcsOsAix0hHFASwiTY=; b=PFQEF88cpYNKE7cPGGBL9BXZcDnHl5X0Ln7Bb0d9eJZdhBt6puW6eNcU9EJ4TfUVDd qnv1TJJOm+PCyCdJ4Xll09Lkp5WIdBE87W5Vzeu93vI+lmGCf4jdisfQ4VQP9tQ+7pnU Gt4GWgtHIiYxpP8ZAb/5Py1H2ZIR+G4MpseDeS3yvQJJVZfTuLLmir2Oswctahdf/bGv TZ2WShh+yQfcHLnc5VBFKuvV+xruGKVbbViu2iNtkU5FxLXGH/FhCBu5PcOahuJl7cvH qjbxWbqimPjfb8u82Hg6zzP+7cHqqGNkUCTTSjBY3/L44a0WOILsfihmv0urZkaJsnPA Q5pQ== X-Gm-Message-State: AA+aEWY9yNPD8I6QbWnhzfyd8Sj2rdWyLWpEDFICLta0q4UKXNpHryzf C7iXHb8sX5hgpDLxmByKwD3ZlfL3dlCgg0qMu7b9Jg== X-Google-Smtp-Source: AFSGD/XmEKU6VxZ6I2kjLOv2ut0vkaLyZKh+1Witsbut8S1PWQ3G3xeVt3p03IhhJ9M5KwbwCvIcwTWi0juixzKizlI= X-Received: by 2002:a02:4c9:: with SMTP id 192mr7057606jab.2.1542838597513; Wed, 21 Nov 2018 14:16:37 -0800 (PST) MIME-Version: 1.0 References: <20181121120145.3148-1-ard.biesheuvel@linaro.org> In-Reply-To: From: Ard Biesheuvel Date: Wed, 21 Nov 2018 23:16:26 +0100 Message-ID: To: Thomas Panakamattam Abraham Cc: "edk2-devel@lists.01.org" , Nariman Poushin Subject: Re: [PATCH edk2-platforms 0/3] drop GUIDs from NOR flash bank descriptors X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 22:16:38 -0000 Content-Type: text/plain; charset="UTF-8" On Wed, 21 Nov 2018 at 14:48, Thomas Abraham wrote: > > Hi Ard, > > On Wed, Nov 21, 2018 at 5:31 PM Ard Biesheuvel > wrote: > > > > Align edk2-platform with upcoming changes to EDK2 to get rid of per-bank > > NOR flash GUIDs. > > > > Ard Biesheuvel (3): > > Platform/ARM: replace hardcoded VenHW() device paths referring to NOR > > flash > > Silicon/SynQuacer: drop per-bank NOR flash GUIDs > > Platform/ARM: drop per-bank NOR flash GUIDs > > > > Platform/ARM/JunoPkg/ArmJuno.dec | 2 +- > > Platform/ARM/JunoPkg/ArmJuno.dsc | 2 +- > > .../JunoPkg/Library/NorFlashJunoLib/NorFlashJuno.c | 2 -- > > .../ARM/SgiPkg/Library/NorFlashLib/NorFlashLib.c | 2 -- > > Platform/ARM/SgiPkg/SgiPlatform.dsc | 2 +- > > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 2 +- > > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 2 +- > > .../NorFlashArmVExpressLib/NorFlashArmVExpress.c | 4 ---- > > .../SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.c | 14 +++++++------- > > .../SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.h | 3 +++ > > .../NorFlashSynQuacerLib/NorFlashSynQuacer.c | 6 ------ > > 11 files changed, 15 insertions(+), 26 deletions(-) > > Tested this patch series and "[PATCH v2 0/5] ArmPlatformPkg, > ArmVirtPkg: discover NOR flash banks from DTB" patch series on the > Juno board. With these patches applied, the boot fails on Juno board > with the following messages. I have not yet tried to debug the issue > but wanted to let you know this. > > [...] > Loading driver at 0x000F830C000 EntryPoint=0x000F831B2AC IScsiDxe.efi > add-symbol-file > /home/thopan01/devel/juno/uefi/uefi/edk2/Build/ArmJuno/DEBUG_GCC5/AARCH64/MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe/DEBUG/Udp4Dxe.dll > 0xF8300000 > Loading driver at 0x000F82FF000 EntryPoint=0x000F8306DF0 Udp4Dxe.efi > add-symbol-file > /home/thopan01/devel/juno/uefi/uefi/edk2/Build/ArmJuno/DEBUG_GCC5/AARCH64/Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe/DEBUG/FdtPlatformDxe.dll > 0xF82EE000 > Loading driver at 0x000F82ED000 EntryPoint=0x000F82F76EC FdtPlatformDxe.efi > Found image: fip in block 5. > Found image: norkern in block 20. > Found image: ramdisk.img in block 116. > Found image: hdlcdclk in block 151. > Found image: selftest in block 152. > Found image: board.dtb in block 156. > Found image: scp_bl1 in block 249. > Found image: bl1 in block 251. > Found image: startup.nsh in block 252. > ASSERT [BootMonFs] > /home/thopan01/devel/juno/uefi/uefi/edk2/MdePkg/Library/BaseLib/String.c(173): > ((UINTN) String & 0x00000001) == 0 > Hi Thomas, Thanks for testing. Could you please apply this patch and re-test: --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc @@ -299,7 +299,7 @@ !if $(TARGET) == RELEASE gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x21 !else - gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x2f + gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x3f !endif # DEBUG_INIT 0x00000001 // Initialization This will produce a backtrace when an ASSERT() is triggered, and from this we can figure out what the call stack looks like exactly (The ASSERT() occurs in StrLen (), which is called with a misaligned unicode string, but I cannot figure out where the call is made) Please share the backtrace and all the .dlls listed in it if you can please.