From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::141; helo=mail-it1-x141.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x141.google.com (mail-it1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C74192194D387 for ; Mon, 28 Jan 2019 02:25:14 -0800 (PST) Received: by mail-it1-x141.google.com with SMTP id h193so18544200ita.5 for ; Mon, 28 Jan 2019 02:25:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sFRGFfNvD2Q5tUvZazSYKFXdn7KyePYhbFwOpUXdhE4=; b=bsD7Sw/9QNPssa+4VXoP5hPdt+4lKUH0BD3sk6TGTpMO+O/PpQpNsVouofF844CMuj mVdG8oyJ2jXsQEppHI1Iq1AVXB8pgwfuqED28z0GjT9WFRlEziTML2qJaqJoLEtZYJOw tE+CxcmRx1qUVv+6anQ/Th6DQpO8PGavkNkVM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sFRGFfNvD2Q5tUvZazSYKFXdn7KyePYhbFwOpUXdhE4=; b=UaihpbA3XqXAefc4XTjPRt/iEfUDz0GGlj9M0AQ8tBjvzjO45cpNZcqRus4wG+HlzJ 1FqRFfP/B99zK+O1xhY24YeQMewboWkm6u7/gGDlPALfs9cuwX/9W/aFqsN/C8I9LJ58 E9lJfqVlTHcepPyIWRYZjdpSa/ctUT4XA1+98y8KBDHA22HqtsC76q0sVrj3oMxiPQXo ugr9W6deqEoPr5pKr9+dRIviaUQgpRntp39/pNxKYBlHa/oefX7nQOTm/Znc5IMqFi/O UhV5OXCkpmF/r0HROZP2Yc21KBNC8VV8qwHtBqqZ3mJthOlLA8fCeVQkJg9V7k+2SD8d LyHA== X-Gm-Message-State: AJcUukf4LegtbeG8wsg12ZFUi4HKH29D90/E4VacljcNpVX2wYEYFpqF JOFDf7uB5S/27yIc3NO2HJkF5I7Ye4qYTr6yqgS4dQ== X-Google-Smtp-Source: ALg8bN6kt46svwL0G9BfF85DPNgnPXlhxsHtmLM2iZvTVxxXpIlbxE1p4uSX/5Ye55Xp71QHTvdum/2jEY4LzyHHGh0= X-Received: by 2002:a05:660c:4b:: with SMTP id p11mr10181937itk.71.1548671113650; Mon, 28 Jan 2019 02:25:13 -0800 (PST) MIME-Version: 1.0 References: <20190125081205.2967-1-ard.biesheuvel@linaro.org> <3C0D5C461C9E904E8F62152F6274C0BB40B8D677@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB40B8D677@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Mon, 28 Jan 2019 11:25:02 +0100 Message-ID: To: "Bi, Dandan" Cc: "edk2-devel@lists.01.org" , "Gao, Liming" Subject: Re: [PATCH] MdeModulePkg/MdeModulePkg.dsc: ignore standalone MM modules for EBC or XCODE5 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2019 10:25:15 -0000 X-List-Received-Date: Mon, 28 Jan 2019 10:25:15 -0000 X-List-Received-Date: Mon, 28 Jan 2019 10:25:15 -0000 X-List-Received-Date: Mon, 28 Jan 2019 10:25:15 -0000 X-List-Received-Date: Mon, 28 Jan 2019 10:25:15 -0000 X-List-Received-Date: Mon, 28 Jan 2019 10:25:15 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, 28 Jan 2019 at 02:56, Bi, Dandan wrote: > > Reviewed-by: Bi Dandan > Thanks all Pushed as 12a0a80b4aee..945c1d55c933 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Ard Biesheuvel > > Sent: Friday, January 25, 2019 4:12 PM > > To: edk2-devel@lists.01.org > > Cc: Bi, Dandan ; Gao, Liming > > Subject: [edk2] [PATCH] MdeModulePkg/MdeModulePkg.dsc: ignore > > standalone MM modules for EBC or XCODE5 > > > > The newly added standalone MM versions of the FTW and variable runtime > > drivers were included in MdeModulePkg.dsc to get test coverage when > > building the package from its own .dsc, but the resulting modules are non- > > functional since they incorporate some dummy libraries. > > > > Dandan reports that these modules don't build cleanly when using the EBC or > > XCODE5 compilers, so given the above, let's just ignore them in this case. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > --- > > MdeModulePkg/MdeModulePkg.dsc | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/MdeModulePkg/MdeModulePkg.dsc > > b/MdeModulePkg/MdeModulePkg.dsc index 93eaf4b404a1..55eca4d74c04 > > 100644 > > --- a/MdeModulePkg/MdeModulePkg.dsc > > +++ b/MdeModulePkg/MdeModulePkg.dsc > > @@ -426,9 +426,6 @@ [Components] > > MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf > > MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf > > > > - > > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStanda > > loneMm.inf > > - > > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf > > - > > [Components.IA32, Components.X64, Components.AARCH64] > > MdeModulePkg/Universal/EbcDxe/EbcDxe.inf > > MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf > > @@ -442,6 +439,11 @@ [Components.IA32, Components.X64, > > Components.ARM, Components.AARCH64] > > > > NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32G > > uidedSectionExtractLib.inf > > } > > > > +!if $(TOOL_CHAIN_TAG) != "XCODE5" > > + > > +MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStan > > dalo > > +neMm.inf > > + > > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf > > +!endif > > + > > [Components.IA32, Components.X64, Components.Ebc] > > > > MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntime > > Dxe.inf > > > > -- > > 2.17.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel