public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Pete Batard <pete@akeo.ie>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	 "Gao, Liming" <liming.gao@intel.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	"Leif Lindholm" <leif.lindholm@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [edk2][PATCH 1/1] MdePkg/Include: Add DCC and BCM2835 SPCR UART types
Date: Wed, 11 Dec 2019 10:00:41 +0000	[thread overview]
Message-ID: <CAKv+Gu9qE9eiX7FNmwosNM5MBP__p7=XkrV2sp3m-1EUz6AgOg@mail.gmail.com> (raw)
In-Reply-To: <20191210182304.13540-1-pete@akeo.ie>

(add MdePkg maintainers)

On Tue, 10 Dec 2019 at 19:23, Pete Batard <pete@akeo.ie> wrote:
>
> As per the Microsoft Debug Port Table 2 (DBG2) documentation, that
> can be found online, we are missing 2 serial interface types for
> Arm DCC and Bcm2835 (the latter being used with the Raspberry Pi).
>
> These same types are present in DebugPort2Table.h so add them to
> SerialPortConsoleRedirectionTable.h too.
>
> Note that we followed the same idiosyncrasies as DebugPort2Table
> for naming these new macros.
>
> Signed-off-by: Pete Batard <pete@akeo.ie>

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index b069fb2be97f..2066c7895e59 100644
> --- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> @@ -90,6 +90,16 @@ typedef struct {
>  ///
>  #define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_ARM_SBSA_GENERIC_UART     0x0e
>
> +///
> +/// ARM DCC
> +///
> +#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_DCC                       0x0f
> +
> +///
> +/// BCM2835 UART
> +///
> +#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_BCM2835_UART              0x10
> +
>  //
>  // Interrupt Type
>  //
> --
> 2.21.0.windows.1
>

  reply	other threads:[~2019-12-11 10:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-10 18:23 [edk2][PATCH 1/1] MdePkg/Include: Add DCC and BCM2835 SPCR UART types Pete Batard
2019-12-11 10:00 ` Ard Biesheuvel [this message]
2019-12-12  0:26   ` Liming Gao
2019-12-12  7:34     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu9qE9eiX7FNmwosNM5MBP__p7=XkrV2sp3m-1EUz6AgOg@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox