* [edk2][PATCH 1/1] MdePkg/Include: Add DCC and BCM2835 SPCR UART types
@ 2019-12-10 18:23 Pete Batard
2019-12-11 10:00 ` Ard Biesheuvel
0 siblings, 1 reply; 4+ messages in thread
From: Pete Batard @ 2019-12-10 18:23 UTC (permalink / raw)
To: devel; +Cc: ard.biesheuvel, leif.lindholm, philmd
As per the Microsoft Debug Port Table 2 (DBG2) documentation, that
can be found online, we are missing 2 serial interface types for
Arm DCC and Bcm2835 (the latter being used with the Raspberry Pi).
These same types are present in DebugPort2Table.h so add them to
SerialPortConsoleRedirectionTable.h too.
Note that we followed the same idiosyncrasies as DebugPort2Table
for naming these new macros.
Signed-off-by: Pete Batard <pete@akeo.ie>
---
MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
index b069fb2be97f..2066c7895e59 100644
--- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
+++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
@@ -90,6 +90,16 @@ typedef struct {
///
#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_ARM_SBSA_GENERIC_UART 0x0e
+///
+/// ARM DCC
+///
+#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_DCC 0x0f
+
+///
+/// BCM2835 UART
+///
+#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_BCM2835_UART 0x10
+
//
// Interrupt Type
//
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2][PATCH 1/1] MdePkg/Include: Add DCC and BCM2835 SPCR UART types
2019-12-10 18:23 [edk2][PATCH 1/1] MdePkg/Include: Add DCC and BCM2835 SPCR UART types Pete Batard
@ 2019-12-11 10:00 ` Ard Biesheuvel
2019-12-12 0:26 ` Liming Gao
0 siblings, 1 reply; 4+ messages in thread
From: Ard Biesheuvel @ 2019-12-11 10:00 UTC (permalink / raw)
To: Pete Batard, Kinney, Michael D, Gao, Liming
Cc: edk2-devel-groups-io, Leif Lindholm, Philippe Mathieu-Daudé
(add MdePkg maintainers)
On Tue, 10 Dec 2019 at 19:23, Pete Batard <pete@akeo.ie> wrote:
>
> As per the Microsoft Debug Port Table 2 (DBG2) documentation, that
> can be found online, we are missing 2 serial interface types for
> Arm DCC and Bcm2835 (the latter being used with the Raspberry Pi).
>
> These same types are present in DebugPort2Table.h so add them to
> SerialPortConsoleRedirectionTable.h too.
>
> Note that we followed the same idiosyncrasies as DebugPort2Table
> for naming these new macros.
>
> Signed-off-by: Pete Batard <pete@akeo.ie>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index b069fb2be97f..2066c7895e59 100644
> --- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> @@ -90,6 +90,16 @@ typedef struct {
> ///
> #define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_ARM_SBSA_GENERIC_UART 0x0e
>
> +///
> +/// ARM DCC
> +///
> +#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_DCC 0x0f
> +
> +///
> +/// BCM2835 UART
> +///
> +#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_BCM2835_UART 0x10
> +
> //
> // Interrupt Type
> //
> --
> 2.21.0.windows.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2][PATCH 1/1] MdePkg/Include: Add DCC and BCM2835 SPCR UART types
2019-12-11 10:00 ` Ard Biesheuvel
@ 2019-12-12 0:26 ` Liming Gao
2019-12-12 7:34 ` Ard Biesheuvel
0 siblings, 1 reply; 4+ messages in thread
From: Liming Gao @ 2019-12-12 0:26 UTC (permalink / raw)
To: Ard Biesheuvel, Pete Batard, Kinney, Michael D
Cc: edk2-devel-groups-io, Leif Lindholm, Philippe Mathieu-Daudé
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Sent: Wednesday, December 11, 2019 6:01 PM
> To: Pete Batard <pete@akeo.ie>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
> Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Leif Lindholm <leif.lindholm@linaro.org>; Philippe Mathieu-Daudé
> <philmd@redhat.com>
> Subject: Re: [edk2][PATCH 1/1] MdePkg/Include: Add DCC and BCM2835 SPCR UART types
>
> (add MdePkg maintainers)
>
> On Tue, 10 Dec 2019 at 19:23, Pete Batard <pete@akeo.ie> wrote:
> >
> > As per the Microsoft Debug Port Table 2 (DBG2) documentation, that
> > can be found online, we are missing 2 serial interface types for
> > Arm DCC and Bcm2835 (the latter being used with the Raspberry Pi).
> >
> > These same types are present in DebugPort2Table.h so add them to
> > SerialPortConsoleRedirectionTable.h too.
> >
> > Note that we followed the same idiosyncrasies as DebugPort2Table
> > for naming these new macros.
> >
> > Signed-off-by: Pete Batard <pete@akeo.ie>
>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> > ---
> > MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > index b069fb2be97f..2066c7895e59 100644
> > --- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > +++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > @@ -90,6 +90,16 @@ typedef struct {
> > ///
> > #define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_ARM_SBSA_GENERIC_UART 0x0e
> >
> > +///
> > +/// ARM DCC
> > +///
> > +#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_DCC 0x0f
> > +
> > +///
> > +/// BCM2835 UART
> > +///
> > +#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_BCM2835_UART 0x10
> > +
> > //
> > // Interrupt Type
> > //
> > --
> > 2.21.0.windows.1
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2][PATCH 1/1] MdePkg/Include: Add DCC and BCM2835 SPCR UART types
2019-12-12 0:26 ` Liming Gao
@ 2019-12-12 7:34 ` Ard Biesheuvel
0 siblings, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2019-12-12 7:34 UTC (permalink / raw)
To: Gao, Liming
Cc: Pete Batard, Kinney, Michael D, edk2-devel-groups-io,
Leif Lindholm, Philippe Mathieu-Daudé
On Thu, 12 Dec 2019 at 01:26, Gao, Liming <liming.gao@intel.com> wrote:
>
> Reviewed-by: Liming Gao <liming.gao@intel.com>
>
Thanks
Pushed as bfb141cf19dd6f9b8df8b9d0914a5b3b15e1a798
> > -----Original Message-----
> > From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Sent: Wednesday, December 11, 2019 6:01 PM
> > To: Pete Batard <pete@akeo.ie>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
> > Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Leif Lindholm <leif.lindholm@linaro.org>; Philippe Mathieu-Daudé
> > <philmd@redhat.com>
> > Subject: Re: [edk2][PATCH 1/1] MdePkg/Include: Add DCC and BCM2835 SPCR UART types
> >
> > (add MdePkg maintainers)
> >
> > On Tue, 10 Dec 2019 at 19:23, Pete Batard <pete@akeo.ie> wrote:
> > >
> > > As per the Microsoft Debug Port Table 2 (DBG2) documentation, that
> > > can be found online, we are missing 2 serial interface types for
> > > Arm DCC and Bcm2835 (the latter being used with the Raspberry Pi).
> > >
> > > These same types are present in DebugPort2Table.h so add them to
> > > SerialPortConsoleRedirectionTable.h too.
> > >
> > > Note that we followed the same idiosyncrasies as DebugPort2Table
> > > for naming these new macros.
> > >
> > > Signed-off-by: Pete Batard <pete@akeo.ie>
> >
> > Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >
> > > ---
> > > MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h | 10 ++++++++++
> > > 1 file changed, 10 insertions(+)
> > >
> > > diff --git a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > > index b069fb2be97f..2066c7895e59 100644
> > > --- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > > +++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > > @@ -90,6 +90,16 @@ typedef struct {
> > > ///
> > > #define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_ARM_SBSA_GENERIC_UART 0x0e
> > >
> > > +///
> > > +/// ARM DCC
> > > +///
> > > +#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_DCC 0x0f
> > > +
> > > +///
> > > +/// BCM2835 UART
> > > +///
> > > +#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_BCM2835_UART 0x10
> > > +
> > > //
> > > // Interrupt Type
> > > //
> > > --
> > > 2.21.0.windows.1
> > >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-12 7:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-10 18:23 [edk2][PATCH 1/1] MdePkg/Include: Add DCC and BCM2835 SPCR UART types Pete Batard
2019-12-11 10:00 ` Ard Biesheuvel
2019-12-12 0:26 ` Liming Gao
2019-12-12 7:34 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox