From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web11.1619.1576058444460511936 for ; Wed, 11 Dec 2019 02:00:45 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=Z4MJdE9b; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wm1-f68.google.com with SMTP id p17so6292297wma.1 for ; Wed, 11 Dec 2019 02:00:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hKlEap0Q5UMB4SE/SYXIj1Zx6x1HS00hoB8rkkJ4LpM=; b=Z4MJdE9bYaMU5pthrFtIyWfpJaff+h6d0L29royfS5yatotcUNt7OipJPF/okyZi2l nXP6UvwRhF/pLaS9rjdYNIMoxSVMkuLox9WuvQLFDATvXmUydKUVZLCq/Si+FvbC8sZ1 fnRzGV5/c1vdOHE4yLPakNm/M/6rfmbvV8hJBouMyKgOwbez9WcnFb0kWEEKQGtYPnqO sFlHZa71b/h1+3z+2KFXM1mJTgUGOEsHqTZ7GY+YNFXlurb2b9jOhAWW0sqp7Mz5bO/R YorCcwnKNIKuRLXVbN6Gs+/2PPi855dOLjIEYkf3MkaLibZ2oBBITj/k6zOVFlp+yk4k K3Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hKlEap0Q5UMB4SE/SYXIj1Zx6x1HS00hoB8rkkJ4LpM=; b=JsKJwNxOmquYsRHqzNDhu3itqvam/s4unrqpFCJESKcCVm90T4CVnuZNj5Xzogz15O GzOvK/AF+NNe5w3THgA/uVb9kQY8TwPtGPJcfq1SEqhicPwONDBYPj4qDox8BLslFtuR /HKuZ+wTVflvvi99b82OMDfMrrDEjlQFhtFwgtFdq8MzhJsnXkwRB+Ff/V9rIHevf8eO Y1FvjeQ/f1zyQnJYWW9uon9ouMx+4tXn39ijMUYvy+u6bWFR32jS65nBWxse2lzDhEHf U6LVIO/LUXdu/HZR200ngoxIrfBdgHSHkTPVD6vFzOh5aSeA1g6m91JW5t2CHF5rJK+V a85w== X-Gm-Message-State: APjAAAUvzYvmLf6RzSTbKmxtZJN5Upsq4VQJOB4Rq8i0esjHG63IT8wX ZhJknQ2cbVagUuH2hJPhQybIMcgUsi5gCS9CzPRKgw== X-Google-Smtp-Source: APXvYqyQ33E5YxIf6bHgtiE8ibddyQudoBCCbhnHPVkjGnlEDsbJJzevZ2WgT8IfwiQDEgIp2IaSCgvcSicd282lpX8= X-Received: by 2002:a1c:a795:: with SMTP id q143mr2492041wme.52.1576058442916; Wed, 11 Dec 2019 02:00:42 -0800 (PST) MIME-Version: 1.0 References: <20191210182304.13540-1-pete@akeo.ie> In-Reply-To: <20191210182304.13540-1-pete@akeo.ie> From: "Ard Biesheuvel" Date: Wed, 11 Dec 2019 10:00:41 +0000 Message-ID: Subject: Re: [edk2][PATCH 1/1] MdePkg/Include: Add DCC and BCM2835 SPCR UART types To: Pete Batard , "Kinney, Michael D" , "Gao, Liming" Cc: edk2-devel-groups-io , Leif Lindholm , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" (add MdePkg maintainers) On Tue, 10 Dec 2019 at 19:23, Pete Batard wrote: > > As per the Microsoft Debug Port Table 2 (DBG2) documentation, that > can be found online, we are missing 2 serial interface types for > Arm DCC and Bcm2835 (the latter being used with the Raspberry Pi). > > These same types are present in DebugPort2Table.h so add them to > SerialPortConsoleRedirectionTable.h too. > > Note that we followed the same idiosyncrasies as DebugPort2Table > for naming these new macros. > > Signed-off-by: Pete Batard Acked-by: Ard Biesheuvel > --- > MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h > index b069fb2be97f..2066c7895e59 100644 > --- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h > +++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h > @@ -90,6 +90,16 @@ typedef struct { > /// > #define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_ARM_SBSA_GENERIC_UART 0x0e > > +/// > +/// ARM DCC > +/// > +#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_DCC 0x0f > + > +/// > +/// BCM2835 UART > +/// > +#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_BCM2835_UART 0x10 > + > // > // Interrupt Type > // > -- > 2.21.0.windows.1 >