public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Ryan Harkin <ryan.harkin@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH v3 0/6] Juno cleanup -- EDK2 edition
Date: Tue, 4 Apr 2017 16:49:52 +0100	[thread overview]
Message-ID: <CAKv+Gu9qj=QbeXfUXcnZz+SVZiKawt+juGO7JdnQafCOn-b2zg@mail.gmail.com> (raw)
In-Reply-To: <CAD0U-h+HLtnwznENJUwrA76QxSQGGa6mzzvg40rkubhOK1Mxww@mail.gmail.com>

On 4 April 2017 at 16:48, Ryan Harkin <ryan.harkin@linaro.org> wrote:
> On 4 April 2017 at 16:47, Ryan Harkin <ryan.harkin@linaro.org> wrote:
>> On 4 April 2017 at 13:30, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>>> This is tagged as v3 because these patches have been isolated from a
>>> ArmPlatformPkg cleanup series that is mostly about ACPI vs DT.
>>>
>>> This series is specific to Juno; it replaces the cargo culted and ancient
>>> PCI 'emulation' code with calls into the new non-discoverable device API,
>>> and removes the Juno specific PCI host bridge driver in favor of the generic
>>> one.
>>>
>>> Ard Biesheuvel (6):
>>>   ArmPlatformPkg/ArmShellCmdRunAxf: remove BdsLib dependency
>>>   ArmPlatformPkg/ArmJunoDxe: remove BdsLib dependency
>>>   ArmPlatformPkg/ArmJunoDxe: use the generic non-discoverable device
>>>     support
>>>   ArmPlatformPkg/ArmJunoDxe: don't register OnEndOfDxe event on rev R0
>>>   ArmPlatformPkg/ArmJunoPkg: remove PCI host bridge driver
>>>   ArmPlatformPkg/ArmJunoDxe: simplify ACPI table installation
>>>
>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c                            | 110 ++-
>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf                          |   4 +-
>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxeInternal.h                    |   5 -
>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.c                          | 596 ----------------
>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.h                          | 284 --------
>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciRootBridgeIo.c                       | 299 --------
>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.c                   | 199 ------
>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.h                   | 324 ---------
>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf              |  76 --
>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeResourceAllocation.c | 642 -----------------
>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c                   | 748 --------------------
>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.c                     | 170 -----
>>>  ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.h                     | 111 ---
>>>  ArmPlatformPkg/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf.inf                       |   1 -
>>>  ArmPlatformPkg/Library/ArmShellCmdRunAxf/RunAxf.c                                    |  58 +-
>>>  15 files changed, 104 insertions(+), 3523 deletions(-)
>>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.c
>>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.h
>>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciRootBridgeIo.c
>>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.c
>>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.h
>>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf
>>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeResourceAllocation.c
>>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c
>>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.c
>>>  delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.h
>>>
>>> --
>>> 2.9.3
>>>
>>
>> I tested the whole series in conjunction with the OpenPlatformPkg
>> series and it works fine on Juno R0/1/2, TC2 and FVP Foundation and
>> AEMv8 models.
>>
>> I tested PCIe ethernet and SATA HDD on R1 and R2, and a USB memory
>> stick on R0/1/2.
>
> Missed the actual Tested-by tag...
>
> Tested-by: Ryan Harkin <ryan.harkin@linaro.org>

Thank you! Much appreciated, especially since it took a bit more time
than I had anticipated.


      reply	other threads:[~2017-04-04 15:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-04 12:30 [PATCH v3 0/6] Juno cleanup -- EDK2 edition Ard Biesheuvel
2017-04-04 12:30 ` [PATCH v3 1/6] ArmPlatformPkg/ArmShellCmdRunAxf: remove BdsLib dependency Ard Biesheuvel
2017-04-05 13:09   ` Leif Lindholm
2017-04-05 13:11     ` Ard Biesheuvel
2017-04-05 13:15       ` Ard Biesheuvel
2017-04-05 14:56       ` Leif Lindholm
2017-04-04 12:30 ` [PATCH v3 2/6] ArmPlatformPkg/ArmJunoDxe: " Ard Biesheuvel
2017-04-05 13:19   ` Leif Lindholm
2017-04-04 12:30 ` [PATCH v3 3/6] ArmPlatformPkg/ArmJunoDxe: use the generic non-discoverable device support Ard Biesheuvel
2017-04-05 13:20   ` Leif Lindholm
2017-04-04 12:30 ` [PATCH v3 4/6] ArmPlatformPkg/ArmJunoDxe: don't register OnEndOfDxe event on rev R0 Ard Biesheuvel
2017-04-05 13:17   ` Leif Lindholm
2017-04-04 12:30 ` [PATCH v3 5/6] ArmPlatformPkg/ArmJunoPkg: remove PCI host bridge driver Ard Biesheuvel
2017-04-05 13:18   ` Leif Lindholm
2017-04-05 13:20     ` Ard Biesheuvel
2017-04-04 12:30 ` [PATCH v3 6/6] ArmPlatformPkg/ArmJunoDxe: simplify ACPI table installation Ard Biesheuvel
2017-04-05 13:19   ` Leif Lindholm
2017-04-04 15:47 ` [PATCH v3 0/6] Juno cleanup -- EDK2 edition Ryan Harkin
2017-04-04 15:48   ` Ryan Harkin
2017-04-04 15:49     ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu9qj=QbeXfUXcnZz+SVZiKawt+juGO7JdnQafCOn-b2zg@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox