From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22e.google.com (mail-it0-x22e.google.com [IPv6:2607:f8b0:4001:c0b::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8075821939312 for ; Tue, 4 Apr 2017 08:49:53 -0700 (PDT) Received: by mail-it0-x22e.google.com with SMTP id y18so62841711itc.1 for ; Tue, 04 Apr 2017 08:49:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=IVPLxwtn6E5FvfZo55iG3TEGrSpWJrw8eBv173dTTKg=; b=fjDfQqtwPaG214quoskaZRaSva4Pvg5AkIq7865WxzLAsIoByBTSetJVeQ878t0/cY +YiwXzDf7cieXOuUFu070ZfouX2IP7+KWfjEIzRYxVJo6HTNaNuKhFQHUe4YwulIce+7 DcgWGNHqqLFM524gTLrcOCFcbOhw/HgsI/Mv0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IVPLxwtn6E5FvfZo55iG3TEGrSpWJrw8eBv173dTTKg=; b=bHorvx4n4IsZq+5N84QOpcFp/XTN6bI4DhTv1Get4zIaXghDSCoPNcXn/EJW6NZm3g ekrAXnhv3L8po7zDLCbeeUe9SeTYY09E8ldvIj8f9vVFUSVeuCeSfghHXgJ15vw15SlA /cmRC3bs8TMwleMOmrif0IyBao4XVYfhY35WQvYL9YajnnD/cAWDSrGFCsJ9kEG7Y55f eZ3zl5nht4MmZFU9XFHO+klyRKlz/ppr0b9P2ojVzrBN+ES0XV9d0S/QtHHxYT3KgiUV q+siZcnT/3UyScyIGO7Dvn6osCG2nDthjOg2b3uPJKIGC/f/h3hIoe+ndofSRHSCzn5f DRVg== X-Gm-Message-State: AFeK/H1oIMnPr+lVB8MXj1QLMo37oLnhD1hAMyx7HyZh6I9QJAskB5og qx+Eht/Hs0OOAhq4MjaqqDZKYK+UMD5m X-Received: by 10.36.137.4 with SMTP id s4mr15580723itd.63.1491320992813; Tue, 04 Apr 2017 08:49:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.10.27 with HTTP; Tue, 4 Apr 2017 08:49:52 -0700 (PDT) In-Reply-To: References: <20170404123010.11722-1-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Tue, 4 Apr 2017 16:49:52 +0100 Message-ID: To: Ryan Harkin Cc: "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: [PATCH v3 0/6] Juno cleanup -- EDK2 edition X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 15:49:53 -0000 Content-Type: text/plain; charset=UTF-8 On 4 April 2017 at 16:48, Ryan Harkin wrote: > On 4 April 2017 at 16:47, Ryan Harkin wrote: >> On 4 April 2017 at 13:30, Ard Biesheuvel wrote: >>> This is tagged as v3 because these patches have been isolated from a >>> ArmPlatformPkg cleanup series that is mostly about ACPI vs DT. >>> >>> This series is specific to Juno; it replaces the cargo culted and ancient >>> PCI 'emulation' code with calls into the new non-discoverable device API, >>> and removes the Juno specific PCI host bridge driver in favor of the generic >>> one. >>> >>> Ard Biesheuvel (6): >>> ArmPlatformPkg/ArmShellCmdRunAxf: remove BdsLib dependency >>> ArmPlatformPkg/ArmJunoDxe: remove BdsLib dependency >>> ArmPlatformPkg/ArmJunoDxe: use the generic non-discoverable device >>> support >>> ArmPlatformPkg/ArmJunoDxe: don't register OnEndOfDxe event on rev R0 >>> ArmPlatformPkg/ArmJunoPkg: remove PCI host bridge driver >>> ArmPlatformPkg/ArmJunoDxe: simplify ACPI table installation >>> >>> ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 110 ++- >>> ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 4 +- >>> ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxeInternal.h | 5 - >>> ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.c | 596 ---------------- >>> ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.h | 284 -------- >>> ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciRootBridgeIo.c | 299 -------- >>> ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.c | 199 ------ >>> ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.h | 324 --------- >>> ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf | 76 -- >>> ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeResourceAllocation.c | 642 ----------------- >>> ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c | 748 -------------------- >>> ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.c | 170 ----- >>> ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.h | 111 --- >>> ArmPlatformPkg/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf.inf | 1 - >>> ArmPlatformPkg/Library/ArmShellCmdRunAxf/RunAxf.c | 58 +- >>> 15 files changed, 104 insertions(+), 3523 deletions(-) >>> delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.c >>> delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.h >>> delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciRootBridgeIo.c >>> delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.c >>> delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridge.h >>> delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf >>> delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeResourceAllocation.c >>> delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciRootBridge.c >>> delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.c >>> delete mode 100644 ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/XPressRich3.h >>> >>> -- >>> 2.9.3 >>> >> >> I tested the whole series in conjunction with the OpenPlatformPkg >> series and it works fine on Juno R0/1/2, TC2 and FVP Foundation and >> AEMv8 models. >> >> I tested PCIe ethernet and SATA HDD on R1 and R2, and a USB memory >> stick on R0/1/2. > > Missed the actual Tested-by tag... > > Tested-by: Ryan Harkin Thank you! Much appreciated, especially since it took a bit more time than I had anticipated.