From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::243; helo=mail-it0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D37CF202E611D for ; Wed, 8 Nov 2017 09:41:13 -0800 (PST) Received: by mail-it0-x243.google.com with SMTP id u132so4272922ita.0 for ; Wed, 08 Nov 2017 09:45:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=IKboUvR2tDs1ppvgI4scW1Z8omStkCZRCxD2UkvweYg=; b=GfyrxoYYwJrbghA0Uw0QaA9Hr/ldqf64473y7iTwYMGKUsqbGY6mztjY5ASZFyZmlo KCB5kv8XZGL7dOFiUCAiQ0dWPt+i1+E9ES8RmDeM2DJ8efPs1mqxxqGzRyBqTmPPESA1 hjKDaCo54sLEhu5N3VeXPV1+QtYaF0USJljQ0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IKboUvR2tDs1ppvgI4scW1Z8omStkCZRCxD2UkvweYg=; b=baTkwNeFyTsf/DwWtVFev4KbLoWWD2PtUUQj6WWTfJCygs3IWYVBEKP5sJ9KxO/ygx UVhua3iwE5oEe2bf13qfOCfZoeIV3foHaTXJLrYd/Zz1TM4GMqGEmXkCVQJQbL+cIr/n eAIrPjxr44pL+HM5HbeHWzrHxo1/rGA8xzn7z6gP/b2d91QB6GeT/Hi2Bcl0rVLY0A8/ MCh6N5qsn2QthjCOH7gyMk6UlPSB9k1+EaSGTVHu4i30Zzm9MSs4LJkSlFMiBx7PwMYx 6iRrCiFw5HwThL3SAKxrO6MOeJWRJG8m7Fnsv2t7s5Ahpv7bzo+DUDaFKylp9GgOaCTT SnOg== X-Gm-Message-State: AJaThX5mJe+mq7vmDxTaXoHUMxDI/gZnDX6ko4VY5n7P3cR23V02zbjT jq5Bp1pJHBtnkXT36B6nZx4LWxotdlc6P7de0wVjVA== X-Google-Smtp-Source: ABhQp+TSn/GH0dRreIHg7FatVDyPXBUugalmbzlrYyaDJ/rPCkq3HCgJw3KOLGjXTEvZGusB4PZiS1D3AoXHKzfT3Vc= X-Received: by 10.36.211.12 with SMTP id n12mr1810797itg.34.1510163113941; Wed, 08 Nov 2017 09:45:13 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.131.167 with HTTP; Wed, 8 Nov 2017 09:45:11 -0800 (PST) In-Reply-To: <20171108164758.edrae5f4invwybc6@bivouac.eciton.net> References: <20171103101654.30973-1-ard.biesheuvel@linaro.org> <20171103101654.30973-2-ard.biesheuvel@linaro.org> <20171108164758.edrae5f4invwybc6@bivouac.eciton.net> From: Ard Biesheuvel Date: Wed, 8 Nov 2017 17:45:11 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Daniel Thompson Subject: Re: [RFC PATCH edk2-platforms 1/3] Silicon/NXP: add RTC support library for PCF8563 I2C IP X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Nov 2017 17:41:14 -0000 Content-Type: text/plain; charset="UTF-8" On 8 November 2017 at 16:47, Leif Lindholm wrote: > On Fri, Nov 03, 2017 at 10:16:52AM +0000, Ard Biesheuvel wrote: >> Add a RealTimeClockLib implementation for the NXP PCF8563 as used on >> the Socionext Developer Box board. Note that the standard I2C protocol >> stack does not support runtime use, so this driver invokes the I2C master >> protocol directly. This requires support from the platform side as well, >> and so this driver will only attach to a I2C master that has the >> gPcf8563RealTimeClockLibI2cMasterProtolGuid protocol installed on its >> handle. It is up to the platform to ensure that the driver producing >> the I2C master protocol in question is runtime capable, and is not >> shared with the I2C protocol stack (i.e., it should not have the I2C >> Bus Configuration Management protocol installed as well). >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel > > Reviewed-by: Leif Lindholm > Ehm, is this in response to the correct patch, given that you already asked for some changes?