From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Star Zeng <star.zeng@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Liming Gao <liming.gao@intel.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET
Date: Tue, 13 Mar 2018 12:42:10 +0000 [thread overview]
Message-ID: <CAKv+Gu9rPbf-jpA075QD8V3pZUwzF0wXJPR1eUDqDAUAzfxo7A@mail.gmail.com> (raw)
In-Reply-To: <1520931840-99248-1-git-send-email-star.zeng@intel.com>
On 13 March 2018 at 09:04, Star Zeng <star.zeng@intel.com> wrote:
> Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET.
> This change was missing at e8d2a9805286a2fd4f613697cf0cccb4a1ebc90d.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Please apply
> ---
> MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h b/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> index 5767ac82da21..c30a3ac7200f 100644
> --- a/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> +++ b/MdeModulePkg/Include/Guid/PcdDataBaseSignatureGuid.h
> @@ -32,7 +32,7 @@ typedef UINT64 SKU_ID;
> #define PCD_TYPE_VPD (0x4U << PCD_TYPE_SHIFT)
> #define PCD_TYPE_STRING (0x1U << PCD_TYPE_SHIFT)
>
> -#define PCD_TYPE_ALL_SET (PCD_TYPE_DATA | PCD_TYPE_HII | PCD_TYPE_VPD | PCD_TYPE_SKU_ENABLED | PCD_TYPE_STRING)
> +#define PCD_TYPE_ALL_SET (PCD_TYPE_DATA | PCD_TYPE_HII | PCD_TYPE_VPD | PCD_TYPE_STRING)
>
> #define PCD_DATUM_TYPE_SHIFT 24
>
> --
> 2.7.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-03-13 12:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 9:04 [PATCH] MdeModulePkg PCD: Remove PCD_TYPE_SKU_ENABLED in PCD_TYPE_ALL_SET Star Zeng
2018-03-13 9:14 ` Thomas Lamprecht
2018-03-13 9:22 ` Thomas Lamprecht
2018-03-13 9:37 ` Zeng, Star
2018-03-13 12:42 ` Ard Biesheuvel [this message]
2018-03-13 12:52 ` Zeng, Star
2018-03-13 12:47 ` Dong, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu9rPbf-jpA075QD8V3pZUwzF0wXJPR1eUDqDAUAzfxo7A@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox