From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68])
 by mx.groups.io with SMTP id smtpd.web10.49864.1585574449213230967
 for <devel@edk2.groups.io>;
 Mon, 30 Mar 2020 06:20:49 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=mzfjTJi3;
 spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: ard.biesheuvel@linaro.org)
Received: by mail-wm1-f68.google.com with SMTP id 26so15949350wmk.1
        for <devel@edk2.groups.io>; Mon, 30 Mar 2020 06:20:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=sYLPs4xMSbrdvi8pdumEhzNB7Ey1QMTIAvKaHf+LmMA=;
        b=mzfjTJi3bBPGazmJv1qbfmd9sOR9QAyRRbANc7kTCHbDlN2sgSx4v5TkpG80g11huV
         gsM1IV/vILcK8Tt4koGKzTmaQaR9LgysIIUagTQxLw0tmSwU/B/wC41ZUtWbIkn+A6e2
         hPWcBxrLzMGerpL0/eIA82uPOLiUFJtI3xHrointmSkxUrptMGTys4nL1r7gH/wCw3q9
         k66qFwbGqOwVM+J6iFDIxsi5iGsP/OvVyzGE9nwCHjuT1IwPkcilcWgvn/SBehVyJOWI
         QkpMMNGUM418v0q3O/cpuuNQ9D76pVlsVcmbEUTvdG25QQ/q32AX3KV5fQZ9Pg72stKQ
         ZVyA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=sYLPs4xMSbrdvi8pdumEhzNB7Ey1QMTIAvKaHf+LmMA=;
        b=Pt0D9cgzAHeVnJbjzKRam0bZnkibnbBqDkvRDnKA5Zp8Ew4amsIErP8onHlzitNQLg
         lkIV+4yLpIt6zOuxd6NrOiQbENV/lnUYzUxq79zELGqRNQkgNxP9TMij3sv4mpZRK2vo
         0HEQWYwoL2TQNvwHm2JmQZIVPs4It/mXfVUuc0ZNMFtZRY/fEtFl0qhmOdPVFRWDPKp1
         qNz+SfKd9xGTKd+0LBZ7AIS4cslSeDv3aog7egltClGDb/mPlAUXL3GpwtyIXNbrHzJM
         Ilqk25Lw2GQXBYzfdBKE1FIPI9giD+TRQVXV9vLxsLOaYQt2KJB/WUCLUBhRTdWaq78Z
         9yuw==
X-Gm-Message-State: ANhLgQ10lG5w5PJByTvVAEHDgULcBy7yjJs87ZYl3n5wkcxA4uo3KIPh
	Iq/FFUQRYwrAuuliKDudQ1juzBRJeUnrXa1rCHRgyA==
X-Google-Smtp-Source: ADFU+vtuzXF/SjY+Nhs1eghkg86V6gpxRpjAmQOI6u7ucHySlIVDsgGfURlK5dbnzrmkMypHgeeoGpg7qYl40JN58Wg=
X-Received: by 2002:a7b:cb81:: with SMTP id m1mr13031102wmi.1.1585574447772;
 Mon, 30 Mar 2020 06:20:47 -0700 (PDT)
MIME-Version: 1.0
References: <20200327130117.11304-1-pete@akeo.ie> <a3c8b289-6603-4e3d-9c19-9d16a27df9b6@akeo.ie>
 <CAKv+Gu_yThBiobM=mE_PdbKUYZhM25KCNCRfVZY9SA1FYXkZdw@mail.gmail.com>
 <adedcac4-a6d9-2332-afe9-f04bf0aa4817@akeo.ie> <CAKv+Gu8kr1nzJzPn63HgoU=afn_WZBNRcWzC0=oZ7kUvfkG1UQ@mail.gmail.com>
In-Reply-To: <CAKv+Gu8kr1nzJzPn63HgoU=afn_WZBNRcWzC0=oZ7kUvfkG1UQ@mail.gmail.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Mon, 30 Mar 2020 15:20:37 +0200
Message-ID: <CAKv+Gu9rzcOaTD1+QyJkM6Q9nFN0vxM06sm3p_tepf+1Absm3A@mail.gmail.com>
Subject: Re: [PATCH 1/1] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.3
To: Pete Batard <pete@akeo.ie>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Leif Lindholm <leif@nuviainc.com>
Content-Type: text/plain; charset="UTF-8"

On Mon, 30 Mar 2020 at 15:12, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> On Mon, 30 Mar 2020 at 15:09, Pete Batard <pete@akeo.ie> wrote:
> >
> > On 2020.03.30 14:06, Ard Biesheuvel wrote:
> > > On Fri, 27 Mar 2020 at 14:06, Pete Batard <pete@akeo.ie> wrote:
> > >>
> > >> Incidentally, this is not an [edk2-platform] patch, as the subject line
> > >> from previous mail seemed to indicate, but an [edk2] patch.
> > >>
> > >
> > > Do we have a user for this?
> >
> > Yes we do. I have a pachset lined up that updates the Raspberry Pi ACPI
> > to 6.3, that has a dependency on this.
> >
>
> But does the RPi have SPE and the associated overflow interrupt? ACPI
> is designed to be backward compatible, so it is perfectly acceptable
> to use the 6.2 macros in the context of a firmware implementation that
> complies with 6.3. Or is there another reason you want to update the
> MADT to 6.3?

BTW, this patch sets the size of the GICC entry to 'sizeof
(EFI_ACPI_6_0_GIC_STRUCTURE)' so it is likely that the parser will
choke on it.