public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: "Gao, Liming" <liming.gao@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"lersek@redhat.com" <lersek@redhat.com>,
	 "Shi, Steven" <steven.shi@intel.com>,
	"Zhu, Yonghong" <yonghong.zhu@intel.com>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	 "leif.lindholm@linaro.org" <leif.lindholm@linaro.org>
Subject: Re: [PATCH v4 0/7] BaseTools: add support for GCC5 in LTO mode
Date: Sun, 31 Jul 2016 21:04:04 +0200	[thread overview]
Message-ID: <CAKv+Gu9s4WJbM72OhFCHtqQnmHr91_nuo4fc7PSrXR6m83aXLw@mail.gmail.com> (raw)
In-Reply-To: <CAKv+Gu8nXwr0o3ZtMigiDVdg9BRFGVDnfj27Grj3gw8Hjusz-g@mail.gmail.com>

On 30 July 2016 at 16:34, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> On 29 July 2016 at 17:18, Gao, Liming <liming.gao@intel.com> wrote:
>> Ard:
>>
>>   My gcc version 5.3.0 20151204 (Ubuntu 5.3.0-3ubuntu1~14.04). I will try
>> GCC54.
>>
>
> I cannot reproduce this with  5.3.1-14ubuntu2.1 either.

@Liming: is the issue still reproducible with this change?

"""
diff --git a/MdePkg/Include/X64/ProcessorBind.h
b/MdePkg/Include/X64/ProcessorBind.h
index a4aad3e..73cf799 100644
--- a/MdePkg/Include/X64/ProcessorBind.h
+++ b/MdePkg/Include/X64/ProcessorBind.h
@@ -34,7 +34,7 @@
 // symbols directly using relative references rather than via the GOT, which
 // contains absolute symbol addresses that are subject to runtime relocation.
 //
-#pragma GCC visibility push (protected)
+#pragma GCC visibility push (hidden)
 #endif

 #if defined(__INTEL_COMPILER)
"""

Thanks,
Ard.


  reply	other threads:[~2016-07-31 19:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1469618017-6534-1-git-send-email-ard.biesheuvel@linaro.org>
2016-07-29  4:47 ` [PATCH v4 0/7] BaseTools: add support for GCC5 in LTO mode Gao, Liming
2016-07-29  6:09   ` Ard Biesheuvel
2016-07-29  6:40     ` Ard Biesheuvel
2016-07-29 15:18       ` Gao, Liming
2016-07-29 18:21         ` Ard Biesheuvel
2016-07-30 14:34         ` Ard Biesheuvel
2016-07-31 19:04           ` Ard Biesheuvel [this message]
2016-08-01  2:26             ` Gao, Liming
2016-08-01  6:03               ` Ard Biesheuvel
2016-07-29 20:33     ` Jordan Justen
2016-07-30  9:22       ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu9s4WJbM72OhFCHtqQnmHr91_nuo4fc7PSrXR6m83aXLw@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox