[PATCH edk2-platforms] Silicon/AMD: drop unused/orphaned Styx ResetSystemLib

[PATCH edk2-platforms] Silicon/AMD: drop unused/orphaned Styx ResetSystemLib

[Leif Lindholm]

All Styx platforms in the tree (and the world) use
ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
these days, but somehow this orphaned .inf was left around - drop it.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
 Silicon/AMD/Styx/Library/ResetSystemLib/ResetSystemLib.inf | 44 ----------------
 1 file changed, 44 deletions(-)

diff --git a/Silicon/AMD/Styx/Library/ResetSystemLib/ResetSystemLib.inf b/Silicon/AMD/Styx/Library/ResetSystemLib/ResetSystemLib.inf
deleted file mode 100644
index d9faf3abb0..0000000000
--- a/Silicon/AMD/Styx/Library/ResetSystemLib/ResetSystemLib.inf
+++ /dev/null
@@ -1,44 +0,0 @@
-#/** @file
-# Reset System lib using PSCI hypervisor or secure monitor calls
-#
-# Copyright (c) 2008, Apple Inc. All rights reserved.<BR>
-# Copyright (c) 2014, Linaro Ltd. All rights reserved.<BR>
-# Copyright (c) 2014, ARM Ltd. All rights reserved.<BR>
-# Copyright (c) 2014 - 2016, AMD Inc. All rights reserved.<BR>
-#
-#  This program and the accompanying materials
-#  are licensed and made available under the terms and conditions of the BSD License
-#  which accompanies this distribution. The full text of the license may be found at
-#  http://opensource.org/licenses/bsd-license.php
-#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
-#
-#**/
-#/**
-#  Derived from:
-#   ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.inf
-#
-#**/
-
-[Defines]
-  INF_VERSION                    = 0x00010005
-  BASE_NAME                      = AmdStyxResetSystemLib
-  FILE_GUID                      = 624f6cc6-c38f-4897-b3b7-8a601701291b
-  MODULE_TYPE                    = BASE
-  VERSION_STRING                 = 1.0
-  LIBRARY_CLASS                  = EfiResetSystemLib
-
-[Sources.common]
-  ResetSystemLib.c
-
-[Packages]
-  ArmPkg/ArmPkg.dec
-  MdePkg/MdePkg.dec
-  EmbeddedPkg/EmbeddedPkg.dec
-  Silicon/AMD/Styx/AmdModulePkg/AmdModulePkg.dec
-  Silicon/AMD/Styx/AmdStyx.dec
-
-[LibraryClasses]
-  PcdLib
-  BaseLib
-  ArmSmcLib
-- 
2.11.0

Re: [PATCH edk2-platforms] Silicon/AMD: drop unused/orphaned Styx ResetSystemLib

[Ard Biesheuvel]

On Mon, 15 Apr 2019 at 03:15, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> All Styx platforms in the tree (and the world) use
> ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
> these days, but somehow this orphaned .inf was left around - drop it.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  Silicon/AMD/Styx/Library/ResetSystemLib/ResetSystemLib.inf | 44 ----------------
>  1 file changed, 44 deletions(-)
>
> diff --git a/Silicon/AMD/Styx/Library/ResetSystemLib/ResetSystemLib.inf b/Silicon/AMD/Styx/Library/ResetSystemLib/ResetSystemLib.inf
> deleted file mode 100644
> index d9faf3abb0..0000000000
> --- a/Silicon/AMD/Styx/Library/ResetSystemLib/ResetSystemLib.inf
> +++ /dev/null
> @@ -1,44 +0,0 @@
> -#/** @file
> -# Reset System lib using PSCI hypervisor or secure monitor calls
> -#
> -# Copyright (c) 2008, Apple Inc. All rights reserved.<BR>
> -# Copyright (c) 2014, Linaro Ltd. All rights reserved.<BR>
> -# Copyright (c) 2014, ARM Ltd. All rights reserved.<BR>
> -# Copyright (c) 2014 - 2016, AMD Inc. All rights reserved.<BR>
> -#
> -#  This program and the accompanying materials
> -#  are licensed and made available under the terms and conditions of the BSD License
> -#  which accompanies this distribution. The full text of the license may be found at
> -#  http://opensource.org/licenses/bsd-license.php
> -#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> -#
> -#**/
> -#/**
> -#  Derived from:
> -#   ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.inf
> -#
> -#**/
> -
> -[Defines]
> -  INF_VERSION                    = 0x00010005
> -  BASE_NAME                      = AmdStyxResetSystemLib
> -  FILE_GUID                      = 624f6cc6-c38f-4897-b3b7-8a601701291b
> -  MODULE_TYPE                    = BASE
> -  VERSION_STRING                 = 1.0
> -  LIBRARY_CLASS                  = EfiResetSystemLib
> -
> -[Sources.common]
> -  ResetSystemLib.c
> -
> -[Packages]
> -  ArmPkg/ArmPkg.dec
> -  MdePkg/MdePkg.dec
> -  EmbeddedPkg/EmbeddedPkg.dec
> -  Silicon/AMD/Styx/AmdModulePkg/AmdModulePkg.dec
> -  Silicon/AMD/Styx/AmdStyx.dec
> -
> -[LibraryClasses]
> -  PcdLib
> -  BaseLib
> -  ArmSmcLib
> --
> 2.11.0
>

Re: [PATCH edk2-platforms] Silicon/AMD: drop unused/orphaned Styx ResetSystemLib

[Leif Lindholm]

On Mon, Apr 15, 2019 at 12:00:38PM -0700, Ard Biesheuvel wrote:
> On Mon, 15 Apr 2019 at 03:15, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> >
> > All Styx platforms in the tree (and the world) use
> > ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
> > these days, but somehow this orphaned .inf was left around - drop it.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thanks. Pushed as a8cf8edf74.

/
    Leif

> > ---
> >  Silicon/AMD/Styx/Library/ResetSystemLib/ResetSystemLib.inf | 44 ----------------
> >  1 file changed, 44 deletions(-)
> >
> > diff --git a/Silicon/AMD/Styx/Library/ResetSystemLib/ResetSystemLib.inf b/Silicon/AMD/Styx/Library/ResetSystemLib/ResetSystemLib.inf
> > deleted file mode 100644
> > index d9faf3abb0..0000000000
> > --- a/Silicon/AMD/Styx/Library/ResetSystemLib/ResetSystemLib.inf
> > +++ /dev/null
> > @@ -1,44 +0,0 @@
> > -#/** @file
> > -# Reset System lib using PSCI hypervisor or secure monitor calls
> > -#
> > -# Copyright (c) 2008, Apple Inc. All rights reserved.<BR>
> > -# Copyright (c) 2014, Linaro Ltd. All rights reserved.<BR>
> > -# Copyright (c) 2014, ARM Ltd. All rights reserved.<BR>
> > -# Copyright (c) 2014 - 2016, AMD Inc. All rights reserved.<BR>
> > -#
> > -#  This program and the accompanying materials
> > -#  are licensed and made available under the terms and conditions of the BSD License
> > -#  which accompanies this distribution. The full text of the license may be found at
> > -#  http://opensource.org/licenses/bsd-license.php
> > -#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> > -#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> > -#
> > -#**/
> > -#/**
> > -#  Derived from:
> > -#   ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.inf
> > -#
> > -#**/
> > -
> > -[Defines]
> > -  INF_VERSION                    = 0x00010005
> > -  BASE_NAME                      = AmdStyxResetSystemLib
> > -  FILE_GUID                      = 624f6cc6-c38f-4897-b3b7-8a601701291b
> > -  MODULE_TYPE                    = BASE
> > -  VERSION_STRING                 = 1.0
> > -  LIBRARY_CLASS                  = EfiResetSystemLib
> > -
> > -[Sources.common]
> > -  ResetSystemLib.c
> > -
> > -[Packages]
> > -  ArmPkg/ArmPkg.dec
> > -  MdePkg/MdePkg.dec
> > -  EmbeddedPkg/EmbeddedPkg.dec
> > -  Silicon/AMD/Styx/AmdModulePkg/AmdModulePkg.dec
> > -  Silicon/AMD/Styx/AmdStyx.dec
> > -
> > -[LibraryClasses]
> > -  PcdLib
> > -  BaseLib
> > -  ArmSmcLib
> > --
> > 2.11.0
> >