From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=XBIY0Zc+;
 spf=pass (domain: linaro.org, ip: 209.85.166.195, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-it1-f195.google.com (mail-it1-f195.google.com [209.85.166.195])
 by groups.io with SMTP; Mon, 15 Apr 2019 12:00:51 -0700
Received: by mail-it1-f195.google.com with SMTP id y10so28508437itc.1
        for <devel@edk2.groups.io>; Mon, 15 Apr 2019 12:00:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=JyWSn4C3Zvo+wiqXuMdK/1/dXnKkacmn0MHFafNIhOQ=;
        b=XBIY0Zc+22n4sxt8owUpR5QKKPAXp6pFDVNoV0XWwaPI74T5TOetPOr1T7RNYMjY3r
         Mkn7JQRAqtVPpxSg2Mmb1eDBm2kdlfI/lmC99i1biremTDFnNpspKdIKhq5hVIpDxryU
         lTyHN4BWFDmYjkDrsnPZOlOFkPNObq73N2t93cClGpELnXoRRdVjgvR2gbnCGoFNdA+r
         2SFBXYLpqQsqYxFPiSclTxkXVPmT6KVT2ttPHMyXSVodSlJMreX13fwUe0Kkf9zatp1X
         f4NJx3fuCWZUNHo2Hr4/azNK80larcBLsreffroUxP8qYnNuR9C5lplFZKMrzmMLK1SN
         sJtw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=JyWSn4C3Zvo+wiqXuMdK/1/dXnKkacmn0MHFafNIhOQ=;
        b=aXlIbFyVccs0Gmy90v/48IbS4Ybht2hG8SVKH8P9iJx49QNTvFGl+8i3F8DGzLk7B/
         NvVKtf+BfP2Q93fzlXWzWeTxJzeowAUG98e5StqkPcIIL/m8JxJZabAncT+hGnYj+Tsj
         qR6Zg1OqUvecLY4reicNFoiifiCsMH23DgLI+CbX4SSszCDCUwht5OULblUPQO5IWkU6
         hYVn/EpluRxBKuhZzdeC+AC1Jzgx5fRbNZ/9aUF6U0UVf+/0/VATylj9/zlzNnRvv8K7
         D2O9TP4lK/dRw0YQI5bGTb5KOjNWrux/bVJ3tMZiwYXbzqX0Z0mF00JWnNkOfuQQaJYF
         p+Ew==
X-Gm-Message-State: APjAAAVbmjvN9UY4SC/w+FWVx717ify0Mcds5kY9q/d97mS5wwfCqZnN
	dfNlP/jQrKWYbn982yfVJMX4QlEn+c7sgBEPm1pArg==
X-Google-Smtp-Source: APXvYqx8s1kaNF1r2/9Qcj8Tmy/mZfVBK6DD2M4P449zA+XZJr0jgMm/54jroTxjRlbMKrRE7wj1bce96gzzdxVUJhQ=
X-Received: by 2002:a02:658b:: with SMTP id u133mr46225811jab.17.1555354850236;
 Mon, 15 Apr 2019 12:00:50 -0700 (PDT)
MIME-Version: 1.0
References: <20190415101511.5279-1-leif.lindholm@linaro.org>
In-Reply-To: <20190415101511.5279-1-leif.lindholm@linaro.org>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Mon, 15 Apr 2019 12:00:38 -0700
Message-ID: <CAKv+Gu9sd5M_2EJ9i_MPFXOgqzPfL2+3gjDUzdkdyJ4xAEtQzQ@mail.gmail.com>
Subject: Re: [PATCH edk2-platforms] Silicon/AMD: drop unused/orphaned Styx ResetSystemLib
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>
Content-Type: text/plain; charset="UTF-8"

On Mon, 15 Apr 2019 at 03:15, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> All Styx platforms in the tree (and the world) use
> ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
> these days, but somehow this orphaned .inf was left around - drop it.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  Silicon/AMD/Styx/Library/ResetSystemLib/ResetSystemLib.inf | 44 ----------------
>  1 file changed, 44 deletions(-)
>
> diff --git a/Silicon/AMD/Styx/Library/ResetSystemLib/ResetSystemLib.inf b/Silicon/AMD/Styx/Library/ResetSystemLib/ResetSystemLib.inf
> deleted file mode 100644
> index d9faf3abb0..0000000000
> --- a/Silicon/AMD/Styx/Library/ResetSystemLib/ResetSystemLib.inf
> +++ /dev/null
> @@ -1,44 +0,0 @@
> -#/** @file
> -# Reset System lib using PSCI hypervisor or secure monitor calls
> -#
> -# Copyright (c) 2008, Apple Inc. All rights reserved.<BR>
> -# Copyright (c) 2014, Linaro Ltd. All rights reserved.<BR>
> -# Copyright (c) 2014, ARM Ltd. All rights reserved.<BR>
> -# Copyright (c) 2014 - 2016, AMD Inc. All rights reserved.<BR>
> -#
> -#  This program and the accompanying materials
> -#  are licensed and made available under the terms and conditions of the BSD License
> -#  which accompanies this distribution. The full text of the license may be found at
> -#  http://opensource.org/licenses/bsd-license.php
> -#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> -#
> -#**/
> -#/**
> -#  Derived from:
> -#   ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.inf
> -#
> -#**/
> -
> -[Defines]
> -  INF_VERSION                    = 0x00010005
> -  BASE_NAME                      = AmdStyxResetSystemLib
> -  FILE_GUID                      = 624f6cc6-c38f-4897-b3b7-8a601701291b
> -  MODULE_TYPE                    = BASE
> -  VERSION_STRING                 = 1.0
> -  LIBRARY_CLASS                  = EfiResetSystemLib
> -
> -[Sources.common]
> -  ResetSystemLib.c
> -
> -[Packages]
> -  ArmPkg/ArmPkg.dec
> -  MdePkg/MdePkg.dec
> -  EmbeddedPkg/EmbeddedPkg.dec
> -  Silicon/AMD/Styx/AmdModulePkg/AmdModulePkg.dec
> -  Silicon/AMD/Styx/AmdStyx.dec
> -
> -[LibraryClasses]
> -  PcdLib
> -  BaseLib
> -  ArmSmcLib
> --
> 2.11.0
>