From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x231.google.com (mail-io0-x231.google.com [IPv6:2607:f8b0:4001:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 119F821A04830 for ; Wed, 5 Apr 2017 09:01:27 -0700 (PDT) Received: by mail-io0-x231.google.com with SMTP id f84so12724475ioj.0 for ; Wed, 05 Apr 2017 09:01:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=M/qakFAVlER+1Eu9whqsqMZ21jF9tU/3BeXHrGreab8=; b=KKDYAGAKnUz8P9T7/fEs16Z/y0glD8CJI0HZP1T12t4iDJEDLakwHi4f6tq4F3GaQR bh3/cIiueL92ws1INJLSLfGvzpABtfUSsmf1M821lAhL5Uiu+flakqnG4TNxRU3J72j5 2eoP6cDBeQ1D7vSTwyZyO88PjoN07rrDFMLlg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=M/qakFAVlER+1Eu9whqsqMZ21jF9tU/3BeXHrGreab8=; b=VkmIrrfRBvhtfKXv8iQGI0MG0biN87GGAua/sf/dDWX5YthjtybxqooENhu6X6ui7T AzaPTACVzMZTMpcJjYEouNyCap5VyMXqeMzUDgZRaU2dDb4bMn87C0ApzPp4diLG6Vln 0VaBht99pkLnMoRbw5EoIpZeG4HdabpgQ/cADDc/BhHrF9KTsKAwdj+bT3FK+pZE1NFx G3Ucckmf9eKUbMW9nxbfB1AOeSD8PNag7W1hJLg7wPYs59larQIzdsRATThsAggXckN0 yw76PPF2qzSIrO34KJd86rO0GUhDTUe87/JORNb19nOOPYvKC5WltqNsYQfmQH1chyrp o9Jw== X-Gm-Message-State: AFeK/H38HUCPxMh0HCJel1a4i2DR8KC67lr7A6wuU9PVIhxFv1bdHU9B0J1w0oqh96dUjRHEjBf/W9qbwBUiCS7V X-Received: by 10.107.132.155 with SMTP id o27mr27087544ioi.138.1491408086154; Wed, 05 Apr 2017 09:01:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.10.27 with HTTP; Wed, 5 Apr 2017 09:01:25 -0700 (PDT) In-Reply-To: <20170405153802.GQ25239@bivouac.eciton.net> References: <20170405093806.6779-1-ard.biesheuvel@linaro.org> <20170405153802.GQ25239@bivouac.eciton.net> From: Ard Biesheuvel Date: Wed, 5 Apr 2017 17:01:25 +0100 Message-ID: To: Leif Lindholm Cc: Laszlo Ersek , "edk2-devel@lists.01.org" , "Zeng, Star" Subject: Re: [PATCH] MdeModulePkg: move PlatformHasAcpiGuid from EmbeddedPkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2017 16:01:27 -0000 Content-Type: text/plain; charset=UTF-8 On 5 April 2017 at 16:38, Leif Lindholm wrote: > On Wed, Apr 05, 2017 at 11:01:05AM +0100, Ard Biesheuvel wrote: >> On 5 April 2017 at 10:49, Laszlo Ersek wrote: >> > On 04/05/17 11:38, Ard Biesheuvel wrote: >> >> Given the agreement on the edk2-devel regarding the fact that the >> >> notion whether or not a 'platform has ACPI' is a universal one, move >> >> the PlatformHasAcpi GUID to MdeModulePkg. >> >> >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> >> Signed-off-by: Ard Biesheuvel >> >> Reviewed-by: "Zeng, Star" >> >> --- >> >> ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf | 1 + >> >> ArmVirtPkg/XenPlatformHasAcpiDtDxe/XenPlatformHasAcpiDtDxe.inf | 1 + >> >> EmbeddedPkg/EmbeddedPkg.dec | 3 --- >> >> EmbeddedPkg/Library/PlatformHasAcpiLib/PlatformHasAcpiLib.inf | 1 + >> >> {EmbeddedPkg => MdeModulePkg}/Include/Guid/PlatformHasAcpi.h | 0 >> >> MdeModulePkg/MdeModulePkg.dec | 3 +++ >> >> 6 files changed, 6 insertions(+), 3 deletions(-) >> >> >> >> diff --git a/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf b/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf >> >> index 08025f0c3722..5351e741aa41 100644 >> >> --- a/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf >> >> +++ b/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf >> >> @@ -27,6 +27,7 @@ [Sources] >> >> [Packages] >> >> ArmVirtPkg/ArmVirtPkg.dec >> >> EmbeddedPkg/EmbeddedPkg.dec >> >> + MdeModulePkg/MdeModulePkg.dec >> >> MdePkg/MdePkg.dec >> >> OvmfPkg/OvmfPkg.dec >> >> >> >> diff --git a/ArmVirtPkg/XenPlatformHasAcpiDtDxe/XenPlatformHasAcpiDtDxe.inf b/ArmVirtPkg/XenPlatformHasAcpiDtDxe/XenPlatformHasAcpiDtDxe.inf >> >> index 2833075f65c9..26965c50c12b 100644 >> >> --- a/ArmVirtPkg/XenPlatformHasAcpiDtDxe/XenPlatformHasAcpiDtDxe.inf >> >> +++ b/ArmVirtPkg/XenPlatformHasAcpiDtDxe/XenPlatformHasAcpiDtDxe.inf >> >> @@ -26,6 +26,7 @@ [Sources] >> >> >> >> [Packages] >> >> EmbeddedPkg/EmbeddedPkg.dec >> >> + MdeModulePkg/MdeModulePkg.dec >> >> MdePkg/MdePkg.dec >> >> >> >> [LibraryClasses] >> >> diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/EmbeddedPkg/EmbeddedPkg.dec >> >> index 0bed2736c8c3..a7e127085236 100644 >> >> --- a/EmbeddedPkg/EmbeddedPkg.dec >> >> +++ b/EmbeddedPkg/EmbeddedPkg.dec >> >> @@ -57,9 +57,6 @@ [Guids.common] >> >> gFdtHobGuid = { 0x16958446, 0x19B7, 0x480B, { 0xB0, 0x47, 0x74, 0x85, 0xAD, 0x3F, 0x71, 0x6D } } >> >> gFdtVariableGuid = { 0x25a4fd4a, 0x9703, 0x4ba9, { 0xa1, 0x90, 0xb7, 0xc8, 0x4e, 0xfb, 0x3e, 0x57 } } >> >> >> >> - ## Include/Guid/PlatformHasAcpi.h >> >> - gEdkiiPlatformHasAcpiGuid = { 0xf0966b41, 0xc23f, 0x41b9, { 0x96, 0x04, 0x0f, 0xf7, 0xe1, 0x11, 0x96, 0x5a } } >> >> - >> >> ## Include/Guid/PlatformHasDeviceTree.h >> >> gEdkiiPlatformHasDeviceTreeGuid = { 0x7ebb920d, 0x1aaf, 0x46d9, { 0xb2, 0xaf, 0x54, 0x1e, 0x1d, 0xce, 0x14, 0x8b } } >> >> >> >> diff --git a/EmbeddedPkg/Library/PlatformHasAcpiLib/PlatformHasAcpiLib.inf b/EmbeddedPkg/Library/PlatformHasAcpiLib/PlatformHasAcpiLib.inf >> >> index 6268293ca97b..be298ba67c40 100644 >> >> --- a/EmbeddedPkg/Library/PlatformHasAcpiLib/PlatformHasAcpiLib.inf >> >> +++ b/EmbeddedPkg/Library/PlatformHasAcpiLib/PlatformHasAcpiLib.inf >> >> @@ -34,6 +34,7 @@ [Sources] >> >> >> >> [Packages] >> >> EmbeddedPkg/EmbeddedPkg.dec >> > >> > I think you can remove "EmbeddedPkg/EmbeddedPkg.dec" here. >> > >> >> Ah yes. It didn't occur to me to remove the 'home' package here, but I >> suppose this library doesn't depend on anything it provides. >> >> > ( >> > >> > I checked all the other INF files being modified as well; it seems that >> > "EmbeddedPkg/EmbeddedPkg.dec" remains necessary in all other places. >> > >> > I also grepped all INF files for the GUID -- DtPlatformDxe.inf is >> > another user, but it needs no modification. >> > >> > ) >> > >> > With that update (if it indeed works), >> > >> > Reviewed-by: Laszlo Ersek > > Seconded. > (Reviewed-by: Leif Lindholm ) > Thanks. Pushed as a391e5925dc3 (with the suggestion incorporated)