From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"ming.huang@linaro.org" <ming.huang@linaro.org>,
"Wu, Hao A" <hao.a.wu@intel.com>,
"Wang, Jian J" <jian.j.wang@intel.com>
Subject: Re: [edk2-devel] [PATCH resend] MdeModulePkg/EsrtDxe: allocate ESRT table from RtServicesData memory
Date: Sat, 20 Apr 2019 12:25:00 +0200 [thread overview]
Message-ID: <CAKv+Gu9t5WkP9MiymdegkEpjmeCCwo5N6WvFRMpU5vtSVTppxw@mail.gmail.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9C9B72F@ORSMSX113.amr.corp.intel.com>
On Fri, 19 Apr 2019 at 22:04, Kinney, Michael D
<michael.d.kinney@intel.com> wrote:
>
> Ard,
>
> Saw your patch to cache the GUID table. The ESRT Table
> is not that much bigger, so the algorithm may be simpler
> if you just make a copy of the ESRT table with the
> active entries.
>
> * 16+24 bytes per ESRT entry.
> * 16 bytes/entry for just the GUID.
>
> The only advantage of checking against the ESRT GUID at
> RT is to reject capsules that will be rejected when the
> capsule is processed later. This can prevent extra reboots
> if an OS agent is sending capsules that do not really
> apply to the current system. I expect OS agent to only
> send capsules that are in the ESRT.
>
Yeah. The only problem is that some capsules have no header at all,
and so without a GUID check, we might end up interpreting random data
as the capsule's HeaderSize field, which would be bad.
In general, I think we should be robust against random junk being
passed into the QueryCapsuleCapabilities() runtime service.
prev parent reply other threads:[~2019-04-20 10:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 14:13 [PATCH resend] MdeModulePkg/EsrtDxe: allocate ESRT table from RtServicesData memory Ard Biesheuvel
2019-04-19 17:36 ` [edk2-devel] " Michael D Kinney
2019-04-19 17:42 ` Ard Biesheuvel
2019-04-19 17:53 ` Ard Biesheuvel
2019-04-19 18:08 ` Michael D Kinney
2019-04-19 18:11 ` Ard Biesheuvel
2019-04-19 18:23 ` Michael D Kinney
2019-04-19 18:38 ` Ard Biesheuvel
2019-04-19 18:43 ` Ard Biesheuvel
2019-04-19 19:46 ` Michael D Kinney
2019-04-19 20:04 ` Michael D Kinney
2019-04-20 10:25 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu9t5WkP9MiymdegkEpjmeCCwo5N6WvFRMpU5vtSVTppxw@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox