From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x230.google.com (mail-it0-x230.google.com [IPv6:2607:f8b0:4001:c0b::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 231C88042A for ; Thu, 23 Mar 2017 02:09:24 -0700 (PDT) Received: by mail-it0-x230.google.com with SMTP id y18so36544812itc.0 for ; Thu, 23 Mar 2017 02:09:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=nxnLFEpuGX4y2fynNPf6ge430Hd+ISF/6r9Sf56rDL8=; b=WCKl5en0HwzLnl30hxSRxyl0+gE5iqtjugYpbDNSEMe7oF6ACN7Ef3CKIXvO4DdqmK hgdEWLTPIqc0XWirr4k1BX4+kfhWGJqA7WhHGhi2GRvIlUhttO/JkiS4ZF/ObduLhm2l tgZ10d8Rc7Kx9L3BjKHo7g2mRz8xG9Kvp0+48= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=nxnLFEpuGX4y2fynNPf6ge430Hd+ISF/6r9Sf56rDL8=; b=qO/Q7+x+G5lgmE6lvtumeEdev4ae/c/45wq6ALW2O6ofDqLYrbM8kp8KEWntSs5cuI zUvurgk7Wru5RcBDTkwpV5SV18yQwlhg5UhOkclfO9rhsH5osSX0pYqh81g3Aqj9LoNp mJOih75BW2YqIwcLElyKPE7jOFxVglcodRoQeIPWkmU5i9Z+Qy5z5CdwhTXWvZqPzX7g h5bz/L2oxNeswHEVdQnrZ+bdqxBu0H9jE7RLQel8GxeaQM40Wbr+OHsmZWcVK6G1Gfsg EGTK6M8e6X3h9gohEOUsPbn5FQ8Wm+5Viqw+Cc7foT3Orj2ypWcfCGIwwX9Nr4zjm3TJ 5iaA== X-Gm-Message-State: AFeK/H3WHldIPgCGsQSWIOgNWz+14Dc0Tyb4HGt7ygmBosIl8X0oINe19+tOd1N+RNJm74lQJ9r3auGMnSBYsmbj X-Received: by 10.36.207.212 with SMTP id y203mr1486753itf.63.1490260163484; Thu, 23 Mar 2017 02:09:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.10.27 with HTTP; Thu, 23 Mar 2017 02:09:22 -0700 (PDT) In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103B8377AB@shsmsx102.ccr.corp.intel.com> References: <20170317204731.31488-1-lersek@redhat.com> <20170317204731.31488-6-lersek@redhat.com> <20170318150041.GL16034@bivouac.eciton.net> <1bc7b29c-7a71-86cb-adce-5a14de129c63@redhat.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B8377AB@shsmsx102.ccr.corp.intel.com> From: Ard Biesheuvel Date: Thu, 23 Mar 2017 09:09:22 +0000 Message-ID: To: "Zeng, Star" , "Kinney, Michael D" , "afish@apple.com" Cc: Laszlo Ersek , Leif Lindholm , "Tian, Feng" , edk2-devel-01 Subject: Re: [PATCH v2 05/12] ArmPkg: introduce EDKII Platform Has ACPI Protocol, and plug-in library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2017 09:09:24 -0000 Content-Type: text/plain; charset=UTF-8 On 23 March 2017 at 01:41, Zeng, Star wrote: > I prefer to do not include the protocol definition and the library instance into MdeModulePkg at this moment until they need to be used by multiple platforms/archs. > I disagree. Nowhere in the PI or UEFI spec is there any mention (for any architecture) that ACPI is mandatory. Given that EDK2 is the reference platform UEFI/PI, and not for ACPI or the PC/x86 platform, I think it is unreasonable to have lots and lots of PC quirks (i.e., allocations below 4 GB) in MdeModulePkg, but then disallow a clean approach to make ACPI selectable, in a way that is true to the spirit of PI (i.e., using protocol dependencies) So I think at least the protocol definitions belong in MdeModulePkg. Thanks, Ard.