From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::12b; helo=mail-it1-x12b.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x12b.google.com (mail-it1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 180B62115C325 for ; Sat, 13 Oct 2018 01:46:24 -0700 (PDT) Received: by mail-it1-x12b.google.com with SMTP id c23-v6so22146169itd.5 for ; Sat, 13 Oct 2018 01:46:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=dWiYoH5r3uLTc0CaVnYgKEtt2+faDqyabQyq/zPrqXk=; b=YFsDaxraQIb89Uh3IdQqqKGQP0KqnY6/L9MdLaeNsInHz1D6+zrHnacdYYZINOeVnJ e5fwR2mQJ2IyaRFYnha2th/aZCpSaXHwnBVjucJeW8O16jziWJc3LyM5qm9RjAYdxTKE /bIFWqnDskBzP4wIheW7lwcv9E8FTtsCCb1oo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=dWiYoH5r3uLTc0CaVnYgKEtt2+faDqyabQyq/zPrqXk=; b=szRZBLrRlmbK2DPHxt0WkpZ2MORFC9CCBS/LQ3eNe+H9gKjSTfXcPmFVVtC3dh/yxV WMjeOhrVSrzUgUYyDsWKHNo7HNVNn6x+6MQvd82yxW7qlCkYvpH2oizEEHk87MBoJPoT l2lKzcbXio3qIND6uW4jAHUmKUXaRa4e53aCRxI53Ukv/fdZjbGmHpWPnt5m5VeNtSQ6 8HtddZzE0P6ehxSe00MEyBgHFofrBdWNBnDkt8BwR+YK0Bl01X1o+t9JI58kt99F1G0T YW4YE6Mh2VbjrnkhnwLqiMPliiPg9MYGjw7GUkD9MC6d6y/J3YnOiB25FqJ2j9vMohJd f9Ag== X-Gm-Message-State: ABuFfojH4hQ+iu77QOELTMceDXVB2DKJ4oO2gYnvLCIGGYIkCkbIBlDj mcqC2uYKTPpuD0CZ8dYQVz7hR0hCcpsZB41NPTzCrQ== X-Google-Smtp-Source: ACcGV606sHDzx7wvpO2B35Jizl5OF+laSOypBRWu3982fT59Mih64ls/lzJwmt6PtpOAxS+r+gODFaYCd5j91X2qkdc= X-Received: by 2002:a24:e08f:: with SMTP id c137-v6mr7492763ith.71.1539420384094; Sat, 13 Oct 2018 01:46:24 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:5910:0:0:0:0:0 with HTTP; Sat, 13 Oct 2018 01:46:23 -0700 (PDT) In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E339880@SHSMSX104.ccr.corp.intel.com> References: <4A89E2EF3DFEDB4C8BFDE51014F606A14E339880@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Sat, 13 Oct 2018 10:46:23 +0200 Message-ID: To: "Gao, Liming" Cc: edk2-devel-01 , Laszlo Ersek , Leif Lindholm , "Kinney, Michael D" , "Zhu, Yonghong" , "stephano.cetola@linux.intel.com" Subject: Re: BaseTools/ build broken due to unreviewed patch - PLEASE FIX X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Oct 2018 08:46:25 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On 13 October 2018 at 10:44, Gao, Liming wrote: > Ard: > I pull the latest edk2 code. I can find RunTests.py in BaseTools/Tests.= The below error message shows RunTests.py is not found. But, this file is = in BaseTools/Tests. I also run Make command in BaseTools directory. It can = work in my Ubuntu machine. I install Python37. Do you install Python36 or P= ython37 in your machine? > > Yonghong has sent the mail to notify BaseTools Python3 migration is don= e. Python3.6 or the above is required. > I have python3 on my machine, yes. But that does not mean it is the default for everyone. >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of A= rd Biesheuvel >> Sent: Saturday, October 13, 2018 4:18 PM >> To: edk2-devel-01 ; Gao, Liming ; Laszlo Ersek ; Leif Lindholm >> ; Kinney, Michael D ; Zhu, Yonghong ; >> stephano.cetola@linux.intel.com >> Subject: [edk2] BaseTools/ build broken due to unreviewed patch - PLEASE= FIX >> >> Commit ea787b6b55499e8f931201f8f49daaaeb2e4409f >> >> "BaseTools: update Test scripts support python3" >> >> [which has never been sent out for review to the mailing list, as far >> as I can tell] is breaking the BaseTools build >> >> make -C Tests >> make[1]: Entering directory '/home/ard/build/edk2/BaseTools/Tests' >> /bin/sh: 1: RunTests.py: not found >> GNUmakefile:17: recipe for target 'test' failed >> make[1]: *** [test] Error 127 >> make[1]: Leaving directory '/home/ard/build/edk2/BaseTools/Tests' >> GNUmakefile:25: recipe for target 'Tests' failed >> make: *** [Tests] Error 2 >> make: Leaving directory '/home/ard/build/edk2/BaseTools' >> >> I tried reverting that patch alone, but that gives me >> >> make -C Tests >> make[1]: Entering directory '/home/ard/build/edk2/BaseTools/Tests' >> Traceback (most recent call last): >> File "RunTests.py", line 36, in >> allTests =3D GetAllTestsSuite() >> File "RunTests.py", line 33, in GetAllTestsSuite >> return unittest.TestSuite([GetCTestSuite(), GetPythonTestSuite()]) >> File "RunTests.py", line 30, in GetPythonTestSuite >> return PythonToolsTests.TheTestSuite() >> File "/home/ard/build/edk2/BaseTools/Tests/PythonToolsTests.py", >> line 27, in TheTestSuite >> import CheckUnicodeSourceFiles >> File "/home/ard/build/edk2/BaseTools/Tests/CheckUnicodeSourceFiles.py"= , >> line 25, in >> from Common.Misc import PathClass >> File "/home/ard/build/edk2/BaseTools/Source/Python/Common/Misc.py", >> line 27, in >> from collections import UserDict as IterableUserDict >> ImportError: cannot import name UserDict >> GNUmakefile:17: recipe for target 'test' failed >> make[1]: *** [test] Error 1 >> make[1]: Leaving directory '/home/ard/build/edk2/BaseTools/Tests' >> GNUmakefile:25: recipe for target 'Tests' failed >> make: *** [Tests] Error 2 >> make: Leaving directory '/home/ard/build/edk2/BaseTools' >> >> Breaking the build for everyone with an unreviewed patch 2 days before >> the plugfest is NOT OK. >> >> Please fix or revert ASAP >> >> (I suppose that the failing test is a false negative in this case, but >> that is not really the point - my CI jobs are broken due to this and >> so are many others, I imagine) >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel