From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Thomas Panakamattam Abraham <thomas.abraham@arm.com>
Cc: vijayenthiran.subramaniam@arm.com,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH] Platform/ARM/Juno: increase max variable size to 8KB
Date: Fri, 23 Nov 2018 18:51:08 +0100 [thread overview]
Message-ID: <CAKv+Gu9u=CJ1CitZnQYLcX+dGUQPBvSBewzYRc5HyN2LDiV0OA@mail.gmail.com> (raw)
In-Reply-To: <CAJuA9ahnE-c01AjrUDuHo4dM0vFT04uVafV35F+SfXqP18Ck8w@mail.gmail.com>
On Wed, 21 Nov 2018 at 17:37, Thomas Abraham <thomas.abraham@arm.com> wrote:
>
> On Wed, Nov 21, 2018 at 9:26 PM Vijayenthiran Subramaniam
> <vijayenthiran.subramaniam@arm.com> wrote:
> >
> > Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with
> > NetworkPkg drivers") switched to using iSCSI driver from the NetworkPkg
> > package. This driver requires the platform to support a maximum variable
> > size of atleast 4KB.
> >
> > So increase the maximum supported variable size to 8KB on the Juno
> > platform. Without this, the iSCSI driver fails to load.
> >
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Thomas Abraham <thomas.abraham@arm.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> > ---
> > Platform/ARM/JunoPkg/ArmJuno.dsc | 2 ++
> > 1 file changed, 2 insertions(+)
>
> Tested-by: Thomas Abraham <thomas.abraham@gmail.com>
>
Pushed as d9e68a756cfb..397bbafdbff3
Thanks all
> >
> > diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc
> > index ac3d63b..ac85dc0 100644
> > --- a/Platform/ARM/JunoPkg/ArmJuno.dsc
> > +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc
> > @@ -103,6 +103,8 @@
> > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|0x0BFE0000
> > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize|0x00010000
> >
> > + gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
> > +
> > # System Memory (2GB - 16MB of Trusted DRAM at the top of the 32bit address space)
> > gArmTokenSpaceGuid.PcdSystemMemoryBase|0x80000000
> >
> > --
> > 2.7.4
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-11-23 17:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 15:47 [PATCH] Platform/ARM/Juno: increase max variable size to 8KB Vijayenthiran Subramaniam
2018-11-21 16:37 ` Thomas Abraham
2018-11-23 17:51 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu9u=CJ1CitZnQYLcX+dGUQPBvSBewzYRc5HyN2LDiV0OA@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox