From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::144; helo=mail-it1-x144.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x144.google.com (mail-it1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E9D5B2118F76A for ; Fri, 23 Nov 2018 09:51:21 -0800 (PST) Received: by mail-it1-x144.google.com with SMTP id z7so1880122iti.0 for ; Fri, 23 Nov 2018 09:51:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5NCqPO7PWKk0ygju8C4rz9z2cMdYfH3po4aCJdG7C0c=; b=JAn+WbWSvQpr6HJ5YzJUwo07LOVKs8ml4wY9/YfC76SOzdM9qu9RX457liAZpvRl1B FRPTfacwbt5HPgVXdiwyPgOUWXFKfvfM0ZywlY9pJI0D1h9p+wDLoMVixDrGBnft7ckF zwYkBPDB7AHLSfDrzRFTJrXeGU2VLpkkJ5Azg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5NCqPO7PWKk0ygju8C4rz9z2cMdYfH3po4aCJdG7C0c=; b=t7FYDf1ih0H5jWkLOiQMe+4dgrIlXQsoqjOi2Yl9zDIQmND13ZKBegkNQhF5kFm8pL sMpowRU1Ai69SFn+W6u0d2/rOt7nKJ3/NodqQ/wEEDQqwZNrToSwVXUUdAY/CJoDK7Te hteeknXs2jwr+zMleyOJKXWH1UV1GXtMrrFfMivQ7y7vZMmZpYHyMZAxkxSl2vlFIphG T13zTTZkrr/UwP3Yd9+7c44DFu4WNJsKoHrnr5NFYh6IaaOmTFko6k/FNqlROTNF6htR VdpJHczQzGcHfqhKq0C6dBQRkLvS8Haz8BqXlI75QOvng1OL8VOGnRjFQP89+MclJo4g 97gQ== X-Gm-Message-State: AGRZ1gK/BmmsdBSc6/iurmPyXDcwt7Wqdqj1qnxikda5/Rlns0e2/4EV vrh5fOwis+kLI4XsFBcPFW7WZ/3cCJMcWmEFJyklTw== X-Google-Smtp-Source: AJdET5f0EuGWJHVUclBQgxk5RVSQT0OXFv3fpScIiHJ3pbHnMomVt3S9ia+abb8A85hAJoO3pHcjwzwPFmIM/sw9fSs= X-Received: by 2002:a05:660c:4b:: with SMTP id p11mr14513380itk.71.1542995480945; Fri, 23 Nov 2018 09:51:20 -0800 (PST) MIME-Version: 1.0 References: <20181121154723.12514-1-vijayenthiran.subramaniam@arm.com> In-Reply-To: From: Ard Biesheuvel Date: Fri, 23 Nov 2018 18:51:08 +0100 Message-ID: To: Thomas Panakamattam Abraham Cc: vijayenthiran.subramaniam@arm.com, "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: [PATCH] Platform/ARM/Juno: increase max variable size to 8KB X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2018 17:51:22 -0000 Content-Type: text/plain; charset="UTF-8" On Wed, 21 Nov 2018 at 17:37, Thomas Abraham wrote: > > On Wed, Nov 21, 2018 at 9:26 PM Vijayenthiran Subramaniam > wrote: > > > > Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with > > NetworkPkg drivers") switched to using iSCSI driver from the NetworkPkg > > package. This driver requires the platform to support a maximum variable > > size of atleast 4KB. > > > > So increase the maximum supported variable size to 8KB on the Juno > > platform. Without this, the iSCSI driver fails to load. > > > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > Cc: Thomas Abraham > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Vijayenthiran Subramaniam > > --- > > Platform/ARM/JunoPkg/ArmJuno.dsc | 2 ++ > > 1 file changed, 2 insertions(+) > > Tested-by: Thomas Abraham > Pushed as d9e68a756cfb..397bbafdbff3 Thanks all > > > > diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc > > index ac3d63b..ac85dc0 100644 > > --- a/Platform/ARM/JunoPkg/ArmJuno.dsc > > +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc > > @@ -103,6 +103,8 @@ > > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|0x0BFE0000 > > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize|0x00010000 > > > > + gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 > > + > > # System Memory (2GB - 16MB of Trusted DRAM at the top of the 32bit address space) > > gArmTokenSpaceGuid.PcdSystemMemoryBase|0x80000000 > > > > -- > > 2.7.4 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel