Re: [PATCH edk2-platforms 00/11] final set of Styx cleanups

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On Wed, 12 Dec 2018 at 23:23, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Tue, Dec 11, 2018 at 07:35:03PM +0100, Ard Biesheuvel wrote:
> > I promise :-)
>
> Yeah, right :)
>
> > This gets rid of the last build config options passed via the command
> > line into the preprocessor, and replaces them with PCD references.
> >
> > Ard Biesheuvel (11):
> >   Silicon/AMD/Styx/Iort: drop conditionally included XGBE nodes
> >   Platform/SoftIron/Overdrive1000Board: remove dead XGBE references
> >   Silicon/AMD/Styx/AcpiPlatformDxe: replace XGBE CPP conditional with
> >     PCD
> >   Silicon/AMD/Styx/PlatInitPei: replace XGBE CPP conditional with PCD
> >   Silicon/AMD/Styx/StyxDtbLoaderLib: replace XGBE CPP conditional with
> >     PCD
> >   Platform/AMD/OverdriveBoard: drop DO_XGBE C preprocessor defines
> >   Silicon/AMD/Styx: introduce boolean PCD for KCS/IPMI support
> >   Silicon/AMD/Styx/AcpiPlatformDxe: move IPMI/KCS device into separate
> >     SSDT
> >   Silicon/AMD/Styx/StyxDtbLoaderLib: replace DO_KCS macro reference with
> >     PCD
> >   Platform/Styx: get rid of DO_KCS preprocessor macro
> >   Silicon/AMD/Styx/AcpiPlatformDxe: disable KCS on pre-B1 silicon
>
> Nice bit of cleanup.
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>


Thanks

Pushed as  572a554e1db4..80dfc2ce18c6