From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d43; helo=mail-io1-xd43.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4E0872119FF57 for ; Thu, 13 Dec 2018 03:09:41 -0800 (PST) Received: by mail-io1-xd43.google.com with SMTP id n3so1230444iog.12 for ; Thu, 13 Dec 2018 03:09:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ct08PbMjTUwha524Fli4UrKiXdmwOZf8jTfCmfiBljU=; b=Xfo5ivu8dnFmcBbzv2Ydp6JkpGM3hSHEmcHeI/fE9FNbgXNw7tjk2SEOLvyNof0zaf Y3UrSsjqgssMglrEDCP4X9HumUad7ADkMmP0fMDxRTA7jRqdc/BwdBLmqYRyOpqbcFwZ cU2j2y9U/K5k2vXR5OC3SaYsfRWkkcGMMsX1Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ct08PbMjTUwha524Fli4UrKiXdmwOZf8jTfCmfiBljU=; b=qeYF4gcBurvRgqKNqEx/Kqc4UeZN4SOZB8C4dyFV5LmQupfJYr3McurPIZwYNfC8+x m4ZP2Kqjz16+QQelmzKk9BUn/MsNM7qlqaGX9JhPkZebGljijzw+RIlEYQ0YfjRJxa6r xPxkN/Zzxe8TUqZ+OPFYJFgcCfZieq161IB8YA9gHictEzvv+w04yVObvVtzNH4+lkP6 08TrtrlYB+fsl20eMmIM3eynpVrPISsbTYSWT6iLB7Cdn/jnQAiZUbTEEaPisbQlbEKA M1Dj1j9IslGNIcn91sCZAlknjrI+UfQXHTGUv53vAv/NbD76yFQDcNqXr+wMR4HtM0gA mu/g== X-Gm-Message-State: AA+aEWY5mW5agTNyUfxBLoA4KKW6nyAGVMfNQvirEBupd5vTV/yHvH5a ET043R+ivDCUx5uSKiSLvxN1ytwboDcKLz4ger21XQ== X-Google-Smtp-Source: AFSGD/WxinUDEJ1KpBUqcKkqAXU7WwAb2ojD0BveJ/Uw94h9YbazJa2EHjMc6MwIVInEVLHSCRUPkCglszzlg0P1/7k= X-Received: by 2002:a5d:8415:: with SMTP id i21mr19788558ion.173.1544699381125; Thu, 13 Dec 2018 03:09:41 -0800 (PST) MIME-Version: 1.0 References: <20181211183514.20948-1-ard.biesheuvel@linaro.org> <20181212222319.qhf27cxz5liuqprq@bivouac.eciton.net> In-Reply-To: <20181212222319.qhf27cxz5liuqprq@bivouac.eciton.net> From: Ard Biesheuvel Date: Thu, 13 Dec 2018 12:09:29 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Alan Ott Subject: Re: [PATCH edk2-platforms 00/11] final set of Styx cleanups X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Dec 2018 11:09:42 -0000 Content-Type: text/plain; charset="UTF-8" On Wed, 12 Dec 2018 at 23:23, Leif Lindholm wrote: > > On Tue, Dec 11, 2018 at 07:35:03PM +0100, Ard Biesheuvel wrote: > > I promise :-) > > Yeah, right :) > > > This gets rid of the last build config options passed via the command > > line into the preprocessor, and replaces them with PCD references. > > > > Ard Biesheuvel (11): > > Silicon/AMD/Styx/Iort: drop conditionally included XGBE nodes > > Platform/SoftIron/Overdrive1000Board: remove dead XGBE references > > Silicon/AMD/Styx/AcpiPlatformDxe: replace XGBE CPP conditional with > > PCD > > Silicon/AMD/Styx/PlatInitPei: replace XGBE CPP conditional with PCD > > Silicon/AMD/Styx/StyxDtbLoaderLib: replace XGBE CPP conditional with > > PCD > > Platform/AMD/OverdriveBoard: drop DO_XGBE C preprocessor defines > > Silicon/AMD/Styx: introduce boolean PCD for KCS/IPMI support > > Silicon/AMD/Styx/AcpiPlatformDxe: move IPMI/KCS device into separate > > SSDT > > Silicon/AMD/Styx/StyxDtbLoaderLib: replace DO_KCS macro reference with > > PCD > > Platform/Styx: get rid of DO_KCS preprocessor macro > > Silicon/AMD/Styx/AcpiPlatformDxe: disable KCS on pre-B1 silicon > > Nice bit of cleanup. > Reviewed-by: Leif Lindholm > Thanks Pushed as 572a554e1db4..80dfc2ce18c6