public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Leif Lindholm" <leif.lindholm@linaro.org>,
	"Laszlo Ersek" <lersek@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Hongbo Zhang" <hongbo.zhang@linaro.org>,
	"Nariman Poushin" <nariman.poushin@linaro.org>,
	"Thomas Panakamattam Abraham" <thomas.abraham@arm.com>
Subject: Re: [PATCH v2 0/5] ArmPlatformPkg, ArmVirtPkg: discover NOR flash banks from DTB
Date: Mon, 26 Nov 2018 18:00:34 +0100	[thread overview]
Message-ID: <CAKv+Gu9v_QvBE6XW9+PjAkJCvnRnMOivc4+81nM9i34oTGfumg@mail.gmail.com> (raw)
In-Reply-To: <20181121115828.3026-1-ard.biesheuvel@linaro.org>

On Wed, 21 Nov 2018 at 12:58, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> This series fixes an issue reported by Hongbo and Philippe, where
> ArmVirtQemuKernel will crash on an attempt to access flash bank #0,
> which is secure-only when running QEMU with support for EL3.
>
> So let's switch to discovering the NOR flash banks from the device tree
> instead. This requires some preparatory changes in the NOR flash driver
> to avoid having to invent GUIDs on the fly.
>
> Changes since v1:
> - split ArmPlatformPkg for clarity
> - move DT node status check into FdtClientDxe where it belongs
> - use correct UINT32* type for DT property values, and be pedantic about
>   their potential misalignment when casting to UINT64*
> - add patch to remove the 'Guid' member from NOR_FLASH_DESCRIPTION
> - add some acks
>
> Ard Biesheuvel (5):
>   ArmPlatformPkg/NorFlashDxe: prepare for devicepath format change
>   ArmPlatformPkg/NorFlashDxe: use one GUID plus index to identify flash
>     banks
>   ArmVirtPkg/FdtClientDxe: take DT node 'status' properties into account
>   ArmVirtPkg/NorFlashQemuLib: discover NOR flash banks dynamically
>   ArmPlatformPkg/NorFlashPlatformLib: remove unused Guid member from
>     struct
>
>  .../Drivers/NorFlashDxe/NorFlashDxe.c         | 15 ++--
>  .../Drivers/NorFlashDxe/NorFlashDxe.h         |  3 +
>  .../Include/Library/NorFlashPlatformLib.h     |  1 -
>  ArmVirtPkg/FdtClientDxe/FdtClientDxe.c        | 38 +++++++--
>  .../Library/NorFlashQemuLib/NorFlashQemuLib.c | 78 ++++++++++++++-----
>  .../NorFlashQemuLib/NorFlashQemuLib.inf       | 12 +++
>  6 files changed, 114 insertions(+), 33 deletions(-)
>

Pushed as 1ec194b21c0e..72e514c90730

Thanks all


  parent reply	other threads:[~2018-11-26 17:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-21 11:58 [PATCH v2 0/5] ArmPlatformPkg, ArmVirtPkg: discover NOR flash banks from DTB Ard Biesheuvel
2018-11-21 11:58 ` [PATCH v2 1/5] ArmPlatformPkg/NorFlashDxe: prepare for devicepath format change Ard Biesheuvel
2018-11-21 17:01   ` Laszlo Ersek
2018-11-22 15:54   ` Philippe Mathieu-Daudé
2018-11-21 11:58 ` [PATCH v2 2/5] ArmPlatformPkg/NorFlashDxe: use one GUID plus index to identify flash banks Ard Biesheuvel
2018-11-21 17:03   ` Laszlo Ersek
2018-11-22 15:36   ` Philippe Mathieu-Daudé
2018-11-21 11:58 ` [PATCH v2 3/5] ArmVirtPkg/FdtClientDxe: take DT node 'status' properties into account Ard Biesheuvel
2018-11-21 17:12   ` Laszlo Ersek
2018-11-22 13:12     ` Ard Biesheuvel
2018-11-22 15:38   ` Philippe Mathieu-Daudé
2018-11-21 11:58 ` [PATCH v2 4/5] ArmVirtPkg/NorFlashQemuLib: discover NOR flash banks dynamically Ard Biesheuvel
2018-11-21 17:18   ` Laszlo Ersek
2018-11-21 11:58 ` [PATCH v2 5/5] ArmPlatformPkg/NorFlashPlatformLib: remove unused Guid member from struct Ard Biesheuvel
2018-11-21 17:22   ` Laszlo Ersek
2018-11-26 17:00 ` Ard Biesheuvel [this message]
2018-11-26 17:02   ` [PATCH v2 0/5] ArmPlatformPkg, ArmVirtPkg: discover NOR flash banks from DTB Ard Biesheuvel
2018-11-27 12:07     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu9v_QvBE6XW9+PjAkJCvnRnMOivc4+81nM9i34oTGfumg@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox