From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::142; helo=mail-it1-x142.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2475521A00AE6 for ; Mon, 26 Nov 2018 09:00:47 -0800 (PST) Received: by mail-it1-x142.google.com with SMTP id x124so24439955itd.1 for ; Mon, 26 Nov 2018 09:00:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hEBmb+8obCzpU+DUQiDqvFKx9jyBbRUGeIoIgx8l3P0=; b=IKx2NOxlt/QdOGurt1yLqforoud7UdTyZR7XPi7a+Iaou9D6k5OwT3azVHXVp7sk8V KPTOaQ7rOZe5pBrcGwklTNiDBXcKaviZhvuD/GaabvU9I2D9mRpjddm63ahGggLLZTbi Pv/BRzpVb0i/Wfb3c8nARJ+WgqvfIOzmHLVX8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hEBmb+8obCzpU+DUQiDqvFKx9jyBbRUGeIoIgx8l3P0=; b=nsWF6Fr9/kzoxFcrt0nMw8Z0kni2SiXEmXPT+JT87ppoznVGrPmZ4MyyN/Du/lgXcG 2bEYt6OWpq3aPR5NFCTvpD/C1yTD2VbA+3emG0XRlk0aKjmRjJAvkdPp5dL2hGpXE57U 6AX7nrozjyHGElGJNIMM0Osl6aWWwfS6n2rkb9OsbjGGOWPZxEsjGzo/Lw6wYF5z5nR8 5WkRiKDtOUKyrQ46OCbogpn0c3XZKwSw3H5wdYx6fViI+pQNtCsE2rxtQ9A3PfAIqC28 40AQSAMjL3yHxDKtn020y0eKKcp8yExvr2a9hs6SJJ5XSqBSPDqHcYkPwlixAOHvp2aJ xIZQ== X-Gm-Message-State: AGRZ1gI3LKDU9hHvqO86htA+vy7WNjhWYrdLic1eIRn5LGC3ZbrCGjXB PNYVfODaOqc+9ElNikXFi3g8wv1MYW9wRNBw1HJQMpNzVmM= X-Google-Smtp-Source: AFSGD/Vejgi9wMvmMVqDfciWkZ1YQ7kWz35HM7j8FjiN/XNLGzZs32FoSgdMvopj6d73FPT919SA03N8Uhkzlx7moJI= X-Received: by 2002:a24:710:: with SMTP id f16mr21495886itf.121.1543251645713; Mon, 26 Nov 2018 09:00:45 -0800 (PST) MIME-Version: 1.0 References: <20181121115828.3026-1-ard.biesheuvel@linaro.org> In-Reply-To: <20181121115828.3026-1-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Mon, 26 Nov 2018 18:00:34 +0100 Message-ID: To: "edk2-devel@lists.01.org" Cc: Leif Lindholm , Laszlo Ersek , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Hongbo Zhang , Nariman Poushin , Thomas Panakamattam Abraham Subject: Re: [PATCH v2 0/5] ArmPlatformPkg, ArmVirtPkg: discover NOR flash banks from DTB X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2018 17:00:47 -0000 Content-Type: text/plain; charset="UTF-8" On Wed, 21 Nov 2018 at 12:58, Ard Biesheuvel wrote: > > This series fixes an issue reported by Hongbo and Philippe, where > ArmVirtQemuKernel will crash on an attempt to access flash bank #0, > which is secure-only when running QEMU with support for EL3. > > So let's switch to discovering the NOR flash banks from the device tree > instead. This requires some preparatory changes in the NOR flash driver > to avoid having to invent GUIDs on the fly. > > Changes since v1: > - split ArmPlatformPkg for clarity > - move DT node status check into FdtClientDxe where it belongs > - use correct UINT32* type for DT property values, and be pedantic about > their potential misalignment when casting to UINT64* > - add patch to remove the 'Guid' member from NOR_FLASH_DESCRIPTION > - add some acks > > Ard Biesheuvel (5): > ArmPlatformPkg/NorFlashDxe: prepare for devicepath format change > ArmPlatformPkg/NorFlashDxe: use one GUID plus index to identify flash > banks > ArmVirtPkg/FdtClientDxe: take DT node 'status' properties into account > ArmVirtPkg/NorFlashQemuLib: discover NOR flash banks dynamically > ArmPlatformPkg/NorFlashPlatformLib: remove unused Guid member from > struct > > .../Drivers/NorFlashDxe/NorFlashDxe.c | 15 ++-- > .../Drivers/NorFlashDxe/NorFlashDxe.h | 3 + > .../Include/Library/NorFlashPlatformLib.h | 1 - > ArmVirtPkg/FdtClientDxe/FdtClientDxe.c | 38 +++++++-- > .../Library/NorFlashQemuLib/NorFlashQemuLib.c | 78 ++++++++++++++----- > .../NorFlashQemuLib/NorFlashQemuLib.inf | 12 +++ > 6 files changed, 114 insertions(+), 33 deletions(-) > Pushed as 1ec194b21c0e..72e514c90730 Thanks all