public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Haojian Zhuang <haojian.zhuang@linaro.org>
Cc: Ryan Harkin <ryan.harkin@linaro.org>,
	edk2-devel-01 <edk2-devel@lists.01.org>,
	 Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH v7 0/4] enhance MMC
Date: Wed, 23 Nov 2016 08:54:40 +0000	[thread overview]
Message-ID: <CAKv+Gu9vzPM-s+AmU04LAb2z0OF79QTkrELiG=r-B2=94+PV+Q@mail.gmail.com> (raw)
In-Reply-To: <1479884921-25398-1-git-send-email-haojian.zhuang@linaro.org>

On 23 November 2016 at 07:08, Haojian Zhuang <haojian.zhuang@linaro.org> wrote:
> v7:
>   * Add revision checking.
>

Thanks for the hard work and the quick turnaround, but I'm afraid
we're not quite there yet.

Please find my comments in response to the individual patches

> v6:
>   * Reformat the last 5 patches after 4 MMC patches of this series merged.
>   * Squash original #5 and #6 patches together.
>   * Fix according comments.
>
> v5:
>   * Remove patch on MediaId.
>   * Squash two PL180 patches together.
>
> v4:
>   * Fix PL180 hang in some cases. Since the proper variable length
>     isn't set for CMD6 & ACMD51.
>
> v3:
>   * Fix PL180 hang because of CMD6 & ACMD51 not supported.
>
> v2:
>   * Fix print error with missing parameter.
>   * Change CMD51 to ACMD51.
>   * Add the protection after CMD55 for SD. If there's no
>     response of CMD55, skip to send ACMD51.
>
> v1:
>   * Wait OCR busy bit free according to eMMC spec.
>   * Define ECSD structure.
>   * Add interface to set IO bus width and speed.
>   * Support to access multiple blocks.
>
> Haojian Zhuang (4):
>   MmcDxe: add interface to change io width and speed
>   MmcDxe: set iospeed and bus width in SD stack
>   PL180: update for indentifying SD
>   MmcDxe: expand to support multiple blocks
>
>  ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c    |  29 ++-
>  EmbeddedPkg/Include/Protocol/MmcHost.h           |  36 ++-
>  EmbeddedPkg/Universal/MmcDxe/Mmc.h               |  25 ++
>  EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c        | 176 +++++++++-----
>  EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 291 ++++++++++++++++++++++-
>  5 files changed, 487 insertions(+), 70 deletions(-)
>
> --
> 2.7.4
>


      parent reply	other threads:[~2016-11-23  8:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-23  7:08 [PATCH v7 0/4] enhance MMC Haojian Zhuang
2016-11-23  7:08 ` [PATCH v7 1/4] MmcDxe: add interface to change io width and speed Haojian Zhuang
2016-11-23  8:56   ` Ard Biesheuvel
2016-11-23  7:08 ` [PATCH v7 2/4] MmcDxe: set iospeed and bus width in SD stack Haojian Zhuang
2016-11-23  8:58   ` Ard Biesheuvel
2016-11-23  7:08 ` [PATCH v7 3/4] PL180: update for indentifying SD Haojian Zhuang
2016-11-23  8:59   ` Ard Biesheuvel
2016-11-23  7:08 ` [PATCH v7 4/4] MmcDxe: expand to support multiple blocks Haojian Zhuang
2016-11-23  9:01   ` Ard Biesheuvel
2016-11-23  8:54 ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu9vzPM-s+AmU04LAb2z0OF79QTkrELiG=r-B2=94+PV+Q@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox