From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x230.google.com (mail-io0-x230.google.com [IPv6:2607:f8b0:4001:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3844D81C8D for ; Wed, 23 Nov 2016 00:54:41 -0800 (PST) Received: by mail-io0-x230.google.com with SMTP id c21so12663285ioj.1 for ; Wed, 23 Nov 2016 00:54:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=HmccdSSQbh7Ff1asEJWL2+nyNK4De2qzPpbNnW9B5Uc=; b=EbcqaK/BI8/C0EZ3nq0iJBDBKEm8TtQCQKv0AiSgU6mhB/nDDTb4x6O28VxNM2GUcg 1dvSewtzlUVpMVVdzrHZhF2sE7f2QIPM+I5I9nztL0OacZ1RzQCX3AMWwfbhGSldhTYo WZWwQIV9Y25vo3PCczFmJSBa663A5tQf12Zr8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=HmccdSSQbh7Ff1asEJWL2+nyNK4De2qzPpbNnW9B5Uc=; b=exNRfU/gzcGk5enO7MRcHOX7wIhtpyEa4NuL8VlWKWyJdajRogKr7fgbTgvTzFFpuH 6WrBsI6zSpJvDq9TUCavtphPeyv0Wl5kHr/yPXrBhaB03fxsi4eTnrFt8E0XHYayzD++ clK2dVM4MOGhHR3fOUScABhwYvKgR0EQ59GkP7DzU9mVaB7zX5sEt4w7Msol+oD+V1lQ SMZqTHALQAYB4TdopDH69sIzS5wQrSKkswWHUGmNnaWMQR6RFV/EwqvJU85J6WRDUJAc 9B4GFG9R14MrDbairuqEyzJtYtAJj567IlZnPZpOrY5VhVpBVpRaLOtvSrgGZKmVPHbc 1ykQ== X-Gm-Message-State: AKaTC00egk+rMU0+ZdCggi7nxCkKq6AFw7vntSmLeJhfeBP2PkDxVMuSc9dly7OX8OXANXzRc3CeVRH4WxY7Dzc6 X-Received: by 10.107.18.39 with SMTP id a39mr1968872ioj.45.1479891280404; Wed, 23 Nov 2016 00:54:40 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.59.147 with HTTP; Wed, 23 Nov 2016 00:54:40 -0800 (PST) In-Reply-To: <1479884921-25398-1-git-send-email-haojian.zhuang@linaro.org> References: <1479884921-25398-1-git-send-email-haojian.zhuang@linaro.org> From: Ard Biesheuvel Date: Wed, 23 Nov 2016 08:54:40 +0000 Message-ID: To: Haojian Zhuang Cc: Ryan Harkin , edk2-devel-01 , Leif Lindholm Subject: Re: [PATCH v7 0/4] enhance MMC X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Nov 2016 08:54:41 -0000 Content-Type: text/plain; charset=UTF-8 On 23 November 2016 at 07:08, Haojian Zhuang wrote: > v7: > * Add revision checking. > Thanks for the hard work and the quick turnaround, but I'm afraid we're not quite there yet. Please find my comments in response to the individual patches > v6: > * Reformat the last 5 patches after 4 MMC patches of this series merged. > * Squash original #5 and #6 patches together. > * Fix according comments. > > v5: > * Remove patch on MediaId. > * Squash two PL180 patches together. > > v4: > * Fix PL180 hang in some cases. Since the proper variable length > isn't set for CMD6 & ACMD51. > > v3: > * Fix PL180 hang because of CMD6 & ACMD51 not supported. > > v2: > * Fix print error with missing parameter. > * Change CMD51 to ACMD51. > * Add the protection after CMD55 for SD. If there's no > response of CMD55, skip to send ACMD51. > > v1: > * Wait OCR busy bit free according to eMMC spec. > * Define ECSD structure. > * Add interface to set IO bus width and speed. > * Support to access multiple blocks. > > Haojian Zhuang (4): > MmcDxe: add interface to change io width and speed > MmcDxe: set iospeed and bus width in SD stack > PL180: update for indentifying SD > MmcDxe: expand to support multiple blocks > > ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c | 29 ++- > EmbeddedPkg/Include/Protocol/MmcHost.h | 36 ++- > EmbeddedPkg/Universal/MmcDxe/Mmc.h | 25 ++ > EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c | 176 +++++++++----- > EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 291 ++++++++++++++++++++++- > 5 files changed, 487 insertions(+), 70 deletions(-) > > -- > 2.7.4 >