Re: [edk2-devel] [PATCH v3 0/7] update ArmSoftFloatLib to latest upstream version

["Ard Biesheuvel" <ard.biesheuvel@linaro.org>]

On Mon, 3 Jun 2019 at 02:59, Gao, Liming <liming.gao@intel.com> wrote:
>
> Leif:
>   I see Ard patch ArmPkg/ArmSoftFloatLib GCC4x: fix build failure https://edk2.groups.io/g/devel/topic/patch/31884674?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,31884674
>
>   Does it fix your CI issue?
>

Yes, the CI issue is fixed now.

Patches 6/7 and 7/7 are not required for that, since I did not merge
the patch that adds -std=c99 to all Clang invocations. This was
unnecessary since Jian's patch already adds it as well, but only for
building OpensslLib, which is sufficient.

I will merge 6/7 and 7/7 after the stable tag is created.


> >-----Original Message-----
> >From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> >Sent: Saturday, June 01, 2019 3:29 AM
> >To: Kinney, Michael D <michael.d.kinney@intel.com>
> >Cc: devel@edk2.groups.io; ard.biesheuvel@linaro.org; Laszlo Ersek
> ><lersek@redhat.com>; Gao, Liming <liming.gao@intel.com>; Wang, Jian J
> ><jian.j.wang@intel.com>
> >Subject: Re: [edk2-devel] [PATCH v3 0/7] update ArmSoftFloatLib to latest
> >upstream version
> >
> >On Fri, May 31, 2019 at 04:21:19PM +0000, Kinney, Michael D wrote:
> >> Ard,
> >>
> >> Thank you for all the hard work on this issue.
> >
> >I concur.
> >*However*, please hold back on tagging the stable release. Something
> >that looks related has broken our CI.
> >
> >Regards,
> >
> >Leif
> >
> >> I will do one additional patch for the top level
> >> Readme.md to list this additional submodule.
> >>
> >> Thanks,
> >>
> >> Mike
> >>
> >> > -----Original Message-----
> >> > From: devel@edk2.groups.io
> >> > [mailto:devel@edk2.groups.io] On Behalf Of Ard
> >> > Biesheuvel
> >> > Sent: Friday, May 31, 2019 9:00 AM
> >> > To: edk2-devel-groups-io <devel@edk2.groups.io>; Leif
> >> > Lindholm <leif.lindholm@linaro.org>
> >> > Cc: Laszlo Ersek <lersek@redhat.com>; Gao, Liming
> >> > <liming.gao@intel.com>; Wang, Jian J
> >> > <jian.j.wang@intel.com>; Kinney, Michael D
> >> > <michael.d.kinney@intel.com>
> >> > Subject: Re: [edk2-devel] [PATCH v3 0/7] update
> >> > ArmSoftFloatLib to latest upstream version
> >> >
> >> > On Fri, 31 May 2019 at 15:09, Leif Lindholm
> >> > <leif.lindholm@linaro.org> wrote:
> >> > >
> >> > > On Fri, May 31, 2019 at 02:49:51PM +0200, Ard
> >> > Biesheuvel wrote:
> >> > > > Currently, our move to OpenSSL 1.1.1b is being
> >> > blocked by an issue in
> >> > > > the ARM software floating point library, which
> >> > lacks some intrinsics
> >> > > > that the ARM EABI spec defines.
> >> > > >
> >> > > > Since the code was in pretty sorry state, let's fix
> >> > this by upgrading
> >> > > > to the very latest version of the core library this
> >> > code is based on,
> >> > > > dated January 2018 (whereas the NetBSD fork of the
> >> > old code dates back
> >> > > > to 2002)
> >> > >
> >> > > It is worth mentioning that there is exactly one
> >> > patch on top of 3e
> >> > > release, and that resolves a syntax error in RICV
> >> > code (currently
> >> > > unused).
> >> > >
> >> > > I have a couple of really tiny comments on later
> >> > patches, but many
> >> > > thanks for unbundling this conundrum (and preventing
> >> > yet anoher fork).
> >> > >
> >> >
> >> > OK I have merged the following patches of this series
> >> >
> >> > 85af0b8116f3 ArmPkg: import Berkeley Softfloat library
> >> > as git submodule
> >> > 3cc57695df5a ArmPkg/ArmSoftFloatLib: switch to new
> >> > version of softfloat library
> >> > 99243102b467 ArmPkg/ArmSoftFloatLib: remove source
> >> > files that are no longer used
> >> > 8594c2073cdb ArmPkg/ArmLib ARM: set .fpu to let Clang 7
> >> > assemble ArmV7Support.S
> >> >
> >> > which are the only ones that turn out to be required to
> >> > build
> >> > OpensslLib for ARM when using Jian latest v5 of the
> >> > OpenSSL 1.1.1b
> >> > upgrade
> >> >
> >> > Thanks all,
> >> > Ard.
> >> >
> >> > 
> >>