From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=V3+zVlVz; spf=pass (domain: linaro.org, ip: 209.85.166.196, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-it1-f196.google.com (mail-it1-f196.google.com [209.85.166.196]) by groups.io with SMTP; Sun, 02 Jun 2019 23:04:31 -0700 Received: by mail-it1-f196.google.com with SMTP id m141so25456106ita.3 for ; Sun, 02 Jun 2019 23:04:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fR5JyNjLsaRf50NZ2wB6o1uxgeMXBtRXXVk9geqEctk=; b=V3+zVlVzUwZLpsA3xUa1Vzis1WfNmwe6fQKdPmnw5neoudHfPVME50EgAUuzoq24Ob AgaFYrSpCiRcv7tavEk3LfdOSFfXtntTY+IOg1i5ckKQXUQuFQ/iSFP6Cc2XLDun7uaG XwchC1hSJbPDgM3/U4ZLfGPeFmgO5u0PZdtDKqXZFMFdaUmtSUFQ39gY9Lp5jsMmxeMb 7Vv6/Mq7/i8LJ6QtRND6b7D+LmqPgC+jpco3gKaBEQo47BifQgr+XahSQ8CQuz2EBrnm iLsPTI5Yc5V7K0SSK6+4y+Og6zg70i4AIPTZZjC/6dWDdAQTpfS8fRow0d7Zk/gz/2bV PqgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fR5JyNjLsaRf50NZ2wB6o1uxgeMXBtRXXVk9geqEctk=; b=tfBC3VwmmsMeCWPCeeQP8Tz8Di5eeaqkiYf+zpN0zc/sm/FcGlvuztr4nVijpMiXEL 16oQLP05BIeUPO9Y+HcaU9rDIyPgfmFA/k6/EXTgSiaHb+LarQzpFp7u66PPkyIswF5/ DXCCbLd/yK8Qbjeo5b9wb8YbctfOFPtwRn1PSr0SVrHHmNWwXLbhhRMiXhxZHWLqB5Wp VkV2aG3Vw3XICV4bmSGlMW6AHxM6CkaX9/qXMH4ZRj5rUl3C/IyMCr52A/2HlE8n7oq5 r3m4IP0fUR4YrE+i7Z+uEDlyIBtI6SY2KEGhLGfQYH+a0ePGWMdL8O/85anEJ/NLYIUF 2czA== X-Gm-Message-State: APjAAAX8uy6x7GQ8sPbAhzFbnHwfLjmi9etbVdIgin0GCl65qf5LnJ8Q IXfh3i/ub0wcnJV32Nx3nvWJoq++J0ns9mTPfUCirA== X-Google-Smtp-Source: APXvYqxUWhokq+/sUnQaY+8yxo6uiLB6FFxFqJgQer09z+ML7mUg352agG6ZX+cVTgOq2C+70MKtpJQOsmVebRd0uKs= X-Received: by 2002:a24:6b86:: with SMTP id v128mr9829893itc.104.1559541870272; Sun, 02 Jun 2019 23:04:30 -0700 (PDT) MIME-Version: 1.0 References: <20190531124958.8421-1-ard.biesheuvel@linaro.org> <20190531130924.szfyed247nks7gii@bivouac.eciton.net> <20190531192856.htjzxx24k3yzvicp@bivouac.eciton.net> <4A89E2EF3DFEDB4C8BFDE51014F606A14E468E29@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E468E29@SHSMSX104.ccr.corp.intel.com> From: "Ard Biesheuvel" Date: Mon, 3 Jun 2019 08:04:16 +0200 Message-ID: Subject: Re: [edk2-devel] [PATCH v3 0/7] update ArmSoftFloatLib to latest upstream version To: "Gao, Liming" Cc: Leif Lindholm , "Kinney, Michael D" , "devel@edk2.groups.io" , Laszlo Ersek , "Wang, Jian J" Content-Type: text/plain; charset="UTF-8" On Mon, 3 Jun 2019 at 02:59, Gao, Liming wrote: > > Leif: > I see Ard patch ArmPkg/ArmSoftFloatLib GCC4x: fix build failure https://edk2.groups.io/g/devel/topic/patch/31884674?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,31884674 > > Does it fix your CI issue? > Yes, the CI issue is fixed now. Patches 6/7 and 7/7 are not required for that, since I did not merge the patch that adds -std=c99 to all Clang invocations. This was unnecessary since Jian's patch already adds it as well, but only for building OpensslLib, which is sufficient. I will merge 6/7 and 7/7 after the stable tag is created. > >-----Original Message----- > >From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > >Sent: Saturday, June 01, 2019 3:29 AM > >To: Kinney, Michael D > >Cc: devel@edk2.groups.io; ard.biesheuvel@linaro.org; Laszlo Ersek > >; Gao, Liming ; Wang, Jian J > > > >Subject: Re: [edk2-devel] [PATCH v3 0/7] update ArmSoftFloatLib to latest > >upstream version > > > >On Fri, May 31, 2019 at 04:21:19PM +0000, Kinney, Michael D wrote: > >> Ard, > >> > >> Thank you for all the hard work on this issue. > > > >I concur. > >*However*, please hold back on tagging the stable release. Something > >that looks related has broken our CI. > > > >Regards, > > > >Leif > > > >> I will do one additional patch for the top level > >> Readme.md to list this additional submodule. > >> > >> Thanks, > >> > >> Mike > >> > >> > -----Original Message----- > >> > From: devel@edk2.groups.io > >> > [mailto:devel@edk2.groups.io] On Behalf Of Ard > >> > Biesheuvel > >> > Sent: Friday, May 31, 2019 9:00 AM > >> > To: edk2-devel-groups-io ; Leif > >> > Lindholm > >> > Cc: Laszlo Ersek ; Gao, Liming > >> > ; Wang, Jian J > >> > ; Kinney, Michael D > >> > > >> > Subject: Re: [edk2-devel] [PATCH v3 0/7] update > >> > ArmSoftFloatLib to latest upstream version > >> > > >> > On Fri, 31 May 2019 at 15:09, Leif Lindholm > >> > wrote: > >> > > > >> > > On Fri, May 31, 2019 at 02:49:51PM +0200, Ard > >> > Biesheuvel wrote: > >> > > > Currently, our move to OpenSSL 1.1.1b is being > >> > blocked by an issue in > >> > > > the ARM software floating point library, which > >> > lacks some intrinsics > >> > > > that the ARM EABI spec defines. > >> > > > > >> > > > Since the code was in pretty sorry state, let's fix > >> > this by upgrading > >> > > > to the very latest version of the core library this > >> > code is based on, > >> > > > dated January 2018 (whereas the NetBSD fork of the > >> > old code dates back > >> > > > to 2002) > >> > > > >> > > It is worth mentioning that there is exactly one > >> > patch on top of 3e > >> > > release, and that resolves a syntax error in RICV > >> > code (currently > >> > > unused). > >> > > > >> > > I have a couple of really tiny comments on later > >> > patches, but many > >> > > thanks for unbundling this conundrum (and preventing > >> > yet anoher fork). > >> > > > >> > > >> > OK I have merged the following patches of this series > >> > > >> > 85af0b8116f3 ArmPkg: import Berkeley Softfloat library > >> > as git submodule > >> > 3cc57695df5a ArmPkg/ArmSoftFloatLib: switch to new > >> > version of softfloat library > >> > 99243102b467 ArmPkg/ArmSoftFloatLib: remove source > >> > files that are no longer used > >> > 8594c2073cdb ArmPkg/ArmLib ARM: set .fpu to let Clang 7 > >> > assemble ArmV7Support.S > >> > > >> > which are the only ones that turn out to be required to > >> > build > >> > OpensslLib for ARM when using Jian latest v5 of the > >> > OpenSSL 1.1.1b > >> > upgrade > >> > > >> > Thanks all, > >> > Ard. > >> > > >> > > >>