Re: [platforms: PATCH v2 1/7] Silicon/SynQuacer/PlatformDxe: adjust to updated SdMmcOverride

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 5 October 2018 at 15:26, Marcin Wojtas <mw@semihalf.com> wrote:
> The newest changes in the SdMmcOverride protocol added additional
> arguments to the NotifyPhase and Capability routines. Update
> according places in the Synquacer Emmc driver.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
>  Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c
> index e0987c9..0a917a5 100644
> --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c
> +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c
> @@ -72,6 +72,8 @@ STATIC VOID                             *mEventRegistration;
>    @param[in]      ControllerHandle      The EFI_HANDLE of the controller.
>    @param[in]      Slot                  The 0 based slot index.
>    @param[in,out]  SdMmcHcSlotCapability The SDHCI capability structure.
> +  @param[in,out]  BaseClkFreq           The base clock frequency value that
> +                                        optionally can be updated.
>
>    @retval EFI_SUCCESS           The override function completed successfully.
>    @retval EFI_NOT_FOUND         The specified controller or slot does not exist.
> @@ -84,7 +86,8 @@ EFIAPI
>  SynQuacerSdMmcCapability (
>    IN      EFI_HANDLE                      ControllerHandle,
>    IN      UINT8                           Slot,
> -  IN  OUT VOID                            *SdMmcHcSlotCapability
> +  IN OUT  VOID                            *SdMmcHcSlotCapability,
> +  IN OUT  UINT32                          *BaseClkFreq
>    )
>  {
>    UINT64 Capability;
> @@ -117,6 +120,7 @@ SynQuacerSdMmcCapability (
>    @param[in]      PhaseType             The type of operation and whether the
>                                          hook is invoked right before (pre) or
>                                          right after (post)
> +  @param[in,out]  Data                  The pointer to a phase-specific data.
>
>    @retval EFI_SUCCESS           The override function completed successfully.
>    @retval EFI_NOT_FOUND         The specified controller or slot does not exist.
> @@ -129,7 +133,8 @@ EFIAPI
>  SynQuacerSdMmcNotifyPhase (
>    IN      EFI_HANDLE                      ControllerHandle,
>    IN      UINT8                           Slot,
> -  IN      EDKII_SD_MMC_PHASE_TYPE         PhaseType
> +  IN      EDKII_SD_MMC_PHASE_TYPE         PhaseType,
> +  IN OUT  VOID                            *Data

Please align the name with the EDK2 changes.

>    )
>  {
>    if (ControllerHandle != mSdMmcControllerHandle) {
> --
> 2.7.4
>