From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::142; helo=mail-it1-x142.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2332A21163277 for ; Mon, 8 Oct 2018 05:50:20 -0700 (PDT) Received: by mail-it1-x142.google.com with SMTP id l127-v6so10474701ith.1 for ; Mon, 08 Oct 2018 05:50:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=tJeSv7Hunw66n/UAjBJ0hY1qistY6uONDBSMfSbn17E=; b=gtC79HyXYv0N1ARlPjBGA5fl3KhD8VyBQ04kSqK4xTv4LmAuEslhIw9e7mTjLVRM3o ZgVGlQj3TTC/0YewglLvsKu/eOcjzg7ETMe1qFbalgDiD/Y3iBDjlq3WAmiSpN0XGyc8 d/GTj0mejLhrv5IbAV/2LDUYH46R2CF7HuYI0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=tJeSv7Hunw66n/UAjBJ0hY1qistY6uONDBSMfSbn17E=; b=lZtXphZO3X+AVFuf4Ww9t3KMVxrVEDK19uhKMk/ErxjuqDpL5vISKAY1aFzuBSh6tz riSkbjGimrCr7y7pbcFgbkiQKZpemSNIrB0+wDW/E0YexXK1RwXSh7E0p9rR4SafaOT5 8QnpKoxNEp7OsqqHfCO8bHZdNWgX9NLOI/iTz6L4Gr8w9HXITVnOH4kX09+ug4fPEllP +3tVzUbYt25dahxzrHz4+fQ6N3Dm+nQhKLtyiqiT595oVWMTdzeACUziwIjsws0MAoAs 1nH72xdIml5H8oeFpcZXHN5Hvtqo58l1CNvFXB6Z5R+27lceWsNvv1Rd39rRIwpNALAJ fNew== X-Gm-Message-State: ABuFfohRWRv+xlwV2+1qHZdJPXh6hW//r0Hj3Jt5okUqoL0wkeDofdYr fAQqWxgsZzdjHUfcctJjq/CwolaqWTctqEaqvD3a0w== X-Google-Smtp-Source: ACcGV61ZvqCO3khCO+A3RbocqiAKWRgOR8hMNLIy2LpT3MbS58HRwnCiJzvPSLIGPIiLxKHtThY2exBD5pIY6A8GxQM= X-Received: by 2002:a02:6f58:: with SMTP id b24-v6mr18521622jae.130.1539003019269; Mon, 08 Oct 2018 05:50:19 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:5910:0:0:0:0:0 with HTTP; Mon, 8 Oct 2018 05:50:18 -0700 (PDT) In-Reply-To: <1538745968-22526-2-git-send-email-mw@semihalf.com> References: <1538745968-22526-1-git-send-email-mw@semihalf.com> <1538745968-22526-2-git-send-email-mw@semihalf.com> From: Ard Biesheuvel Date: Mon, 8 Oct 2018 14:50:18 +0200 Message-ID: To: Marcin Wojtas Cc: "edk2-devel@lists.01.org" , Leif Lindholm , "Wu, Hao A" , Nadav Haklai , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Tomasz Michalec Subject: Re: [platforms: PATCH v2 1/7] Silicon/SynQuacer/PlatformDxe: adjust to updated SdMmcOverride X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 12:50:20 -0000 Content-Type: text/plain; charset="UTF-8" On 5 October 2018 at 15:26, Marcin Wojtas wrote: > The newest changes in the SdMmcOverride protocol added additional > arguments to the NotifyPhase and Capability routines. Update > according places in the Synquacer Emmc driver. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas > --- > Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c > index e0987c9..0a917a5 100644 > --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c > +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c > @@ -72,6 +72,8 @@ STATIC VOID *mEventRegistration; > @param[in] ControllerHandle The EFI_HANDLE of the controller. > @param[in] Slot The 0 based slot index. > @param[in,out] SdMmcHcSlotCapability The SDHCI capability structure. > + @param[in,out] BaseClkFreq The base clock frequency value that > + optionally can be updated. > > @retval EFI_SUCCESS The override function completed successfully. > @retval EFI_NOT_FOUND The specified controller or slot does not exist. > @@ -84,7 +86,8 @@ EFIAPI > SynQuacerSdMmcCapability ( > IN EFI_HANDLE ControllerHandle, > IN UINT8 Slot, > - IN OUT VOID *SdMmcHcSlotCapability > + IN OUT VOID *SdMmcHcSlotCapability, > + IN OUT UINT32 *BaseClkFreq > ) > { > UINT64 Capability; > @@ -117,6 +120,7 @@ SynQuacerSdMmcCapability ( > @param[in] PhaseType The type of operation and whether the > hook is invoked right before (pre) or > right after (post) > + @param[in,out] Data The pointer to a phase-specific data. > > @retval EFI_SUCCESS The override function completed successfully. > @retval EFI_NOT_FOUND The specified controller or slot does not exist. > @@ -129,7 +133,8 @@ EFIAPI > SynQuacerSdMmcNotifyPhase ( > IN EFI_HANDLE ControllerHandle, > IN UINT8 Slot, > - IN EDKII_SD_MMC_PHASE_TYPE PhaseType > + IN EDKII_SD_MMC_PHASE_TYPE PhaseType, > + IN OUT VOID *Data Please align the name with the EDK2 changes. > ) > { > if (ControllerHandle != mSdMmcControllerHandle) { > -- > 2.7.4 >