Re: [PATCH] Silicon/Hisilicon: switch to NonDiscoverable driver for EHCI

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 24 August 2017 at 21:21, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> Replace the open coded PCI 'emulation' with a simple call into
> the NonDiscoverable device registration library, and fix up all
> platform .DSCs/FDFs accordingly.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> I can't test this myself, unfortunately.
>
>  Platform/Hisilicon/D02/Pv660D02.dsc                             |   1 +
>  Platform/Hisilicon/D02/Pv660D02.fdf                             |   1 +
>  Platform/Hisilicon/D03/D03.dsc                                  |   1 +
>  Platform/Hisilicon/D03/D03.fdf                                  |   1 +
>  Platform/Hisilicon/D05/D05.dsc                                  |   1 +
>  Platform/Hisilicon/D05/D05.fdf                                  |   1 +
>  Platform/Hisilicon/HiKey/HiKey.dsc                              |   2 -

Apologies, this hunk does not belong in this patch. I intended to
include the following instead.

diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc
b/Silicon/Hisilicon/Hisilicon.dsc.inc
index a48c4773adc2..fadd352192ee 100644
--- a/Silicon/Hisilicon/Hisilicon.dsc.inc
+++ b/Silicon/Hisilicon/Hisilicon.dsc.inc
@@ -16,10 +16,8 @@
 [LibraryClasses.common]
 !if $(TARGET) == RELEASE
   DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
-  UncachedMemoryAllocationLib|ArmPkg/Library/UncachedMemoryAllocationLib/UncachedMemoryAllocationLib.inf
 !else
   DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
-  UncachedMemoryAllocationLib|ArmPkg/Library/UncachedMemoryAllocationLib/UncachedMemoryAllocationLib.inf
 !endif
   DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf

@@ -114,6 +112,8 @@
   ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
   LzmaDecompressLib|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf

+  NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
+
   #
   # It is not possible to prevent the ARM compiler for generic
intrinsic functions.
   # This library provides the instrinsic functions generate by a
given compiler.