From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x231.google.com (mail-it0-x231.google.com [IPv6:2607:f8b0:4001:c0b::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EC2B12095AE51 for ; Thu, 24 Aug 2017 13:20:56 -0700 (PDT) Received: by mail-it0-x231.google.com with SMTP id x187so2439607ite.1 for ; Thu, 24 Aug 2017 13:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=3AQXDD6GUA/njF9fYPv3v2QtU0UVq8K/YLWmtqLknTM=; b=GAMycnpUR/VLxjdnOG3tYqRWfXpep3sHEp+QXQEY3zV8SKx1fyvITtc7pAx1a8LSDc OCsJSUYKWGeVSzute04R72gvOsQQJ4dfjYgUY/MchAKkod0ZwI2+wZ8wFPsyzIHmSP9Y RPbh8FNo7IcKEYp2WuMYsn+kKr4UyZMKA3nPM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=3AQXDD6GUA/njF9fYPv3v2QtU0UVq8K/YLWmtqLknTM=; b=ldBKpJRN0a8t5zWTRz77DyBpa6Rl4qXSwLcCad8uvLvFy30kTAmVK2lO7KtuLMWR3D PMATsTUy2rQkJi3sCXA1JMROzCiOSiug9H6yBpFVtcC38q4N4Sq+9ajJX+AwNQnPA1kY O3NeQtX7nx5NFrbS5bWVknWsb3PrFaa4kGyeAKx0kt+NE0lOhgCYcJo+AqVXWDiYOBrF dLPWGMhIqvX0MgfzoAh2+2tG6ZDLi20pb9F5wPFaQY5jtvMqQfKh5xXbEv4H9EmcAAbF iV+vmuydKw13b7kXN63WV9H+7yQ4BKebrieYF6fhzHd36mNgbMn9RhyxoZd0Z7NIN9mr ntxg== X-Gm-Message-State: AHYfb5jat7l9glX2McPiNzX3HovrLIarmPxFfTaHYrM1Ee26//XQq2ir XRPmVKW+6d5Gc0uK83bdER9cEMcO+6qwg5EE+w== X-Received: by 10.36.148.9 with SMTP id j9mr4614ite.146.1503606211348; Thu, 24 Aug 2017 13:23:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Thu, 24 Aug 2017 13:23:30 -0700 (PDT) In-Reply-To: <20170824202132.24624-1-ard.biesheuvel@linaro.org> References: <20170824202132.24624-1-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Thu, 24 Aug 2017 21:23:30 +0100 Message-ID: To: "edk2-devel@lists.01.org" , Leif Lindholm Cc: Chenhui Sun , Graeme Gregory , Heyi Guo , Ard Biesheuvel Subject: Re: [PATCH] Silicon/Hisilicon: switch to NonDiscoverable driver for EHCI X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Aug 2017 20:20:57 -0000 Content-Type: text/plain; charset="UTF-8" On 24 August 2017 at 21:21, Ard Biesheuvel wrote: > Replace the open coded PCI 'emulation' with a simple call into > the NonDiscoverable device registration library, and fix up all > platform .DSCs/FDFs accordingly. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > I can't test this myself, unfortunately. > > Platform/Hisilicon/D02/Pv660D02.dsc | 1 + > Platform/Hisilicon/D02/Pv660D02.fdf | 1 + > Platform/Hisilicon/D03/D03.dsc | 1 + > Platform/Hisilicon/D03/D03.fdf | 1 + > Platform/Hisilicon/D05/D05.dsc | 1 + > Platform/Hisilicon/D05/D05.fdf | 1 + > Platform/Hisilicon/HiKey/HiKey.dsc | 2 - Apologies, this hunk does not belong in this patch. I intended to include the following instead. diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc b/Silicon/Hisilicon/Hisilicon.dsc.inc index a48c4773adc2..fadd352192ee 100644 --- a/Silicon/Hisilicon/Hisilicon.dsc.inc +++ b/Silicon/Hisilicon/Hisilicon.dsc.inc @@ -16,10 +16,8 @@ [LibraryClasses.common] !if $(TARGET) == RELEASE DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf - UncachedMemoryAllocationLib|ArmPkg/Library/UncachedMemoryAllocationLib/UncachedMemoryAllocationLib.inf !else DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf - UncachedMemoryAllocationLib|ArmPkg/Library/UncachedMemoryAllocationLib/UncachedMemoryAllocationLib.inf !endif DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf @@ -114,6 +112,8 @@ ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf LzmaDecompressLib|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf + NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf + # # It is not possible to prevent the ARM compiler for generic intrinsic functions. # This library provides the instrinsic functions generate by a given compiler.