From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d42; helo=mail-io1-xd42.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6304A2119A84A for ; Fri, 21 Dec 2018 10:00:19 -0800 (PST) Received: by mail-io1-xd42.google.com with SMTP id v10so4263419ios.13 for ; Fri, 21 Dec 2018 10:00:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Aub9zat1t2Frz5QHTVGXDy3nCQdkaky10YhBF5p+cWE=; b=j/Dpx1vYOE7Mikr+WG1QBc3/vl+Gbz0CVjS5QJ9iZt98VfCZi8z2E+5viCe/o/i4Ke Ff1KDLDnfhPt+btnxDBR17maTCq61keOOO+Jg5qUtbvN5qZ4qDkylEoh3TrxaM+rbB24 E2SqMDSY8oUP1237H43MJrBYs43DVpglezEkA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Aub9zat1t2Frz5QHTVGXDy3nCQdkaky10YhBF5p+cWE=; b=N2I2v3KpfhOHJdJ6AiVtBFuSah8BKNkdZKpJ/WnQ9KnPBn1EjJTl096d4OznR+X6Vl fGy25Y2I+h9m5O9UMLOllD/fWcN8uvzr4NlQOZoeyYhe8JvMLu0fLUonIblcNQWBPfjv 4ly5frF6f/n1f1ii8cY2VXml3HWhjWxHKJVEpimmAKhwkaVYdWeEB6ob5iwK2/OKBK0G k81BDZh1hQM9cfADAhO/POjqQFTMh7KBb23jShmYNZtqTqmwFd/GCYgVhYVbaKpZYsRj /aH0+fZC07MeOUQDfXPlj8FA3XrOo0YPKlKt//igRYyJoRZ++xwBhMrRe/XmJUzK6dl4 N6KA== X-Gm-Message-State: AJcUukd+vRYv6ZbEeHsFIZQPXADk+L61eWpbUiGmObm4HqpcAjxXplnd HvNWJ2ACTyaH1jCfnSBO3wDq4SZc+BA0SxOwC9RS9Q== X-Google-Smtp-Source: ALg8bN5yYl1dpHyMmyH7zV3yPPSJH4UxlMrFFMR0Ckk2nDkKlL1oRBYf+ZDIER6gRcMCk2fKIZzwcoTpJ07hH1B4pqo= X-Received: by 2002:a6b:5d01:: with SMTP id r1mr2197768iob.170.1545415216857; Fri, 21 Dec 2018 10:00:16 -0800 (PST) MIME-Version: 1.0 References: <20181220191653.8671-1-ard.biesheuvel@linaro.org> <20181221175802.skyh2iwsippreaez@bivouac.eciton.net> In-Reply-To: <20181221175802.skyh2iwsippreaez@bivouac.eciton.net> From: Ard Biesheuvel Date: Fri, 21 Dec 2018 19:00:04 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH] ArmPkg/ArmLib ARM: set .fpu to let Clang 7 assemble ArmV7Support.S X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2018 18:00:19 -0000 X-List-Received-Date: Fri, 21 Dec 2018 18:00:19 -0000 Content-Type: text/plain; charset="UTF-8" On Fri, 21 Dec 2018 at 18:58, Leif Lindholm wrote: > > On Thu, Dec 20, 2018 at 08:16:53PM +0100, Ard Biesheuvel wrote: > > Clang 7 complains about the vmsr instruction in ArmV7Support.S, > > which is only available on cores that implement some flavour of > > VFP. So set the .fpu to NEON like we do in some other places. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > --- > > ArmPkg/Library/ArmLib/Arm/ArmV7Support.S | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/ArmPkg/Library/ArmLib/Arm/ArmV7Support.S b/ArmPkg/Library/ArmLib/Arm/ArmV7Support.S > > index 281499b46cbc..1808962ee3e2 100644 > > --- a/ArmPkg/Library/ArmLib/Arm/ArmV7Support.S > > +++ b/ArmPkg/Library/ArmLib/Arm/ArmV7Support.S > > @@ -268,6 +268,7 @@ ASM_FUNC(ArmEnableVFP) > > #ifndef __clang__ > > mcr p10,#0x7,r0,c8,c0,#0 > > #else > > + .fpu neon > > vmsr fpexc, r0 > > #endif > > No objection from me. But I would point out that the special clang > filtering here could possibly be dropped. > > I mean, theoretically someone could have an even older binutils, but > Linaro GCC 4.8-2013.05 will happily assemble the clang side of this > conditional. > Yeah, but that would be a separate patch, no?