From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::544; helo=mail-ed1-x544.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D4EE42194D3B8 for ; Wed, 6 Feb 2019 07:46:57 -0800 (PST) Received: by mail-ed1-x544.google.com with SMTP id h50so6276395ede.5 for ; Wed, 06 Feb 2019 07:46:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yxHhMjuke/gT2QaTUoL2AEyAIYGvnVeBFYii9vCzNL4=; b=ExZ22IKuKWmiqH/3Qi3V4Gyd1Jz1ZmpUl1DiL9YQolb0kKtssWspwZ4xtusdRMD7Fc jj/Mqg8xo1IUn0IfdrPOI4LvTaknj+wHjTh74RY75DWQ+FTfND1gePEe9q22yGHwxoMX c7FXJ+D1HS1kwHz1Wz6gO78Zcea6Ho0iKJxl4qEN7tce54GB1p0M82Q2abq5ysjzixQb VV8IyHlqEl1KV8puWbmr7wliQEyNs0M1HN2JQir2OdrvZvSPb7u3EekVnwgKhVAk7mkG S60slGeemlhdJY0QBENx5IfyIbOIhuYFbAuruA9vSRJjOpYjUFqZ7/cS7kJuUWbajmgj HBvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yxHhMjuke/gT2QaTUoL2AEyAIYGvnVeBFYii9vCzNL4=; b=VjWmU2G6txS8xL7fhM7NpYu/x8KrO+Sks9M/bGaG3w32P+p34zeyp6J7y9KonqzDJz EpsP0YE+MQMTejJVOOlpPJsrpBl7fVjMN5LFq7HA90vqzVq0x57bo3knL08sFuiAv0wZ VgRkOxZ/RH8QdZPzDvPJJcQkbdsRBKME0uGuvub+/JZsRDpfmYlZHANodqvoculdTIVp 5dJRH+ph1xDGpCJy7N7xmq0pfFXrOHop5AlTiGdmct4ca5vBdZnKYfyI3FSCp/X9DGR7 7z68xKlZoH3AdPrC4iWD1nMBnLdCxLPgkRhp6T7eDBvttU43k1tT6iQyN3yniJeXwwpA NyBg== X-Gm-Message-State: AHQUAuY7+Df9KMjqnLGQIlH5q9HxS5j/+Eb/2Bj25Qivj+Vnu864TYSX R1m4VmzMEMnUehlwU+NgjdIc3RkXPL7OiOeyNNRVdA== X-Google-Smtp-Source: AHgI3IY3r+CB+oKe5dTdikchlHAtc8JYmUMr4gOTZZ68h4Oln0VDceCAkJAW/UuPLhs0olnzZKaeTyOnd7CYA0ajzmc= X-Received: by 2002:a17:906:791:: with SMTP id l17mr7700886ejc.76.1549468015338; Wed, 06 Feb 2019 07:46:55 -0800 (PST) MIME-Version: 1.0 References: <20190206121109.8776-1-lersek@redhat.com> In-Reply-To: <20190206121109.8776-1-lersek@redhat.com> From: Ard Biesheuvel Date: Wed, 6 Feb 2019 15:46:44 +0000 Message-ID: To: Laszlo Ersek Cc: "edk2-devel@lists.01.org" , Julien Grall Subject: Re: [PATCH 00/14] ArmVirtPkg: clean up set-but-unused PCDs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 X-List-Received-Date: Wed, 06 Feb 2019 15:46:58 -0000 Content-Type: text/plain; charset="UTF-8" On Wed, 6 Feb 2019 at 12:11, Laszlo Ersek wrote: > > Repo: https://github.com/lersek/edk2.git > Branch: armvirt_pcd_clean > > (1) The procedure described below depends on: > > [edk2] [PATCH] > BaseTools/BuildReport: fix report for platforms/arches without struct PCDs > > http://mid.mail-archive.com/20190205112213.682-1-lersek@redhat.com > https://lists.01.org/pipermail/edk2-devel/2019-February/036320.html > > (2) Background: while working on the fix in (1), I noticed that the PCD > sections in the build reports of various ArmVirt platforms contained > "PCDs not used by modules or in conditional directives". I thought > that we should attempt to clean those up. Subsequently I built the > following 36 ArmVirt platforms: > > > extra_opts=("" "-D HTTP_BOOT_ENABLE -D NETWORK_IP6_ENABLE -D SECURE_BOOT_ENABLE -D TTY_TERMINAL") > > for arch in ARM AARCH64; do > > for platform in Qemu QemuKernel Xen; do > > for target in NOOPT DEBUG RELEASE; do > > for extra in 0 1; do > > GCC5_ARM_PREFIX=arm-linux-gnu- \ > > GCC5_AARCH64_PREFIX=aarch64-linux-gnu- \ > > build \ > > -a $arch \ > > -p ArmVirtPkg/ArmVirt${platform}.dsc \ > > -t GCC5 \ > > -b $target \ > > -n $(getconf _NPROCESSORS_ONLN) \ > > --report-file=$HOME/tmp/report.$arch.$platform.$target.$extra.txt \ > > --report-type=PCD \ > > --cmd-len=65536 \ > > ${extra_opts[$extra]} > > done > > done > > done > > done > > Then I gradually eliminated the redundant PCD settings. > > (3) At the bottom of this email (i.e., the series cover letter), I'm > including a base64-encoded tarball of report files, saved (like > described in (2)) before and after the series. Diffing the reports > proves that the series cleans up the PCD settings without any > changes observable to modules. > > (4) The series advances in small steps. The reason is that some of the > facts exposed could be surprising (I know I was surprised), and we > could decide that we want to do something else (e.g. file a BZ, and > fill the gap later). For such cases I wanted to be able to drop > individual patches at will. > > Cc: Ard Biesheuvel > Cc: Julien Grall > > Thanks, > Laszlo > > Laszlo Ersek (14): > ArmVirtPkg/ArmVirtQemuKernel: don't set PcdCPUCoresStackBase > ArmVirtPkg: don't set PcdRelocateVectorTable > ArmVirtPkg/{ArmVirtQemu,ArmVirtQemuKernel}: don't set > PcdTrustzoneSupport > ArmVirtPkg: don't set PcdPostCodePropertyMask > ArmVirtPkg: clean up PcdSetNxForStack setting (applies to ArmVirtQemu > only) > ArmVirtPkg/PrePi: drop wrong PcdCoreCount dependency > ArmVirtPkg: don't set PcdCoreCount > ArmVirtPkg: don't set PcdDebugClearMemoryValue > ArmVirtPkg: don't set PcdDebugPrintErrorLevel in RELEASE builds > ArmVirtPkg/ArmVirtXen: don't set PcdPL031RtcBase > ArmVirtPkg/ArmVirtXen: don't set PcdTerminalTypeGuidBuffer > ArmVirtPkg/ArmVirtXen: don't set PcdShellFile > ArmVirtPkg/ArmVirtXen: don't set PcdTurnOffUsbLegacySupport > ArmVirtPkg/ArmVirtXen: don't set Pcd*ImageVerificationPolicy > For the series Reviewed-by: Ard Biesheuvel Thanks Laszlo