public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Liming Gao <liming.gao@intel.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [Patch 2/3] ArmPkg: Update Package DSC to remove unused NetLib
Date: Tue, 28 May 2019 13:44:15 +0200	[thread overview]
Message-ID: <CAKv+Gu9yAcnuDPoB0h9uac=uCQ0V-72QDZRWAd8RtoZZ4s_trQ@mail.gmail.com> (raw)
In-Reply-To: <20190528114204.16020-3-liming.gao@intel.com>

On Tue, 28 May 2019 at 13:42, Liming Gao <liming.gao@intel.com> wrote:
>
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thanks Liming

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

I spotted these as well, in case you weren't aware:

SignedCapsulePkg/SignedCapsulePkg.dsc:
NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf
UefiPayloadPkg/UefiPayloadPkgIa32.dsc:
NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf
UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc:
NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf


> ---
>  ArmPkg/ArmPkg.dsc | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
> index 25c6ccaeb6..5f090d3087 100644
> --- a/ArmPkg/ArmPkg.dsc
> +++ b/ArmPkg/ArmPkg.dsc
> @@ -47,7 +47,6 @@
>    PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
>    PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
>
> -  NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf
>    UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
>    HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
>
> --
> 2.13.0.windows.1
>

  reply	other threads:[~2019-05-28 11:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28 11:42 [Patch 0/3] Update Package DSC for Network module movement Liming Gao
2019-05-28 11:42 ` [Patch 1/3] UefiPayloadPkg: Update Package DSC files to refer to NetworkLibs.dsc.inc Liming Gao
2019-05-28 11:42 ` [Patch 2/3] ArmPkg: Update Package DSC to remove unused NetLib Liming Gao
2019-05-28 11:44   ` Ard Biesheuvel [this message]
2019-05-28 11:42 ` [Patch 3/3] SignedCapsulePkg: Update Package DSC to remove unused network libs Liming Gao
2019-05-29  0:29   ` Zhang, Chao B
2019-05-28 11:45 ` [edk2-devel] [Patch 0/3] Update Package DSC for Network module movement Ard Biesheuvel
2019-05-28 15:02 ` Guo Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu9yAcnuDPoB0h9uac=uCQ0V-72QDZRWAd8RtoZZ4s_trQ@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox