From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=OzwmOnpV;
 spf=pass (domain: linaro.org, ip: 209.85.166.178, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-it1-f178.google.com (mail-it1-f178.google.com [209.85.166.178])
 by groups.io with SMTP; Tue, 28 May 2019 04:44:30 -0700
Received: by mail-it1-f178.google.com with SMTP id g24so3735733iti.5
        for <devel@edk2.groups.io>; Tue, 28 May 2019 04:44:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=DiOc7t61ZjQQMsCQ2/UsLG4z8IZbqWrBQ1KCM7kGCV0=;
        b=OzwmOnpVQYjb5OikL4I8W+4JuP4gYqMTiyV5/1xe7KdfifGH5PC/zYD6eoHNsaG7Rb
         X1UIO6tjNSHRLaPr10tyQIEknGiYP6aRN+vTBM1Pa28G2dTfvOUCt8lhz92BsV7aJbcU
         pxuBA4dTW4wl2ETrMkPYaBKzrzx9EuvI3voRLBwoT+SEcuF9DPMdxJO+uMxpMqfRUoFj
         NjQFjGTdpWDMjGVBV4Z8Qlng5YjwTcJjT2OGaXDTqzE8MNer+/mLHUDJmkqWPTClHLZT
         ZO/SJ2ux5XM3V18EpHZHDA1PS5NsxyHHa4yns5fY7Ev4+P7OD16szs5HyWl6fv+WnlsC
         Bidw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=DiOc7t61ZjQQMsCQ2/UsLG4z8IZbqWrBQ1KCM7kGCV0=;
        b=GtZRtx/Gpdb0FZeEYwexAUlMjbPe5GXc1gKgfpQ4olMH0ZfH01rTfgGqHCEAm8eADd
         t5VD4n1uDBHmwJ5OIiCuzuuwjHlQt0XYnLcCVCJ+vddnCQQYNLPMT8GXKoBne1JTfDfT
         kQ9hKK3ih51i9w+dRYnj5CQS5Mzdt6mg09zmqX3XP2OfuYPNY8tWC63rDZOJ+J8bD5mb
         UywC0kyyOwadmPbJYoIyLich2ZcAloDl7owd1UAs132Mp5VEd6aIG9yR/4mcZ6qwo/yt
         lfnBBP1Lz2NUokIwoAYZNemVe7xE/Hs5MFQvvkyl8VdP2KENlMJliCmLG+D/9oVlinWR
         mvVg==
X-Gm-Message-State: APjAAAWzyfiRxcV2iMydLFVEFd18sstPWHR6rGWzaPJfnQ144UKSbkcm
	eTYbrwtes+mPjCjU986+EJCUblFf2PhykLRJvjXvaw==
X-Google-Smtp-Source: APXvYqzV0IqpOLWA8SAWOURT9oU/JPwt0SlqnJPh5RSykBtRv+I2c8sm26K+3sTqydr5pvxX5g2k132sa+ECN88S1hA=
X-Received: by 2002:a24:910b:: with SMTP id i11mr2947605ite.76.1559043870089;
 Tue, 28 May 2019 04:44:30 -0700 (PDT)
MIME-Version: 1.0
References: <20190528114204.16020-1-liming.gao@intel.com> <20190528114204.16020-3-liming.gao@intel.com>
In-Reply-To: <20190528114204.16020-3-liming.gao@intel.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Tue, 28 May 2019 13:44:15 +0200
Message-ID: <CAKv+Gu9yAcnuDPoB0h9uac=uCQ0V-72QDZRWAd8RtoZZ4s_trQ@mail.gmail.com>
Subject: Re: [Patch 2/3] ArmPkg: Update Package DSC to remove unused NetLib
To: Liming Gao <liming.gao@intel.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Leif Lindholm <leif.lindholm@linaro.org>
Content-Type: text/plain; charset="UTF-8"

On Tue, 28 May 2019 at 13:42, Liming Gao <liming.gao@intel.com> wrote:
>
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thanks Liming

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

I spotted these as well, in case you weren't aware:

SignedCapsulePkg/SignedCapsulePkg.dsc:
NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf
UefiPayloadPkg/UefiPayloadPkgIa32.dsc:
NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf
UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc:
NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf


> ---
>  ArmPkg/ArmPkg.dsc | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
> index 25c6ccaeb6..5f090d3087 100644
> --- a/ArmPkg/ArmPkg.dsc
> +++ b/ArmPkg/ArmPkg.dsc
> @@ -47,7 +47,6 @@
>    PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
>    PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
>
> -  NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf
>    UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
>    HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
>
> --
> 2.13.0.windows.1
>