public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Pete Batard <pete@akeo.ie>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	"Leif Lindholm" <leif@nuviainc.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Andrei Warkentin" <awarkentin@vmware.com>
Subject: Re: [edk2-devel][PATCH 0/2] Platform/RPi: Fix compilation warnings
Date: Wed, 25 Mar 2020 10:37:57 +0100	[thread overview]
Message-ID: <CAKv+Gu9yFYPV97gpEeQZ35=moepXeT9c+o1Q-BRHFB8N8ZiW-Q@mail.gmail.com> (raw)
In-Reply-To: <20200309142119.7260-1-pete@akeo.ie>

On Mon, 9 Mar 2020 at 15:21, Pete Batard <pete@akeo.ie> wrote:
>
> This addresses the following warnings, that are generated during
> compilation of the RPi firmware:
>

Thanks Pete

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed as 3daa70143953..79c06cfaeaee


> ------------------------------------------------------------------
>
> /usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/AcpiTables/AcpiTables/OUTPUT/./Dsdt.iiii    165:       })
> Warning  3150 -                                                            Empty Resource Template (END_TAG only) ^
>
> /usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/AcpiTables/AcpiTables/OUTPUT/./Dsdt.iiii    173:       Name (_GPI, Buffer()
> Warning  3133 -                                                                                      Unknown reserved name ^  (_GPI)
>
> /usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/AcpiTables/AcpiTables/OUTPUT/./Dsdt.iiii    189:       Name (_GCI, Buffer()
> Warning  3133 -                                                                                      Unknown reserved name ^  (_GCI)
>
> /usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/AcpiTables/AcpiTables/OUTPUT/./Dsdt.iiii    218:       Name (_GDI, Buffer()
> Warning  3133 -                                                                                      Unknown reserved name ^  (_GDI)
>
> /usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/AcpiTables/AcpiTables/OUTPUT/./Dsdt.iiii    354:                     Offset (0),
> Remark   2158 -                                                                            Unnecessary/redundant use of Offset operator ^
>
> ------------------------------------------------------------------
>
> VfrCompile...
> /usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe/OUTPUT/ConfigDxeHii.i(240): WARNING: default
>         : default value re-defined with different value
>
> VfrCompile...
> /usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe/OUTPUT/ConfigDxeHii.i(246): WARNING: default
>         : default value re-defined with different value
>
> VfrCompile...
> /usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe/OUTPUT/ConfigDxeHii.i(252): WARNING: default
>         : default value re-defined with different value
>
> VfrCompile...
> /usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe/OUTPUT/ConfigDxeHii.i(258): WARNING: default
>         : default value re-defined with different value
>
> VfrCompile...
> /usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe/OUTPUT/ConfigDxeHii.i(264): WARNING: default
>         : default value re-defined with different value
>
> VfrCompile...
> /usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe/OUTPUT/ConfigDxeHii.i(270): WARNING: default
>         : default value re-defined with different value
>
> ------------------------------------------------------------------
>
> Pete Batard (2):
>   Platform/RPi/AcpiTables: Fix ASL compilation warnings
>   Platform/RPi/ConfigDxe: Fix a compilation warning
>
>  Platform/RaspberryPi/AcpiTables/AcpiTables.inf          | 3 +++
>  Platform/RaspberryPi/AcpiTables/Xhci.asl                | 1 -
>  Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 6 ------
>  Platform/RaspberryPi/RPi3/RPi3.dsc                      | 2 +-
>  Platform/RaspberryPi/RPi4/RPi4.dsc                      | 2 +-
>  Platform/RaspberryPi/RaspberryPi.dec                    | 2 +-
>  6 files changed, 6 insertions(+), 10 deletions(-)
>
> --
> 2.21.0.windows.1
>

      parent reply	other threads:[~2020-03-25  9:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-09 14:21 [edk2-devel][PATCH 0/2] Platform/RPi: Fix compilation warnings Pete Batard
2020-03-09 14:21 ` [edk2-devel][PATCH 1/2] Platform/RPi/AcpiTables: Fix ASL " Pete Batard
2020-03-09 14:21 ` [edk2-devel][PATCH 2/2] Platform/RPi/ConfigDxe: Fix a compilation warning Pete Batard
2020-03-25  9:37 ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu9yFYPV97gpEeQZ35=moepXeT9c+o1Q-BRHFB8N8ZiW-Q@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox