From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d41; helo=mail-io1-xd41.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7BA7321B02822 for ; Fri, 23 Nov 2018 00:44:13 -0800 (PST) Received: by mail-io1-xd41.google.com with SMTP id s22so8243973ioc.8 for ; Fri, 23 Nov 2018 00:44:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nKWfV8ncI3fd/WkAoSwLfWOoNS/PqJSAdPEvu0O/axc=; b=SvnlLgVJ1r2fSlrTWP6Kc1qoOIFD3PmQlCWq50S9kpD+cwzYQToO+DzpWOT/LoynEr Ue6SZqKVrf4VpbjkIhU9x8bZ25HsntXUJ7jF8iwFAFfLi6jB6w9ibDSEnMJEdDqG0pAM g3esU8myhX8yFWSe62KWrJrckMDITu3ogrtp8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nKWfV8ncI3fd/WkAoSwLfWOoNS/PqJSAdPEvu0O/axc=; b=sMO89CZ6Hgf7vpJSDCCGG799xO6ZimHDY0f7lRSUJNDzoqN2eztFWzwLKObTSpiciM GbvLGCwdsYhyoGffuYkzmtd9CGV8zpCdEafbTMjcn/AKScsMPJxcPX1x9pPwzUuF4MUS quR90zjERl9iM+5bvoQzugktAF1pky+IMuJqBtgq0KH3DfL+a5uPFWWre8G43MG0dFhk k3HhtwPzpc+QU/+E81Rliag+/YFnPFOn/evp4NCLMpxQaZPIlvnG+GWtWzNLWJPd6vAI GO+VVloXGH0qa5vqucROlmBOjLhp2xEMk8opNB/50u+YiQzz+SVezR6yhgRCIYcZ0xJo qClg== X-Gm-Message-State: AA+aEWYI2ZO8IHxS+OQyY4hzEH6XhCAR/7RSLALFroOnSPcDESzC8nNu GVlXPDeKjGv0tSnn+I/aPd8LLUsgJrUx1YHsSENvzA== X-Google-Smtp-Source: AFSGD/WUVIn7UEIEYC4HFzFuu+J9LiASKJ7kmWopbFRQ9wTir95xmRwy3Ykh2M9dzcYc8ByHxg1vIJpfoGOa/EwhzJg= X-Received: by 2002:a5d:8402:: with SMTP id i2mr1873063ion.173.1542962652704; Fri, 23 Nov 2018 00:44:12 -0800 (PST) MIME-Version: 1.0 References: <20181122172645.20819-1-ard.biesheuvel@linaro.org> In-Reply-To: From: Ard Biesheuvel Date: Fri, 23 Nov 2018 09:44:03 +0100 Message-ID: To: Thomas Panakamattam Abraham Cc: "edk2-devel@lists.01.org" , Laszlo Ersek , Nariman Poushin Subject: Re: [PATCH edk2-platforms 0/4] Platform/ARM: fix DevicePath mishandling in BdsLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2018 08:44:13 -0000 Content-Type: text/plain; charset="UTF-8" On Fri, 23 Nov 2018 at 05:20, Thomas Abraham wrote: > > On Thu, Nov 22, 2018 at 10:56 PM Ard Biesheuvel > wrote: > > > > The deprecated BdsLib library class in ArmPkg is still depended upon, but > > only a single implementation exists, which now resides in edk2-platforms. > > > > This implementation has some issues in how it deals with Device Paths, > > so let's fix those, but first move over the library interface declaration. > > This will permit dropping it from ArmPkg in EDK2. > > > > Ard Biesheuvel (4): > > Platform/ARM: import ARM platform specific BdsLib header > > Platform/ARM/BdsLid: drop unused BdsStartEfiApplication () > > Platform/ARM/BdsLib: don't clobber BdsLoadImage() DevicePath IN param > > Platform/ARM/BdsLib: maintain alignment for DevicePaths > > This patch series when applied with the below two patch series > - [PATCH v2 0/5] ArmPlatformPkg, ArmVirtPkg: discover NOR flash banks from DTB > - [PATCH edk2-platforms 0/3] drop GUIDs from NOR flash bank descriptors > > does solve the boot issue on the Juno board. Wonderful! Thanks for confirming. > > > > Platform/ARM/ARM.dec | 3 + > > .../Drivers/FdtPlatformDxe/FdtPlatformDxe.inf | 2 +- > > Platform/ARM/Include/Library/BdsLib.h | 193 ++++++++++++++++++ > > Platform/ARM/Library/BdsLib/BdsFilePath.c | 71 ++----- > > Platform/ARM/Library/BdsLib/BdsInternal.h | 1 - > > Platform/ARM/Library/BdsLib/BdsLib.inf | 2 +- > > 6 files changed, 212 insertions(+), 60 deletions(-) > > create mode 100644 Platform/ARM/Include/Library/BdsLib.h > > > > -- > > 2.17.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel