From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::144; helo=mail-it1-x144.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x144.google.com (mail-it1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 68A1E21959CB2 for ; Mon, 14 Jan 2019 09:05:43 -0800 (PST) Received: by mail-it1-x144.google.com with SMTP id a6so394396itl.4 for ; Mon, 14 Jan 2019 09:05:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qC+KHgth7NXMfT4dX1oNMoCpHFTcCo/c4g1Ubuumupo=; b=Uhv3zKPcE0aSe9LxB9WTVwPpJOlUjgANUJCdXXGF7W8NJInW4s2BMB5qmGJ7aJBf51 C/0Llrl1EL5Mp/9/8XXj7nCNztm8m9h9hiafDnrW84A5LSresE698NLCWKb4scjjSQG4 EXcr5Mlgd9VDpzVQ3BqwNr5XlWHJPP01a3kP4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qC+KHgth7NXMfT4dX1oNMoCpHFTcCo/c4g1Ubuumupo=; b=iJDOEU4NsnwWkW4asU/xH2+oiSXg9C150tZOKawfaA+jXVheoz5iZo8ox3ZKo2Lkjo jt6PhSUWXPwr1CCkdX25Nuiw+J68MOM5KWf9HaJnr8Pz9ZndalAXDn5L9BTib0aVpA9l vejxBjKX049BtNmqtSQpUtp52wQlXgw/WojcBVkb7KBv/c8uB5uVweUAA9p8EhQAzcZ8 3nzFJmlH9wNYWkMlV+TsFE4GeX6j2mz5Fk8ejbwcPQJEqzfzeDcOayyl2d2ceseecb0i cHB7lOG3npJmGS8SHWQ6FmxZY5h++EqqkF8yyaLlKnAdp7jjbUp5IhasQigTr/gPJ4Cp XtAg== X-Gm-Message-State: AJcUukdn0Ida1guL1GLMukK1TT2B0uGfBl66GchFy6wtphrI4Qtep4LH sSODEM4UlvCN+SqYaLEt61UrACiddAfCjp3R0UHjlA== X-Google-Smtp-Source: ALg8bN7bln3paMY6eUvrIW4i5qe/BJQ+4laJQ5YOjIjeIy7CpZNfOp464YdCEHTzX1RNKIPDoeKGDZP8huM61YHb1HA= X-Received: by 2002:a24:710:: with SMTP id f16mr54092itf.121.1547485542581; Mon, 14 Jan 2019 09:05:42 -0800 (PST) MIME-Version: 1.0 References: <20190114132758.24054-1-ard.biesheuvel@linaro.org> <20190114132758.24054-3-ard.biesheuvel@linaro.org> <7f8a4f54-857b-44bb-1eed-ae51505786b0@redhat.com> In-Reply-To: <7f8a4f54-857b-44bb-1eed-ae51505786b0@redhat.com> From: Ard Biesheuvel Date: Mon, 14 Jan 2019 18:05:31 +0100 Message-ID: To: Laszlo Ersek Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Michael D Kinney , Liming Gao , Jian J Wang , Hao Wu , Jagadeesh Ujja , Achin Gupta , Thomas Panakamattam Abraham , Sami Mujawar , Star Zeng Subject: Re: [PATCH v2 02/17] OvmfPkg: add MmServicesTableLib resolution X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 17:05:43 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, 14 Jan 2019 at 17:40, Laszlo Ersek wrote: > > On 01/14/19 14:27, Ard Biesheuvel wrote: > > The SMM based FTW and variable drivers are going to depend on > > MmServicesTableLib after a subsequent patch, so add a resolution > > for it to various OvmfPkg .dsc files. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > --- > > OvmfPkg/OvmfPkgIa32.dsc | 1 + > > OvmfPkg/OvmfPkgIa32X64.dsc | 1 + > > OvmfPkg/OvmfPkgX64.dsc | 1 + > > 3 files changed, 3 insertions(+) > > > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > > index 3f3533e5c163..aee19b75d7ae 100644 > > --- a/OvmfPkg/OvmfPkgIa32.dsc > > +++ b/OvmfPkg/OvmfPkgIa32.dsc > > @@ -385,6 +385,7 @@ [LibraryClasses.common.DXE_SMM_DRIVER] > > ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > > SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf > > + MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTableLib.inf > > SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.inf > > !ifdef $(DEBUG_ON_SERIAL_PORT) > > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > > index 6c08b2728d63..90cbd8e34158 100644 > > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > > @@ -390,6 +390,7 @@ [LibraryClasses.common.DXE_SMM_DRIVER] > > ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > > SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf > > + MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTableLib.inf > > SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.inf > > !ifdef $(DEBUG_ON_SERIAL_PORT) > > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > > index 4072c839d73f..83d16eb00b82 100644 > > --- a/OvmfPkg/OvmfPkgX64.dsc > > +++ b/OvmfPkg/OvmfPkgX64.dsc > > @@ -390,6 +390,7 @@ [LibraryClasses.common.DXE_SMM_DRIVER] > > ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > > SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf > > + MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTableLib.inf > > SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.inf > > !ifdef $(DEBUG_ON_SERIAL_PORT) > > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > > > > Reviewed-by: Laszlo Ersek > Thanks. > Also, because this patch is clearly equivalent (although not textually > identical) to the one I used in > , > I believe we should add: > > Regression-tested-by: Laszlo Ersek > OK. > (From the blurb, I sought to familiarize myself with the anatomy of this > v2 series, and after checking my R-t-b on patches v2 05/17 and v2 07/17, > I think v2 02/17 -- i.e., this patch -- is the only one where my review > is required. Please correct me if I'm wrong.) > Indeed.