Re: [PATCH] BaseTools/tools_def CLANG35: ignore unknown warning options

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 22 January 2018 at 02:21, Gao, Liming <liming.gao@intel.com> wrote:
> Reviewed-by: Liming Gao <liming.gao@intel.com>
>

Thanks Liming.

Do you agree to add this to CLANG38_WARNING_OVERRIDES as well? We need
this on ARM, and I assume on x86 as well.


>>-----Original Message-----
>>From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
>>Sent: Saturday, January 20, 2018 12:22 AM
>>To: edk2-devel@lists.01.org
>>Cc: leif.lindholm@linaro.org; Gao, Liming <liming.gao@intel.com>; Zhu,
>>Yonghong <yonghong.zhu@intel.com>; Ard Biesheuvel
>><ard.biesheuvel@linaro.org>
>>Subject: [PATCH] BaseTools/tools_def CLANG35: ignore unknown warning
>>options
>>
>>Ironically, disabling warnings in the OpensslLib library build is
>>causing breakage when using the CLANG35 toolchain to build for ARM:
>>
>>error: unknown warning option '-Werror=maybe-uninitialized'; did you mean
>>'-Werror=uninitialized'? [-Werror,-Wunknown-warning-option]
>>
>>So let's add -Wno-unknown-warning-option to the list of warning to
>>ignore when using Clang 3.5
>>
>>Contributed-under: TianoCore Contribution Agreement 1.1
>>Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>---
>> BaseTools/Conf/tools_def.template | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/BaseTools/Conf/tools_def.template
>>b/BaseTools/Conf/tools_def.template
>>index d8fde02ea351..6afe5ebe9fe3 100755
>>--- a/BaseTools/Conf/tools_def.template
>>+++ b/BaseTools/Conf/tools_def.template
>>@@ -5595,7 +5595,7 @@ RELEASE_GCC5_AARCH64_DLINK_FLAGS =
>>DEF(GCC5_AARCH64_DLINK_FLAGS) -flto -Os -L$(W
>> DEFINE CLANG35_ARM_TARGET        = -target arm-linux-gnueabihf
>> DEFINE CLANG35_AARCH64_TARGET    = -target aarch64-linux-gnu
>>
>>-DEFINE CLANG35_WARNING_OVERRIDES = -Wno-parentheses-equality -
>>Wno-tautological-compare -Wno-tautological-constant-out-of-range-compare
>>-Wno-empty-body
>>+DEFINE CLANG35_WARNING_OVERRIDES = -Wno-parentheses-equality -
>>Wno-tautological-compare -Wno-tautological-constant-out-of-range-compare
>>-Wno-empty-body -Wno-unknown-warning-option
>> DEFINE CLANG35_ARM_CC_FLAGS      = DEF(GCC_ARM_CC_FLAGS)
>>DEF(CLANG35_ARM_TARGET) DEF(CLANG35_WARNING_OVERRIDES)
>> DEFINE CLANG35_AARCH64_CC_FLAGS  = DEF(GCC_AARCH64_CC_FLAGS)
>>DEF(CLANG35_AARCH64_TARGET) -mcmodel=small
>>DEF(CLANG35_WARNING_OVERRIDES)
>>
>>--
>>2.11.0
>