From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DD93521D2BF18 for ; Mon, 22 Jan 2018 00:46:24 -0800 (PST) Received: by mail-io0-x242.google.com with SMTP id n7so8679275iob.0 for ; Mon, 22 Jan 2018 00:51:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=uHPCBVnG0CzTfFRowede3Rm1arCBoHFwNVZN1U/cZR8=; b=Hs5kIJVc3t0QsN9x3PfgI/b9v8ZIIZO7RxgYE/Sa6VtOKud94n55R3298Jp2+llt8+ t+ok4cufxhSgpCOHNuONEqBV5H8RxUIoyiQWxqRLZlHHHoUm1oWoaKT37Qa+CAn/PqdR eCSOKKhGfvUt8iVDHHHWtHMSyuMXuD4DrjFdE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=uHPCBVnG0CzTfFRowede3Rm1arCBoHFwNVZN1U/cZR8=; b=tetGxAfaezV3gmRJCjWwA357/q0hc1Rty7gD0n6KBOIJShkG7I7f7/eFVvgCgdlgHT MCKntOWadL2o0eZx4TLB87laqhueMwTWxxvaR8F6OAvJgEf3jV/Y+2qZoQ5v+nWbulrp ZFyLvAKHLdbuXeG4DvfqlbKU3cHXbeN7YDw9G+q/dho8hgB7Eyuun5tXG9DAJMb2gm6/ L0DlOPK1HOOdm6rqNyPFUP1Es5au4liEW785rU0k1AbMOmSWq8KyOPTSgRZgTiBA16HZ oBKsg7o+odwzVVJ5scon42DMufm049YOGdZo1gSMT5ToRur32vncl7ISH3RkjpAhcaLi Y71A== X-Gm-Message-State: AKwxytegGBTf2/ZamyUFuwqi9qX1RHkYomcfEaGju2FCj1NlNNg+iv4Q 1YJfvUT2wFFacVGVEoKKxncTB8smb7sH8bw6TiSRcw== X-Google-Smtp-Source: AH8x2246K5vo0bIXBG94nq9UB/NRhgYl7Am8g8u8V+QX7mTv1tB2r1trnB+GEjSygLc2eRYomg20zjjaHHg204ZXiAY= X-Received: by 10.107.6.161 with SMTP id f33mr7890888ioi.196.1516611109709; Mon, 22 Jan 2018 00:51:49 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.112.13 with HTTP; Mon, 22 Jan 2018 00:51:49 -0800 (PST) In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1A70E6@SHSMSX104.ccr.corp.intel.com> References: <20180119162207.13207-1-ard.biesheuvel@linaro.org> <4A89E2EF3DFEDB4C8BFDE51014F606A14E1A70E6@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Mon, 22 Jan 2018 08:51:49 +0000 Message-ID: To: "Gao, Liming" Cc: "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" , "Zhu, Yonghong" Subject: Re: [PATCH] BaseTools/tools_def CLANG35: ignore unknown warning options X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 08:46:25 -0000 Content-Type: text/plain; charset="UTF-8" On 22 January 2018 at 02:21, Gao, Liming wrote: > Reviewed-by: Liming Gao > Thanks Liming. Do you agree to add this to CLANG38_WARNING_OVERRIDES as well? We need this on ARM, and I assume on x86 as well. >>-----Original Message----- >>From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >>Sent: Saturday, January 20, 2018 12:22 AM >>To: edk2-devel@lists.01.org >>Cc: leif.lindholm@linaro.org; Gao, Liming ; Zhu, >>Yonghong ; Ard Biesheuvel >> >>Subject: [PATCH] BaseTools/tools_def CLANG35: ignore unknown warning >>options >> >>Ironically, disabling warnings in the OpensslLib library build is >>causing breakage when using the CLANG35 toolchain to build for ARM: >> >>error: unknown warning option '-Werror=maybe-uninitialized'; did you mean >>'-Werror=uninitialized'? [-Werror,-Wunknown-warning-option] >> >>So let's add -Wno-unknown-warning-option to the list of warning to >>ignore when using Clang 3.5 >> >>Contributed-under: TianoCore Contribution Agreement 1.1 >>Signed-off-by: Ard Biesheuvel >>--- >> BaseTools/Conf/tools_def.template | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >>diff --git a/BaseTools/Conf/tools_def.template >>b/BaseTools/Conf/tools_def.template >>index d8fde02ea351..6afe5ebe9fe3 100755 >>--- a/BaseTools/Conf/tools_def.template >>+++ b/BaseTools/Conf/tools_def.template >>@@ -5595,7 +5595,7 @@ RELEASE_GCC5_AARCH64_DLINK_FLAGS = >>DEF(GCC5_AARCH64_DLINK_FLAGS) -flto -Os -L$(W >> DEFINE CLANG35_ARM_TARGET = -target arm-linux-gnueabihf >> DEFINE CLANG35_AARCH64_TARGET = -target aarch64-linux-gnu >> >>-DEFINE CLANG35_WARNING_OVERRIDES = -Wno-parentheses-equality - >>Wno-tautological-compare -Wno-tautological-constant-out-of-range-compare >>-Wno-empty-body >>+DEFINE CLANG35_WARNING_OVERRIDES = -Wno-parentheses-equality - >>Wno-tautological-compare -Wno-tautological-constant-out-of-range-compare >>-Wno-empty-body -Wno-unknown-warning-option >> DEFINE CLANG35_ARM_CC_FLAGS = DEF(GCC_ARM_CC_FLAGS) >>DEF(CLANG35_ARM_TARGET) DEF(CLANG35_WARNING_OVERRIDES) >> DEFINE CLANG35_AARCH64_CC_FLAGS = DEF(GCC_AARCH64_CC_FLAGS) >>DEF(CLANG35_AARCH64_TARGET) -mcmodel=small >>DEF(CLANG35_WARNING_OVERRIDES) >> >>-- >>2.11.0 >