From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Jagadeesh Ujja <jagadeesh.ujja@arm.com>, Ting Ye <ting.ye@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Gao, Liming" <liming.gao@intel.com>,
"Zhang, Chao B" <chao.b.zhang@intel.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
Achin Gupta <Achin.Gupta@arm.com>,
Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>,
Jian J Wang <jian.j.wang@intel.com>
Subject: Re: [PATCH v2 11/11] CryptoPkg/BaseCryptLib: allow MM_STANDALONE drivers to use this library
Date: Fri, 4 Jan 2019 11:35:27 +0100 [thread overview]
Message-ID: <CAKv+Gu9zkwhKStR2KRu-dxW93EtcnPmL8ZXBygL-qodHDriZmg@mail.gmail.com> (raw)
In-Reply-To: <1546434828-24405-12-git-send-email-jagadeesh.ujja@arm.com>
(add the CryptoPkg maintainer)
On Wed, 2 Jan 2019 at 14:14, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
>
> “SmmCryptLib” library can be used by MM_STANDALONE drivers as well.
> So add MM_STANDALONE as the module type this library supports.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jagadeesh Ujja <jagadeesh.ujja@arm.com>
The subject is a bit misleading, please change it to
CryptoPkg/BaseCryptLib: allow MM_STANDALONE drivers to use SmmCryptLib
With that,
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> index 4829669..9a63419 100644
> --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> @@ -30,7 +30,7 @@
> MODULE_TYPE = DXE_SMM_DRIVER
> VERSION_STRING = 1.0
> PI_SPECIFICATION_VERSION = 0x0001000A
> - LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE
> + LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE MM_STANDALONE
>
> #
> # The following information is for reference only and not required by the build tools.
> --
> 2.7.4
>
prev parent reply other threads:[~2019-01-04 10:35 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 13:13 [PATCH v2 00/11] Extend secure variable service to be usable from Standalone MM Jagadeesh Ujja
2019-01-02 13:13 ` [PATCH v2 01/11] StandaloneMmPkg: Remove MM_STANDALONE LIBRARY_CLASS from StandaloneMmCoreHobLib Jagadeesh Ujja
2019-01-02 13:13 ` [PATCH v2 02/11] StandaloneMmPkg: Adding the library packages used by MM_STANDALONE drivers Jagadeesh Ujja
2019-01-02 13:13 ` [PATCH v2 03/11] MdeModulePkg: Add a PCD to indicate Standalone MM supports secure variable Jagadeesh Ujja
2019-01-02 13:13 ` [PATCH v2 04/11] MdePkg/Include: Add StandaloneMmServicesTableLib library Jagadeesh Ujja
2019-01-03 11:03 ` Ard Biesheuvel
2019-01-03 16:14 ` Laszlo Ersek
2019-01-04 11:57 ` Ard Biesheuvel
2019-01-07 15:28 ` Laszlo Ersek
2019-01-07 17:33 ` Ard Biesheuvel
2019-01-07 18:50 ` Achin Gupta
2019-01-07 18:55 ` Ard Biesheuvel
2019-01-07 19:21 ` Achin Gupta
2019-01-07 19:37 ` Ard Biesheuvel
2019-01-08 1:11 ` Laszlo Ersek
2019-01-08 13:27 ` Ard Biesheuvel
2019-01-08 16:52 ` Laszlo Ersek
2019-01-13 12:42 ` Cohen, Eugene
2019-01-14 18:51 ` Ard Biesheuvel
2019-01-02 13:13 ` [PATCH v2 05/11] MdeModulePkg/FaultTolerantWriteDxe: allow reusability as a MM driver Jagadeesh Ujja
2019-01-02 17:15 ` Ard Biesheuvel
2019-01-02 13:13 ` [PATCH v2 06/11] MdeModulePkg/Variable/RuntimeDxe: adapt for usability with MM Standalone Jagadeesh Ujja
2019-01-02 13:13 ` [PATCH v2 07/11] MdeModulePkg/Variable/RuntimeDxe: adapt as a MM Standalone driver Jagadeesh Ujja
2019-01-02 13:13 ` [PATCH v2 08/11] MdeModulePkg/VarCheckLib: allow MM_STANDALONE drivers to use this library Jagadeesh Ujja
2019-01-04 10:36 ` Ard Biesheuvel
2019-01-02 13:13 ` [PATCH v2 09/11] ArmPlatformPkg/NorFlashDxe: allow reusability as a MM driver Jagadeesh Ujja
2019-01-02 13:13 ` [PATCH v2 10/11] SecurityPkg/AuthVariableLib: allow MM_STANDALONE drivers to use this library Jagadeesh Ujja
2019-01-03 1:14 ` Zhang, Chao B
2019-01-03 6:15 ` Jagadeesh Ujja
2019-01-04 10:41 ` Ard Biesheuvel
2019-01-02 13:13 ` [PATCH v2 11/11] CryptoPkg/BaseCryptLib: " Jagadeesh Ujja
2019-01-04 10:35 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu9zkwhKStR2KRu-dxW93EtcnPmL8ZXBygL-qodHDriZmg@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox