From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Liming Gao <liming.gao@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Star Zeng <star.zeng@intel.com>
Subject: Re: [Patch] MdeModulePkg Variable: Update Pointer Minus with UINTN type
Date: Tue, 26 Dec 2017 08:39:05 +0000 [thread overview]
Message-ID: <CAKv+Gu_+LOzijt-i7kTvQ-97n3feHo2Cu5Un1Dk9dErH5Lg3qA@mail.gmail.com> (raw)
In-Reply-To: <1514277384-6480-1-git-send-email-liming.gao@intel.com>
On 26 December 2017 at 08:36, Liming Gao <liming.gao@intel.com> wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
Could you please add an explanation why this is necessary? Do we
really need 5 (!) casts to perform a simple subtraction?
> ---
> MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
> index 77905a0..a47270a 100644
> --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
> +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
> @@ -4125,7 +4125,7 @@ ConvertNormalVarStorageToAuthVarStorage (
> //
> AuthVarStorage->Format = NormalVarStorage->Format;
> AuthVarStorage->State = NormalVarStorage->State;
> - AuthVarStorage->Size = (UINT32) (UINTN) ((UINT8 *) AuthStartPtr - (UINT8 *) AuthVarStorage);
> + AuthVarStorage->Size = (UINT32)((UINTN) (UINT8 *) AuthStartPtr - (UINTN) (UINT8 *) AuthVarStorage);
> CopyGuid (&AuthVarStorage->Signature, &gEfiAuthenticatedVariableGuid);
> ASSERT (AuthVarStorage->Size <= AuthVarStroageSize);
>
> --
> 2.8.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2017-12-26 8:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-26 8:36 [Patch] MdeModulePkg Variable: Update Pointer Minus with UINTN type Liming Gao
2017-12-26 8:39 ` Ard Biesheuvel [this message]
2017-12-26 8:46 ` Gao, Liming
2017-12-26 8:51 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu_+LOzijt-i7kTvQ-97n3feHo2Cu5Un1Dk9dErH5Lg3qA@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox