From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=S2IjUNum;
 spf=pass (domain: linaro.org, ip: 209.85.166.68, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68])
 by groups.io with SMTP; Wed, 26 Jun 2019 03:00:51 -0700
Received: by mail-io1-f68.google.com with SMTP id s7so690480iob.11
        for <devel@edk2.groups.io>; Wed, 26 Jun 2019 03:00:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=1nLb6pc5y7p4fupO42MLiBcwwNjFN2kxMsXVHhckgWU=;
        b=S2IjUNumC6V/WCFcRx9D2lJfzZyeBPLZ1qLvGxFgYvhAJxe1KhDVwfaLRgbwHwv8rF
         WfjX/vbklqf+mgXfJ1gWRvifORq2EWKU8QQEzV9cbFuJt5wGohxdFaH/k2Mwr8xMLc2v
         Af4cyO8RL6hC293Iur/kEwXqQn7GSiu5/CDKR4JvAz7DaIlF/UBOeigXNzzMutkiu4M7
         Shbd7i1mZtZca1UtUwdD0GYY8tmb1jTTvjR69FBwkkz0aEcWAT4TY6V6eY1BVc27xIcw
         ayzv9/1MIEMqX15Kc7CcVw6Z9EeuEtQW4/8Po3dV9FDgU/54R/UVM6bRzCoGGjitOY3P
         Bi5w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=1nLb6pc5y7p4fupO42MLiBcwwNjFN2kxMsXVHhckgWU=;
        b=cxvjqIyD+x2LliFNt/zDj3bU+IPgDnL8dAg2fD46cf8q3S6VWUk7lPDjh2yq8anwML
         FNEalLWgX7GgsYjRTcaGNSXAeZbNDY7kmoL8P2tYejcpeGohjTMXB8NRmK/+CkVAFF9R
         SOE5kivfbThvXxNd1YzG3tS79Gyh5LKZ0CpGnOZfhFFla/Xx1GjOi9h0aJac43SZYkQq
         GtmfYnEEGBEj12+W7bee+bjSd/Om3iL6kt2q3WwtfDT8hRYDLujRMoC1oIBDGYnAJ26/
         cVckXJLFVIpCZHt3SrkjhmfafpNJ1fixfKi/31IQoVoNJE2ZkhbFLIHMMKgtu217F1MM
         dOfQ==
X-Gm-Message-State: APjAAAVuxr8TatDZQknkF+ulY4RSo1wUgxOoVvrLqZMzLtU2b7alzzOs
	5o10wNh6OXPs1v4oCHSvPoGwpheii/QH+kOpz+TI519BboY=
X-Google-Smtp-Source: APXvYqyUwe9zXME1G85DLp2BtWy1xV3QFXGI27n7VwaiEztbGiHAtXuPca12jMBsVcwyytOet0SxdqpF/9zWreXqRK4=
X-Received: by 2002:a02:c90d:: with SMTP id t13mr3781888jao.62.1561543250940;
 Wed, 26 Jun 2019 03:00:50 -0700 (PDT)
MIME-Version: 1.0
References: <20190508095255.2897-1-tzy.way.ooi@intel.com> <b527ae8295b08da13e21b17503be304d06dad767.camel@intel.com>
 <CAKv+Gu_6ZTMZFsH+boUEbZkuiZgAdVNqB56V4AJTbXioK2O6HQ@mail.gmail.com>
 <5F1105621EDF844291AF8B109E27C06D34D05FCC@PGSMSX109.gar.corp.intel.com>
 <CAKv+Gu-W0-asrepTTYmhVY1mi4hAqXygTwX2j0WB5byrk7XY=A@mail.gmail.com>
 <5F1105621EDF844291AF8B109E27C06D34D1FB27@PGSMSX109.gar.corp.intel.com>
 <CAKv+Gu_rvuso6rhmDZiU1nzm1n=KreOiObM7DOoyfA4DP-FT0g@mail.gmail.com> <5F1105621EDF844291AF8B109E27C06D34D21B38@PGSMSX109.gar.corp.intel.com>
In-Reply-To: <5F1105621EDF844291AF8B109E27C06D34D21B38@PGSMSX109.gar.corp.intel.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Wed, 26 Jun 2019 12:00:37 +0200
Message-ID: <CAKv+Gu_+U2iqCV2g6Jpv8nZJjvkhsSuCLeW25Ewmdj+aSL03kA@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH v4 edk2-platforms 1/1] Silicon/DesignWare/Driver: DwEmacSnpDxe: Add DesignWare EMAC driver
To: edk2-devel-groups-io <devel@edk2.groups.io>, "Ooi, Tzy Way" <tzy.way.ooi@intel.com>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>, "Loh, Tien Hock" <tien.hock.loh@intel.com>, 
	"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>
Content-Type: text/plain; charset="UTF-8"

On Wed, 26 Jun 2019 at 11:35, Ooi, Tzy Way <tzy.way.ooi@intel.com> wrote:
>
> Hi Bieshuevel,
>
> You mentioned that "Are these discrete components? If so, I wonder we should use some kind of abstraction for the PHY operation". In our system, the MAC is only connected to this PHY, hence wonder if is it ok to still maintain as it is for now?
>

I think that is ok for now, since it is what all ethernet drivers do.

> Also, may I know if you could explain more on what is abstraction for the PHY?
>

MAC <-> PHY communication uses a standardized programming interface
over a standardized bus, so there is bound to be an opportunity for
sharing more code between drivers than we do today.