public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: Leif Lindholm <leif.lindholm@linaro.org>,
	 "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH edk2-platforms 3/3] Silicon/SynQuacer: add support for DEBUG output on second UART
Date: Tue, 15 Jan 2019 00:18:27 +0100	[thread overview]
Message-ID: <CAKv+Gu_+thT4RTo1J=ccrwPjx0ccp+NTJPw6Yc17O=-Auuq7ug@mail.gmail.com> (raw)
In-Reply-To: <9e5d26f9f11c5929@bloch.sibelius.xs4all.nl>

On Sat, 12 Jan 2019 at 19:25, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>
> > Date: Fri, 11 Jan 2019 17:58:44 +0000
> > From: Leif Lindholm <leif.lindholm@linaro.org>
> >
> > On Wed, Dec 26, 2018 at 02:25:30PM +0100, Ard Biesheuvel wrote:
> > > On headless server systems where the PL011 serial port is the primary
> > > console, having DEBUG output on the same port can be annoying, since
> > > DEBUG output gets lost when the console driver clears the screen or
> > > positions the cursor using control characters.
> > >
> > > So add the ability to emit the DEBUG output on the DesignWare FUART
> > > (which is exposed via the LS connector on DeveloperBox)
> >
> > >From what I can tell, the DesignWare component is 8250-compatible, yet
> > here we're using the 16550 driver. I presume this makes no difference
> > for how we're using it, but could you add a comment to this effect to
> > the commit message? (If the FUART is indeed a 16550 clone, please add
> > a statement to that effect instead.)
>
> The DesignWare component is (largely) 16550-compatible.  But the
> FIFO's are optional and if they're not included you'll end up with
> something that's probably closer to an 16450.  I suspect in most cases
> SoC designers will include the FIFO's though since without them you
> really can't use the port at anything but the slowest speeds.
>

Thanks Mark

Series pushed as e6fd447b23b6..307f7f5bfc4f (with Mark's clarification
added to the commit log of 3/3)


      reply	other threads:[~2019-01-14 23:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-26 13:25 [PATCH edk2-platforms 0/3] synquacer multi-uart support Ard Biesheuvel
2018-12-26 13:25 ` [PATCH edk2-platforms 1/3] Silicon/SynQuacer/AcpiTables: don't use PCD for PL011 base Ard Biesheuvel
2018-12-26 13:25 ` [PATCH edk2-platforms 2/3] Silicon/SynQuacer/AcpiTables: expose second UART to the OS Ard Biesheuvel
2018-12-26 13:25 ` [PATCH edk2-platforms 3/3] Silicon/SynQuacer: add support for DEBUG output on second UART Ard Biesheuvel
2019-01-11 17:58   ` Leif Lindholm
2019-01-12 18:18     ` Mark Kettenis
2019-01-14 23:18       ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu_+thT4RTo1J=ccrwPjx0ccp+NTJPw6Yc17O=-Auuq7ug@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox