From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d41; helo=mail-io1-xd41.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DE06C211B5A5C for ; Mon, 14 Jan 2019 15:18:39 -0800 (PST) Received: by mail-io1-xd41.google.com with SMTP id r200so609679iod.11 for ; Mon, 14 Jan 2019 15:18:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jnxCdl7bSfxzCs3rfieRdITHO68agOlcyYO4o5kyx5c=; b=eVebFtY7ai9DVJWNCA5rU04FRexSkZs5U7UnLDqrVf7MyimwN4luIfN6/2L2P5WDXb rgsPkKOb3ZsLfYnqkfeAvyva9Ovs6C+2zrZomMvNHrQaLUJ7qVVNqAcgpHAeiQTs1o1J htvCsqTyOvKlCQH+RQCk88XMkOtPG9iWlJNGc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jnxCdl7bSfxzCs3rfieRdITHO68agOlcyYO4o5kyx5c=; b=Lsa2qY1B/yiVFftp67B8KkzKqPfYIQol2Tffj9VDlp+10P5KXWPsWusjBNSFoLMX93 6yw9zPr1NOxmEwXQ7gPCUPS7L0xFlx80ID6K8FQUMNqhyamWLGzbTlriR4lEETzwW761 nHyBqx64qVTge88Z78dkxjX86A+BCUen3rQOuGp2O76nfolVvK/merUrj39f7SFyFRta Fv4Twhmb/Pg27MrjMXL6CKZE8f1q9V98/p6cX+aUBl3vW05RhCJyLcicThc9dCkgWtFo TGl7MDorclmXMTPjmfKLNUMR6CzVdgVSK6CJiUUfngLiBf3vYtE9Qhr/ipOM3xjW6032 UPLQ== X-Gm-Message-State: AJcUukf++UXYTiwEhkSYsOWYf9oVMTaEAj8YMsBAZFOqC+i/c0nvID+8 gD5YCzWSXcQi9T7ggNL2jJ8MmNwZAFt46fgX2TJuTQ== X-Google-Smtp-Source: ALg8bN7sa+FSDpiRPsEsgzrfpUEJ8vh9tGimBfcOmO1zn5EQFwBvJ43b03B7lU3KJLjBvUt0ACiUpX5SXPU1+IqNMDI= X-Received: by 2002:a5e:c206:: with SMTP id v6mr561896iop.60.1547507918795; Mon, 14 Jan 2019 15:18:38 -0800 (PST) MIME-Version: 1.0 References: <20181226132530.8445-1-ard.biesheuvel@linaro.org> <20181226132530.8445-4-ard.biesheuvel@linaro.org> <20190111175844.cvxsze74xylv7s3s@bivouac.eciton.net> <9e5d26f9f11c5929@bloch.sibelius.xs4all.nl> In-Reply-To: <9e5d26f9f11c5929@bloch.sibelius.xs4all.nl> From: Ard Biesheuvel Date: Tue, 15 Jan 2019 00:18:27 +0100 Message-ID: To: Mark Kettenis Cc: Leif Lindholm , "edk2-devel@lists.01.org" Subject: Re: [PATCH edk2-platforms 3/3] Silicon/SynQuacer: add support for DEBUG output on second UART X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 23:18:40 -0000 Content-Type: text/plain; charset="UTF-8" On Sat, 12 Jan 2019 at 19:25, Mark Kettenis wrote: > > > Date: Fri, 11 Jan 2019 17:58:44 +0000 > > From: Leif Lindholm > > > > On Wed, Dec 26, 2018 at 02:25:30PM +0100, Ard Biesheuvel wrote: > > > On headless server systems where the PL011 serial port is the primary > > > console, having DEBUG output on the same port can be annoying, since > > > DEBUG output gets lost when the console driver clears the screen or > > > positions the cursor using control characters. > > > > > > So add the ability to emit the DEBUG output on the DesignWare FUART > > > (which is exposed via the LS connector on DeveloperBox) > > > > >From what I can tell, the DesignWare component is 8250-compatible, yet > > here we're using the 16550 driver. I presume this makes no difference > > for how we're using it, but could you add a comment to this effect to > > the commit message? (If the FUART is indeed a 16550 clone, please add > > a statement to that effect instead.) > > The DesignWare component is (largely) 16550-compatible. But the > FIFO's are optional and if they're not included you'll end up with > something that's probably closer to an 16450. I suspect in most cases > SoC designers will include the FIFO's though since without them you > really can't use the port at anything but the slowest speeds. > Thanks Mark Series pushed as e6fd447b23b6..307f7f5bfc4f (with Mark's clarification added to the commit log of 3/3)