From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 728D221A04E2F for ; Thu, 30 Nov 2017 09:07:38 -0800 (PST) Received: by mail-it0-x244.google.com with SMTP id d16so9268613itj.1 for ; Thu, 30 Nov 2017 09:12:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Yi4YwJ6z4inZYukU2z7/Hzs+cvotbk4mE01yriQfOE8=; b=AlaG7yvaAKJlTlOOY16Vr7AjyYy0esjE7kL/ZpErE2Zfa+P6AFePCyP6kkjNRRMqg3 7Z3SASCCRdLjeVKyS0ttLFv6BelKhHAaP3y7ynbPm70UvwgLn8sd8wmOUlrmUapsqBnl 5W/ZL9XtBOfC1AQU8YWsL0pHo8bGxGYbtAe70= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Yi4YwJ6z4inZYukU2z7/Hzs+cvotbk4mE01yriQfOE8=; b=LQfueHv3CGWitzacvs5tK6Hotm2PK5vcNATber6IwzdCmkDkwY+1ui6ztWmkQsP8GW mYFteO6xxIDQFv+C/MDbqqpkJEfAbsPrJofzSMOt9eOASApd0cT6ZfFQ3NEbnd0frtGQ utWIKQSRfe9CafMOii4ym+2nPOaiahtVIzVz63hAF8oRjmhqS52zrirA2bGNOAxCzSqt SWtXWVVfy493+CweuTjLK/rDaRWGSyTxgTUeaFPIA0azoe1VDsDDNA9/o5iUyqyDOVRQ ScRCMhBPuRxkPIiZKoJkS5zHHZ+X65ui5wl+o1yn/CGMqZDo5B77rcf7ZJUiYP5tU1UE IGfQ== X-Gm-Message-State: AJaThX7UgL+PsTw3rPSSYjVmg082gOkVuJll3D5oDcpp+TjagrZ5MB5h NqfJSecYlv+riCIOxgpKzrV0thdU2MW+wAC4LfXWgEViXZM= X-Google-Smtp-Source: AGs4zMb+rBzVca0SCIrqeIVGFvJ/qWcxMaxxeEHa7cp6dxvmRS7bFrrUFChyhDWTK8A9XkNycyMT0tQGZgC4j6byozM= X-Received: by 10.36.219.214 with SMTP id c205mr3985085itg.65.1512061923232; Thu, 30 Nov 2017 09:12:03 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Thu, 30 Nov 2017 09:12:02 -0800 (PST) In-Reply-To: <20171130164532.6s4uqm62w43rqrni@bivouac.eciton.net> References: <20171130152453.19205-1-ard.biesheuvel@linaro.org> <20171130152453.19205-7-ard.biesheuvel@linaro.org> <20171130163129.ddh7xtg5co2d3bbd@bivouac.eciton.net> <20171130164532.6s4uqm62w43rqrni@bivouac.eciton.net> From: Ard Biesheuvel Date: Thu, 30 Nov 2017 17:12:02 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH 6/7] ArmPlatformPkg/PrePi; call all constructors by hand X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 17:07:38 -0000 Content-Type: text/plain; charset="UTF-8" On 30 November 2017 at 16:45, Leif Lindholm wrote: > On Thu, Nov 30, 2017 at 04:35:41PM +0000, Ard Biesheuvel wrote: >> On 30 November 2017 at 16:31, Leif Lindholm wrote: >> > On Thu, Nov 30, 2017 at 03:24:52PM +0000, Ard Biesheuvel wrote: >> >> Call ProcessLibraryConstructorList () to invoke all library constructors >> >> by hand rather than calling only some of them explicitly. >> >> >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> >> Signed-off-by: Ard Biesheuvel >> >> --- >> >> ArmPlatformPkg/PrePi/PrePi.c | 13 +++---------- >> >> 1 file changed, 3 insertions(+), 10 deletions(-) >> >> >> >> diff --git a/ArmPlatformPkg/PrePi/PrePi.c b/ArmPlatformPkg/PrePi/PrePi.c >> >> index a60cafdce45e..76a53bc871d2 100644 >> >> --- a/ArmPlatformPkg/PrePi/PrePi.c >> >> +++ b/ArmPlatformPkg/PrePi/PrePi.c >> >> @@ -33,15 +33,9 @@ >> >> UINT64 mSystemMemoryEnd = FixedPcdGet64(PcdSystemMemoryBase) + >> >> FixedPcdGet64(PcdSystemMemorySize) - 1; >> >> >> >> -EFI_STATUS >> >> -EFIAPI >> >> -ExtractGuidedSectionLibConstructor ( >> >> - VOID >> >> - ); >> >> - >> >> -EFI_STATUS >> >> +VOID >> >> EFIAPI >> >> -LzmaDecompressLibConstructor ( >> >> +ProcessLibraryConstructorList ( >> >> VOID >> >> ); >> > >> > Hmm ... >> > Do we need this local declaration? >> > Is there some header we could use? >> >> That doesn't appear to be the case, no > > Seems like a future opportunity. > >> > If not - could we move it out to PrePi.h? >> >> Yes, that works for me. > > OK, if you fold that in, for the series: > Reviewed-by: Leif Lindholm > Thanks. Pushed as c6e51751e026..73fcbb48665e I have taken the liberty of reordering this patch with the one that clones PrePi for Beagle, so this fix is applied to the clone as well. >> >> @@ -162,8 +156,7 @@ PrePiMain ( >> >> PERF_START (NULL, "PEI", NULL, StartTimeStamp); >> >> >> >> // SEC phase needs to run library constructors by hand. >> >> - ExtractGuidedSectionLibConstructor (); >> >> - LzmaDecompressLibConstructor (); >> >> + ProcessLibraryConstructorList (); >> >> >> >> // Assume the FV that contains the SEC (our code) also contains a compressed FV. >> >> Status = DecompressFirstFv (); >> >> -- >> >> 2.11.0 >> >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel