From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 91D3E20356861 for ; Mon, 13 Nov 2017 06:00:52 -0800 (PST) Received: by mail-io0-x242.google.com with SMTP id u42so2688259ioi.9 for ; Mon, 13 Nov 2017 06:04:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=w7TRTNAc1zuK1JYiZtoJnJ65+OhlozSdkW9PrJ99Fjw=; b=i421Y57KBLf9EfnmJf28PzgLkOszc0hAOKHjs4sBP2VXXV8ZgNDn/kpIKyujYOeJPF euUba2XJPt2Tt+AfVFPsldEtln1wb37qJCaTfPF0CYHok2ANCS5MMeKd0lrMwM4ZI8mJ g4OG5ertsJYnlULAF+vPeRnCm73XCcostHYNA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=w7TRTNAc1zuK1JYiZtoJnJ65+OhlozSdkW9PrJ99Fjw=; b=HvcZS6czvG0VE/Stb8R7qbRZUIQID/Ty6Tj1yPb9kdSczRyYHV0JT4TWLeyU2/HWEz H1drJcK4ONpq1pHYbhzqijSMxxaewAOySSZKJODgbprka+2oOe8oD1PJwB0VhTLeOrrS 57wELVdUDc+nxrcHQ+idwXkh51xeoWYyoKKOjUWn1kPn8G/VEM03JgU6kHSNHZ+uYgSN J02EHo+3OGbIyDSHK4TcJcPlMVhwtXoXt7yH52HMNjpjEwJSbWG80uoKaEwzNRkVcZac z0/ZKRmZFgUqQLf0+OgPZ0XRZRagktFse5lguSO1T8nAePje5f7SSGvJ6lZmNIv3sY9N MYiA== X-Gm-Message-State: AJaThX4q+vjsPjHHBHNOeV1rSXfCNSyD1pesZeNvtYNrWnskWIl1DsPX 5GVwzq9u7KLZ5XqKmSArUiNvVj6PRGMewCB68lpAkw== X-Google-Smtp-Source: AGs4zMYqxFC1KOwOksUqYBW5kSQ1XEUY5cz9/+/2jgl1wP8TjtcXWbXBsgBizh+xhZ4iTXyBjLRfBFRlbZr1DO1i25E= X-Received: by 10.107.178.145 with SMTP id b139mr4276507iof.52.1510581897706; Mon, 13 Nov 2017 06:04:57 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.20 with HTTP; Mon, 13 Nov 2017 06:04:57 -0800 (PST) In-Reply-To: <1510575804-42572-2-git-send-email-heyi.guo@linaro.org> References: <1510575804-42572-1-git-send-email-heyi.guo@linaro.org> <1510575804-42572-2-git-send-email-heyi.guo@linaro.org> From: Ard Biesheuvel Date: Mon, 13 Nov 2017 14:04:57 +0000 Message-ID: To: Heyi Guo Cc: Leif Lindholm , linaro-uefi , "edk2-devel@lists.01.org" , Graeme Gregory , "guoheyi@huawei.com" , wanghuiqiang , huangming , Jason Zhang , Mengfanrong , waip23@126.com, Liu Yi Subject: Re: [PATCH edk2-non-osi v3] Hisilicon D0x: Remove uncacheable attribute from memory resource HOB X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2017 14:00:52 -0000 Content-Type: text/plain; charset="UTF-8" On 13 November 2017 at 12:23, Heyi Guo wrote: > From: Ming Huang > > If uncacheable attribute is included in memory resource HOB, > GCD spaces will also have EFI_MEMORY_UC capability, > then NonCoherentPciIoAllocateBuffer of NonDiscoverablePciDeviceDxe > module will allocate DMA buffer of EFI_MEMORY_UC type, which will > cause alignment fault exception with BaseMemoryLibOptDxe. > > This not only affects NonDiscoverablePciDeviceDxe, it removes the > UC attribute from all DRAM regions in the UEFI memory map, > which makes much more sense on ARM > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liu Yi > Signed-off-by: Heyi Guo > Signed-off-by: Ming Huang Assuming the patch does what it says on the tin: Reviewed-by: Ard Biesheuvel > --- > Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi | Bin 90272 -> 90336 bytes > Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi | Bin 152576 -> 152480 bytes > 2 files changed, 0 insertions(+), 0 deletions(-) > > diff --git a/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi b/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi > index 354abcc..31e2903 100644 > Binary files a/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi and b/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi differ > diff --git a/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi b/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi > index b94e0cb..eb71c44 100644 > Binary files a/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi and b/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi differ > -- > 1.9.1 >