Re: [PATCH v2 10/11] SecurityPkg/AuthVariableLib: allow MM_STANDALONE drivers to use this library

From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Jagadeesh Ujja <jagadeesh.ujja@arm.com>
Cc: "Zhang, Chao B" <chao.b.zhang@intel.com>,
	 "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Gao, Liming" <liming.gao@intel.com>,
	 "leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
	"Achin.Gupta@arm.com" <Achin.Gupta@arm.com>,
	 "Supreeth.Venkatesh@arm.com" <Supreeth.Venkatesh@arm.com>,
	"Wang, Jian J" <jian.j.wang@intel.com>
Subject: Re: [PATCH v2 10/11] SecurityPkg/AuthVariableLib: allow MM_STANDALONE drivers to use this library
Date: Fri, 4 Jan 2019 11:41:02 +0100	[thread overview]
Message-ID: <CAKv+Gu_-Px14u85h1V-OypJdQ66aO76nrod3ic-KKtiVHY6bRw@mail.gmail.com> (raw)
In-Reply-To: <CADpYukagGomPx2-UZo9ruoVeg6Y8kn8nk6FFPsQ5DRqadfobnQ@mail.gmail.com>

On Thu, 3 Jan 2019 at 07:15, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
>
> On Thu, Jan 3, 2019 at 6:45 AM Zhang, Chao B <chao.b.zhang@intel.com> wrote:
> >
> > Reviewed-by : Chao Zhang <chao.b.zhang@intel.com>
>
> Hi Chao Zhang,
>
> Thanks for the review, I will not be having any new changes with this
> specific patch.
> Can you please merge this patch, so that I will not resubmit with
> other patch set
>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed as 8ef653aa5aad..38f3c1b0d274

> >
> > -----Original Message-----
> > From: Jagadeesh Ujja [mailto:jagadeesh.ujja@arm.com]
> > Sent: Wednesday, January 2, 2019 9:14 PM
> > To: edk2-devel@lists.01.org; Gao, Liming <liming.gao@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; leif.lindholm@linaro.org; ard.biesheuvel@linaro.org; Achin.Gupta@arm.com; Supreeth.Venkatesh@arm.com; Wang, Jian J <jian.j.wang@intel.com>
> > Subject: [PATCH v2 10/11] SecurityPkg/AuthVariableLib: allow MM_STANDALONE drivers to use this library
> >
> > “AuthVariableLib” library can be used by MM_STANDALONE drivers as well.
> > So add MM_STANDALONE as the module type this library supports.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Jagadeesh Ujja <jagadeesh.ujja@arm.com>
> > Reviewed-by: Chao Zhang <chao.b.zhang@intel.com>
> > ---
> >  SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf b/SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
> > index 572ba4e..4294d3b 100644
> > --- a/SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
> > +++ b/SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
> > @@ -2,6 +2,7 @@
> >  #  Provides authenticated variable services.
> >  #
> >  #  Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.<BR>
> > +#  Copyright (c) 2018, ARM Limited. All rights reserved.<BR>
> >  #
> >  #  This program and the accompanying materials  #  are licensed and made available under the terms and conditions @@ -21,12 +22,12 @@
> >    FILE_GUID                      = B23CF5FB-6FCC-4422-B145-D855DBC05457
> >    MODULE_TYPE                    = DXE_RUNTIME_DRIVER
> >    VERSION_STRING                 = 1.0
> > -  LIBRARY_CLASS                  = AuthVariableLib|DXE_RUNTIME_DRIVER DXE_SMM_DRIVER
> > +  LIBRARY_CLASS                  = AuthVariableLib|DXE_RUNTIME_DRIVER DXE_SMM_DRIVER MM_STANDALONE
> >
> >  #
> >  # The following information is for reference only and not required by the build tools.
> >  #
> > -#  VALID_ARCHITECTURES           = IA32 X64
> > +#  VALID_ARCHITECTURES           = IA32 X64 AARCH64
> >  #
> >
> >  [Sources]
> > --
> > 2.7.4
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel