From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::341; helo=mail-ot1-x341.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-ot1-x341.google.com (mail-ot1-x341.google.com [IPv6:2607:f8b0:4864:20::341]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 21F50211A2D86 for ; Thu, 20 Dec 2018 03:09:16 -0800 (PST) Received: by mail-ot1-x341.google.com with SMTP id e12so1302610otl.5 for ; Thu, 20 Dec 2018 03:09:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hLEw1OJbb94fLYDa22DTcWrkxGgNk2ZEA9aZFNlGcW0=; b=LaSjpL5I7Z9hdDzur+4FphSQ3AcGgKrGLrpz8MB0utGQpVqMAvpkm9AwVZP01u++nc m8FUQ9Y+GE+f8C2+50taJb76Aum+GcpdM098ZXeJKS91G32C7btMSDI31dsR2w1LpCKo u+RMqAdEv711p5wZ5Wuzo2NsFQkAWxM3mawMU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hLEw1OJbb94fLYDa22DTcWrkxGgNk2ZEA9aZFNlGcW0=; b=Zx6auZfwLeQ8raJhUZZQdIK6c0CpG3MQrTR1qMUcExVnLey8uDLaGSmRWXuTG399OU Rdy4KhzTtSW/gEoQuXUqp4QFjcummPILIXj6ER0qL/NKB/hMdoLB4wciw0/nJk/3EcuG uZecV03Wxq67JYtRrU/KrLIpNafwyKtEq7HhALCNIOXRqtyMfzGqt7ljXgZ00M6OlRqo 8GhsLiian86dOk0KWg+9jSTP5xFkxveqTaLn8rv0SY/mp2/uE/ybYiYZKbRCPcitebx3 CcMKTJ0Z3brH4orhWk7gPQqmnF1ZDiFXAF0v1NZEk6EEyOt4OuGGYI+ehGq/MVnEh83M Nakw== X-Gm-Message-State: AA+aEWYflwQMTdBfe0E9EmItp+2KAcQOAQIjnDU79ZQtCbIHz0Rpn7vB o6G/VmWblq8hWKuzPpaTCbC1w6VGSFhEH/hmLXAwnQ== X-Google-Smtp-Source: AFSGD/UnMizhbI3sJ4Vat1145WpL3m69ctsV+XRL8qg8/sIrfw/NoEpg81KoBU43pfHW+Ml1uZHza2cjBFtX5LpvmHg= X-Received: by 2002:a05:6830:12c4:: with SMTP id a4mr18563955otq.138.1545304155867; Thu, 20 Dec 2018 03:09:15 -0800 (PST) MIME-Version: 1.0 References: <20181218164621.19072-1-ard.biesheuvel@linaro.org> <20181219162559.5wsnkuxrtmf6qay3@bivouac.eciton.net> In-Reply-To: From: Ard Biesheuvel Date: Thu, 20 Dec 2018 12:09:04 +0100 Message-ID: To: Thomas Abraham Cc: Leif Lindholm , "edk2-devel@lists.01.org" Subject: Re: [PATCH] Platform/FVP-AArch64: switch to the SBSA watchdog X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2018 11:09:17 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, 20 Dec 2018 at 11:03, Thomas Abraham wrote: > > On Wed, Dec 19, 2018 at 10:04 PM Leif Lindholm wrote: > > > > On Tue, Dec 18, 2018 at 05:46:21PM +0100, Ard Biesheuvel wrote: > > > On the FVP Foundation model, the SP805 watchdog appears to be 'wired' > > > incorrectly, resulting in a watchdog counter that decrements at the > > > APB clock rate of 24 MHz instead of the usual 32 kHz. Since the > > > timer start value is only 32-bits wide, this makes the watchdog > > > unusable in UEFI, since the default timeout set by the DXE core is > > > 5 minutes, which is not representable in 32-bit at this clock rate. > > > > > > So switch to the SBSA watchdog instead, which is wired up to the > > > generic timer, and ticks at the correct rate. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Ard Biesheuvel > > > > From my point of view: > > Reviewed-by: Leif Lindholm > > > > But I'd like a nod from Sami or Thomas (added to cc) as well. > > I have not been able test this patch yet but the changes looks fine. > > - Thomas. > Thanks all Pushed as dc6b5ef8a6c2..88e5de1a2346