From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x230.google.com (mail-io0-x230.google.com [IPv6:2607:f8b0:4001:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1EBB281EEE for ; Thu, 24 Nov 2016 00:03:37 -0800 (PST) Received: by mail-io0-x230.google.com with SMTP id a124so66803046ioe.2 for ; Thu, 24 Nov 2016 00:03:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=mqsTwh4k2P9Qsur4WqAOkQ+23+G9ba3WJAA3sIeYRMQ=; b=JnbNj1FLlnCfVN/EsDnYRD7X2Bx00+Cj3PlADu3WXBZxzHbNHjHhp8N+f2H5M/wokx 8plQYkRe4IFzmSbdDYZTeaA7E8UJwnfRBMhwPoFNQyvmYyVWXwglIpDXd8QGKj7fovs1 T2nmEx76Q+xxphCYifhy1iKSxe/oRlv1u0ryo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=mqsTwh4k2P9Qsur4WqAOkQ+23+G9ba3WJAA3sIeYRMQ=; b=BjWANpCAke/pwvTmmr/3gaDZbASKf3cQIgXkoa79N/hEY2zMYQ60cYc9y2eWwfvRwT 96sH8ZwLrWol8GJqpMg4m1gbmf8XGaQtbwJKJRpLSsjib6rq7FYY9nxQ2ICZns0qEOBe AftGPW1DdSZSaqK0mUrgqDfN/HZeYxKSCkxRICWI9y56qTEiHLWtywwGVBn9lzBjEPrf giHGk60BJ18kgSG99Iqs2EOFDaUpxZ1ulZr/BAHXV6ff50+8qufTQ2j2p9zJFCDbq5jU 4TsIuaQxikT2YZkYy3m4faBfkqPghuLfX/Rjtf30VHiYYHniJTFpct2sGRkHiM/gG3u2 JySQ== X-Gm-Message-State: AKaTC021NLC9Nr+o2JcguYMfJLEfeexnKCnG1PDxLCUK4xLCu/8fhLSqaPcEXf+EIU/J5yQyDuG46vdoK47BMhxU X-Received: by 10.36.2.146 with SMTP id 140mr912815itu.63.1479974616406; Thu, 24 Nov 2016 00:03:36 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.59.147 with HTTP; Thu, 24 Nov 2016 00:03:35 -0800 (PST) In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14B4B8DF5@shsmsx102.ccr.corp.intel.com> References: <1479105446-23480-1-git-send-email-liming.gao@intel.com> <1479105446-23480-2-git-send-email-liming.gao@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14B4B8DF5@shsmsx102.ccr.corp.intel.com> From: Ard Biesheuvel Date: Thu, 24 Nov 2016 08:03:35 +0000 Message-ID: To: "Gao, Liming" Cc: edk2-devel-01 Subject: Re: [Patch 1/2] BaseTools tools_def.txt: Remove -P option in GCC ASLPP_FLAGS X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2016 08:03:37 -0000 Content-Type: text/plain; charset=UTF-8 On 24 November 2016 at 04:40, Gao, Liming wrote: > Ard: > Which AArch64 platforms? I will investigate it further. > https://git.linaro.org/uefi/OpenPlatformPkg.git master platform OpenPlatformPkg/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc module OpenPlatformPkg/Platforms/AMD/Styx/AcpiTables/AcpiAml.inf > Thanks > Liming >> -----Original Message----- >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >> Sent: Wednesday, November 23, 2016 6:09 PM >> To: Gao, Liming >> Cc: edk2-devel-01 >> Subject: Re: [edk2] [Patch 1/2] BaseTools tools_def.txt: Remove -P option in >> GCC ASLPP_FLAGS >> >> On 14 November 2016 at 06:37, Liming Gao wrote: >> > https://bugzilla.tianocore.org/show_bug.cgi?id=227 >> > >> > After -P option is removed, the generated preprocessed ASL file will have >> > line markers. The extra information can be removed by Trim script. ASL >> code >> > can refer to the definition in C source file. This has been supported in >> > VS and XCODE tool chains. >> > >> > Cc: Yonghong Zhu >> > Contributed-under: TianoCore Contribution Agreement 1.0 >> > Signed-off-by: Liming Gao >> > --- >> > BaseTools/Conf/tools_def.template | 4 ++-- >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> > >> >> This patch is breaking the build on some AArch64 platforms: >> >> Intel ACPI Component Architecture >> Error 6126 - syntax error, unexpected PARSEOP_NAMESEG, expecting >> PARSEOP_DEFINITION_BLOCK and premature End-Of-File >> ASL+ Optimizing Compiler version 20160831-64 >> >> and the DSDT.iiii source file has these lines at the beginning >> >> """ >> extern UINT8 _VerifySizeofBOOLEAN[(sizeof(BOOLEAN) == (1)) / >> (sizeof(BOOLEAN) == (1))]; >> extern UINT8 _VerifySizeofINT8[(sizeof(INT8) == (1)) / (sizeof(INT8) == (1))]; >> extern UINT8 _VerifySizeofUINT8[(sizeof(UINT8) == (1)) / >> (sizeof(UINT8) == (1))]; >> extern UINT8 _VerifySizeofINT16[(sizeof(INT16) == (2)) / >> (sizeof(INT16) == (2))]; >> extern UINT8 _VerifySizeofUINT16[(sizeof(UINT16) == (2)) / >> (sizeof(UINT16) == (2))]; >> extern UINT8 _VerifySizeofINT32[(sizeof(INT32) == (4)) / >> (sizeof(INT32) == (4))]; >> extern UINT8 _VerifySizeofUINT32[(sizeof(UINT32) == (4)) / >> (sizeof(UINT32) == (4))]; >> extern UINT8 _VerifySizeofINT64[(sizeof(INT64) == (8)) / >> (sizeof(INT64) == (8))]; >> extern UINT8 _VerifySizeofUINT64[(sizeof(UINT64) == (8)) / >> (sizeof(UINT64) == (8))]; >> extern UINT8 _VerifySizeofCHAR8[(sizeof(CHAR8) == (1)) / >> (sizeof(CHAR8) == (1))]; >> extern UINT8 _VerifySizeofCHAR16[(sizeof(CHAR16) == (2)) / >> (sizeof(CHAR16) == (2))]; >> extern UINT8 >> _VerifySizeof__VERIFY_UINT8_ENUM_SIZE[(sizeof(__VERIFY_UINT8_ENUM >> _SIZE) >> == (4)) / (sizeof(__VERIFY_UINT8_ENUM_SIZE) == (4))]; >> extern UINT8 >> _VerifySizeof__VERIFY_UINT16_ENUM_SIZE[(sizeof(__VERIFY_UINT16_EN >> UM_SIZE) >> == (4)) / (sizeof(__VERIFY_UINT16_ENUM_SIZE) == (4))]; >> extern UINT8 >> _VerifySizeof__VERIFY_UINT32_ENUM_SIZE[(sizeof(__VERIFY_UINT32_EN >> UM_SIZE) >> == (4)) / (sizeof(__VERIFY_UINT32_ENUM_SIZE) == (4))]; >> struct _LIST_ENTRY { >> LIST_ENTRY *ForwardLink; >> LIST_ENTRY *BackLink; >> }; >> void * __builtin_return_address (unsigned int level); >> extern GUID gEfiCallerIdGuid; >> extern CHAR8 *gEfiCallerBaseName; >> """ >> >> >> > diff --git a/BaseTools/Conf/tools_def.template >> b/BaseTools/Conf/tools_def.template >> > index 39fda78..fd56ff3 100755 >> > --- a/BaseTools/Conf/tools_def.template >> > +++ b/BaseTools/Conf/tools_def.template >> > @@ -4359,7 +4359,7 @@ DEFINE GCC_IPF_SYMRENAME_FLAGS = -- >> redefine-sym memcpy=CopyMem >> > DEFINE GCC_ASM_FLAGS = -c -x assembler -imacros >> $(DEST_DIR_DEBUG)/AutoGen.h >> > DEFINE GCC_PP_FLAGS = -E -x assembler-with-cpp -include >> $(DEST_DIR_DEBUG)/AutoGen.h >> > DEFINE GCC_VFRPP_FLAGS = -x c -E -P -DVFRCOMPILE --include >> $(DEST_DIR_DEBUG)/$(MODULE_NAME)StrDefs.h >> > -DEFINE GCC_ASLPP_FLAGS = -x c -E -P >> > +DEFINE GCC_ASLPP_FLAGS = -x c -E >> > DEFINE GCC_ASLCC_FLAGS = -x c >> > DEFINE GCC_WINDRES_FLAGS = -J rc -O coff >> > DEFINE GCC_IA32_RC_FLAGS = -I binary -O elf32-i386 -B i386 -- >> rename-section .data=.hii >> > @@ -5804,7 +5804,7 @@ RELEASE_CLANG38_X64_CC_FLAGS = >> DEF(CLANG38_ALL_CC_FLAGS) -m64 "-DEFIAPI=__ >> > *_ELFGCC_*_ASL_PATH = DEF(UNIX_IASL_BIN) >> > *_ELFGCC_*_ASL_FLAGS = DEF(IASL_FLAGS) >> > *_ELFGCC_*_ASL_OUTFLAGS = DEF(IASL_OUTFLAGS) >> > -*_ELFGCC_*_ASLPP_FLAGS = -x c -E -P >> > +*_ELFGCC_*_ASLPP_FLAGS = -x c -E >> > *_ELFGCC_*_ASLCC_FLAGS = -x c >> > *_ELFGCC_*_ASLDLINK_FLAGS = >> DEF(GCC_DLINK_FLAGS_COMMON) --entry _ReferenceAcpiTable >> > >> > -- >> > 2.8.0.windows.1 >> > >> > _______________________________________________ >> > edk2-devel mailing list >> > edk2-devel@lists.01.org >> > https://lists.01.org/mailman/listinfo/edk2-devel